Fixed BI aggregation icon for use with password store - #799
Closed
tgl27 wants to merge 1 commit into
Closed
Conversation
Fixed aggregation icon for use with password store
Member
|
Hi @tgl27, I got around to verifying the fix today and it works as expected! Thank you for bringing this to attention. I've applied your patch internally and it's up for review. Should be merged in next week. I will link to the associated Werk when it's accepted. Sorry, that it took so long to get around to it! |
Contributor
Author
|
Hi, thanks for your feedback. Regards, |
CheckmkCI
pushed a commit
that referenced
this pull request
Jul 9, 2025
SUP-22789 Closes: #799 Co-authored-by: Logan Connolly <logan.connolly@checkmk.com> Change-Id: I4e6cc42ab4adb4e34db800485d1622595e67903d
CheckmkCI
pushed a commit
that referenced
this pull request
Jul 9, 2025
SUP-22789 Closes: #799 Co-authored-by: Logan Connolly <logan.connolly@checkmk.com> Change-Id: I4e6cc42ab4adb4e34db800485d1622595e67903d
Member
|
Hi @tgl27, The fix was merged in today. Here is the associated Werk: https://checkmk.com/werk/18279 Thanks again for the patch :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed aggregation icon for use with password store
Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.
General information
Link to BI aggregation was incorrect, if password store was used.
Bug reports
Please include:
Ubuntu 24.04
Nothing special
Command for active check check_mk_active-bi_aggr was not correctly evaluated by aggregation icon
N. a.
N. a.
Proposed changes
Merge pull request
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.