Skip to content

add Ceph state "active+clean+laggy" to constants.py - #844

Closed
HenriWahl wants to merge 2 commits into
Checkmk:masterfrom
HenriWahl:add_pg_state_active+clean+laggy
Closed

add Ceph state "active+clean+laggy" to constants.py#844
HenriWahl wants to merge 2 commits into
Checkmk:masterfrom
HenriWahl:add_pg_state_active+clean+laggy

Conversation

@HenriWahl

@HenriWahl HenriWahl commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

General information

The check for Ceph misses a PG state I received on a Ceph cluster.

Proposed changes

Adding the state "active+clean+laggy" to the list of Ceph PG state constants. I added this because when a Ceph cluster runs into the added condition, which until now is not covered by the Checkmk plugin, it leads to an UNKNOWN error.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

@github-actions github-actions Bot added the Stale Scheduled for auto-close label Aug 20, 2025
@HenriWahl

Copy link
Copy Markdown
Contributor Author

Is there anybody out there? @mo-ki or @SoloJacobs?

@github-actions github-actions Bot removed the Stale Scheduled for auto-close label Aug 21, 2025
@mo-ki

mo-ki commented Aug 21, 2025

Copy link
Copy Markdown
Member

Sorry! I'm here :-)
These PRs mostly appear on my radar only when all checks are successful. I think you have to add the corresponding metric in cmk/plugins/ceph/graphing/ceph_metrics.py as well, that's why tests/unit/cmk/gui/graphing/test_from_api.py is complaining.

@mo-ki

mo-ki commented Aug 25, 2025

Copy link
Copy Markdown
Member

Thanks! I've put this in our to-be-merged queue.

@CheckmkCI CheckmkCI closed this in cdc7eb0 Oct 6, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 6, 2025
CheckmkCI pushed a commit that referenced this pull request Oct 6, 2025
and add metric_pgstate_active_clean_laggy

CMK-25499

Co-authored-by: Benedikt Seidl <benedikt.seidl@checkmk.com>
Change-Id: I08504105eec094195fad89259f45eaab150510f4
Closes: #844
@BenediktSeidl

Copy link
Copy Markdown
Contributor

thanks for your contribution. i've added your change with werk #18477

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants