[CHIA-4224] Added offer_only option to create_offer_for_ids (#2506)

* Added `offer_only` option to `create_offer_for_ids`

* Fixed type issue

* Add `offer_only` to WalletConnect registry

* Fixed type issue

Author: ChiaMineJP

packages/api/src/services/WalletService.ts

@@ -33,6 +33,35 @@ export type AllowUnsyncedArg = {
   allowUnsynced?: boolean;
 };
 
+export type CreateOfferForIdsArgs = {
+  offer: { [key: string]: number | BigNumber };
+  fee: number | BigNumber;
+  driverDict: any;
+  validateOnly?: boolean;
+  disableJSONFormatting?: boolean;
+  maxTime?: number;
+  offerOnly?: boolean;
+  extraConditions?: any[];
+  coinIds?: string[];
+} & AllowUnsyncedArg;
+
+export type CreateOfferForIdsResponse = {
+  offer: string;
+  tradeRecord: TradeRecord;
+};
+
+export type CreateOfferForIdsOfferOnlyResponse = {
+  offer: string;
+};
+
+export type CreateOfferForIdsResult<TArgs extends CreateOfferForIdsArgs> = TArgs extends { offerOnly: true }
+  ? CreateOfferForIdsOfferOnlyResponse
+  : TArgs extends { offerOnly: false }
+    ? CreateOfferForIdsResponse
+    : TArgs extends { offerOnly: boolean }
+      ? CreateOfferForIdsResponse | CreateOfferForIdsOfferOnlyResponse
+      : CreateOfferForIdsResponse;
+
 export default class Wallet extends Service {
   constructor(client: Client, options?: Options) {
     super(ServiceName.WALLET, client, options);
@@ -312,20 +341,9 @@ export default class Wallet extends Service {
     return this.command<{ myOffersCount: number; takenOffersCount: number; total: number }>('get_offers_count');
   }
 
-  async createOfferForIds(
-    args: {
-      offer: { [key: string]: number | BigNumber };
-      fee: number | BigNumber;
-      driverDict: any;
-      validateOnly?: boolean;
-      disableJSONFormatting?: boolean;
-      maxTime?: number;
-      extraConditions?: any[];
-      coinIds?: string[];
-    } & AllowUnsyncedArg,
-  ) {
+  async createOfferForIds<TArgs extends CreateOfferForIdsArgs>(args: TArgs): Promise<CreateOfferForIdsResult<TArgs>> {
     const { disableJSONFormatting, driverDict, extraConditions, coinIds, ...restArgs } = args;
-    return this.command<{ offer: string; tradeRecord: TradeRecord }>(
+    return this.command<CreateOfferForIdsResult<TArgs>>(
       'create_offer_for_ids',
       { driver_dict: driverDict, extra_conditions: extraConditions, coin_ids: coinIds, ...restArgs },
       false,

packages/gui/src/electron/constants/commandRegistry.test.ts

@@ -330,6 +330,10 @@ describe('validateDappParams', () => {
     expect(() => validateDappParams('chia_sendTransaction', { wallet_id: 1 })).not.toThrow();
   });
 
+  it('allows create_offer_for_ids to request offer-only responses', () => {
+    expect(() => validateDappParams('chia_createOfferForIds', { offer: {}, offer_only: true })).not.toThrow();
+  });
+
   it('handler-routed commands enforce the same allowlist', () => {
     expect(() => validateDappParams('chia_addCATToken', { asset_id: 'abc', name: 'My CAT' })).not.toThrow();
     expectThrow(

packages/gui/src/electron/constants/commandRegistry.ts

@@ -399,6 +399,13 @@ const SCHEMAS: Record<string, CommandSchema> = {
         isOptional: true,
         dappAllowed: true,
       },
+      {
+        name: 'offer_only',
+        label: () => i18n._(/* i18n */ { id: 'Omit transactions data' }),
+        type: 'bool',
+        isOptional: true,
+        dappAllowed: true,
+      },
       {
         name: 'extra_conditions',
         label: () => i18n._(/* i18n */ { id: 'Extra Conditions' }),