fix: address important PR review comments

Author: sricharan-varanasi

src/modules/Auth/features/Login/Login.schema.ts

@@ -7,7 +7,7 @@ import { checkPassword, getEmailValidationSchema } from 'shared/utils';
 export const loginFormSchema = () => {
   const { t } = i18n;
   const passwordRequired = t('passwordRequired');
-  const passwordMinLength = t('passwordMinLength', { count: LEGACY_PASSWORD_MIN_LENGTH });
+  const passwordMinLength = t('passwordMinLength', { chars: LEGACY_PASSWORD_MIN_LENGTH });
   const passwordBlankSpaces = t('passwordBlankSpaces');
 
   return yup
@@ -17,7 +17,11 @@ export const loginFormSchema = () => {
       password: yup
         .string()
         .required(passwordRequired)
-        .min(LEGACY_PASSWORD_MIN_LENGTH, passwordMinLength)
+        .test(
+          'min-length',
+          passwordMinLength,
+          (password) => !password || checkPassword(password, LEGACY_PASSWORD_MIN_LENGTH).meetsLength,
+        )
         .test(
           'no-whitespace',
           passwordBlankSpaces,

src/modules/Auth/features/RecoverPassword/RecoverForm/RecoverForm.schema.ts

@@ -18,7 +18,11 @@ export const newPasswordSchema = () => {
       password: yup
         .string()
         .required(passwordRequired)
-        .min(ACCOUNT_PASSWORD_MIN_LENGTH, passwordMinLength)
+        .test(
+          'min-length',
+          passwordMinLength,
+          (password) => !password || checkPassword(password).meetsLength,
+        )
         .test(
           'no-whitespace',
           passwordBlankSpaces,

src/modules/Auth/features/SignUp/SignUpForm/SignUpForm.schema.ts

@@ -22,7 +22,11 @@ export const SignUpFormSchema = () => {
       password: yup
         .string()
         .required(passwordRequired)
-        .min(ACCOUNT_PASSWORD_MIN_LENGTH, passwordMinLength)
+        .test(
+          'min-length',
+          passwordMinLength,
+          (password) => !password || checkPassword(password).meetsLength,
+        )
         .test(
           'no-whitespace',
           passwordBlankSpaces,

src/shared/utils/passwordValidation.ts

@@ -13,7 +13,10 @@ import {
 
 export type { PasswordCheckResult };
 
-export const checkPassword = (password: string): PasswordCheckResult => {
+export const checkPassword = (
+  password: string,
+  minLength: number = ACCOUNT_PASSWORD_MIN_LENGTH,
+): PasswordCheckResult => {
   const normalized = password.normalize('NFC');
   const hasCaselessLetter = CASELESS_LETTER_REGEXP.test(normalized);
   const hasUppercase = UPPERCASE_REGEXP.test(normalized) || hasCaselessLetter;
@@ -29,7 +32,7 @@ export const checkPassword = (password: string): PasswordCheckResult => {
     hasDigit,
     hasSymbol,
     hasNoSpaces: VISIBLE_ONLY_REGEXP.test(normalized) && !HIDDEN_BLANKS_REGEXP.test(normalized),
-    meetsLength: [...normalized].length >= ACCOUNT_PASSWORD_MIN_LENGTH,
+    meetsLength: [...normalized].length >= minLength,
     charTypeCount,
     meetsCharTypeRequirement: charTypeCount >= ACCOUNT_PASSWORD_MIN_CHAR_TYPES,
   };