feat: Update getMaxDate to be static prop

Author: andrevitalb

src/shared/features/AppletSettings/ExportDataSetting/ExportDataSetting.tsx

@@ -1,15 +1,16 @@
+import { yupResolver } from '@hookform/resolvers/yup';
 import { useCallback, useEffect, useMemo, useState } from 'react';
 import { FormProvider, useForm } from 'react-hook-form';
 import { ObjectSchema } from 'yup';
-import { yupResolver } from '@hookform/resolvers/yup';
 
 import { DataExportPopup } from 'shared/features/AppletSettings/ExportDataSetting/Popups/DataExportPopup';
-import { applet } from 'shared/state/Applet';
-import { getNormalizedTimezoneDate } from 'shared/utils/dateTimezone';
-import { UniqueTuple } from 'shared/types';
 import { useFeatureFlags } from 'shared/hooks';
 import { FeatureFlagDefaults } from 'shared/hooks/useFeatureFlags.const';
+import { applet } from 'shared/state/Applet';
+import { UniqueTuple } from 'shared/types';
+import { getNormalizedTimezoneDate } from 'shared/utils/dateTimezone';
 
+import { exportDataSettingSchema } from './ExportDataSetting.schema';
 import {
   ExportDataExported,
   ExportDataFormValues,
@@ -18,7 +19,6 @@ import {
   SupplementaryFiles,
   SupplementaryFilesWithFeatureFlag,
 } from './ExportDataSetting.types';
-import { exportDataSettingSchema } from './ExportDataSetting.schema';
 import { ExportSettingsPopup } from './Popups/ExportSettingsPopup/ExportSettingsPopup';
 
 export const ExportDataSetting = ({
@@ -39,21 +39,21 @@ export const ExportDataSetting = ({
   const canExportEhrHealthData = featureFlags.enableEhrHealthData !== 'unavailable';
 
   const minDate = useMemo(() => new Date(appletData?.createdAt ?? ''), [appletData]);
-  const getMaxDate = () => getNormalizedTimezoneDate(new Date().toString());
+  const maxDate = useMemo(() => getNormalizedTimezoneDate(new Date().toString()), []);
   const defaultValues: ExportDataFormValues = useMemo(
     () => ({
       dataExported: canExportEhrHealthData
         ? ExportDataExported.ResponsesAndEhrData
         : ExportDataExported.ResponsesOnly,
       dateType: ExportDateType.AllTime,
       fromDate: minDate,
-      toDate: getMaxDate(),
+      toDate: maxDate,
       supplementaryFiles: SupplementaryFiles.reduce(
         (acc, fileType) => ({ ...acc, [fileType]: false }),
         {} as Record<SupplementaryFiles, boolean>,
       ),
     }),
-    [minDate, canExportEhrHealthData],
+    [minDate, maxDate, canExportEhrHealthData],
   );
   const methods = useForm<ExportDataFormValues>({
     resolver: yupResolver(exportDataSettingSchema() as ObjectSchema<ExportDataFormValues>),
@@ -117,7 +117,7 @@ export const ExportDataSetting = ({
             onExportSettingsClose();
           }}
           minDate={minDate}
-          getMaxDate={getMaxDate}
+          maxDate={maxDate}
           appletName={appletName}
           supportedSupplementaryFiles={filteredSupportedSupplementaryFiles}
           canExportEhrHealthData={canExportEhrHealthData}

src/shared/features/AppletSettings/ExportDataSetting/Popups/ExportSettingsPopup/ExportSettingsPopup.test.tsx

@@ -61,7 +61,7 @@ const commonProps = {
   onClose: mockOnClose,
   onExport: mockOnExport,
   minDate: date,
-  getMaxDate: () => getNormalizedTimezoneDate(new Date().toString()),
+  maxDate: getNormalizedTimezoneDate(new Date().toString()),
   appletName: mockedApplet.displayName,
   'data-testid': DATA_TESTID_EXPORT_DATA_SETTINGS_POPUP,
 };

src/shared/features/AppletSettings/ExportDataSetting/Popups/ExportSettingsPopup/ExportSettingsPopup.tsx

@@ -32,7 +32,7 @@ export const ExportSettingsPopup = ({
   onClose,
   onExport,
   minDate,
-  getMaxDate,
+  maxDate,
   appletName,
   supportedSupplementaryFiles,
   canExportEhrHealthData,
@@ -48,7 +48,7 @@ export const ExportSettingsPopup = ({
   const hasCustomDate = dateType === ExportDateType.ChooseDates;
 
   const commonProps = {
-    maxDate: getMaxDate(),
+    maxDate,
     control,
     inputSx: {
       '& .MuiInputLabel-outlined': {

src/shared/features/AppletSettings/ExportDataSetting/Popups/ExportSettingsPopup/ExportSettingsPopup.types.ts

@@ -5,7 +5,7 @@ export type ExportSettingsPopupProps = {
   onClose: () => void;
   onExport: () => void;
   minDate: Date;
-  getMaxDate: () => Date;
+  maxDate: Date;
   appletName: string;
   supportedSupplementaryFiles?: SupplementaryFiles[];
   canExportEhrHealthData?: boolean;