fix: retaining local data on log out (M2-8113) #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiushihe
changed the title
farmerpaul
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit bdefb85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8113
This PR removes the
await cleanupData()from the "log out" hook.The call was previously erroneously added by me. I thought it was an oversight that entity record/progression data were not cleared upon log out. I didn't realize retaining those data was an intended behaviour. So this PR removes the call to restore the previously intentional behaviour of not clearing entity record/progression data on log out.
📸 Screenshots
N/A
🪤 Peer Testing
... at this point, the activity should resume from where it was left off before existing and logging out.
✏️ Notes
N/A