Skip to content

UI duration picker issue fixed #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UI duration picker issue fixed #2538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/widgets/TimeDuration/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import React from 'react';
import PropTypes from 'prop-types';
import { View, Picker, ScrollView, KeyboardAvoidingView, Text } from 'react-native';
import { View, Picker, Dimensions, KeyboardAvoidingView, Text } from 'react-native';
// import RNPickerSelect from 'react-native-picker-select';
import { OptionalText } from '../OptionalText';

const defaultTime = { hour: 0, minute: 0 };
const { width } = Dimensions.get('window');

export class TimeDuration extends React.Component {

Expand Down Expand Up @@ -50,7 +51,7 @@ export class TimeDuration extends React.Component {
}

return (
<Picker selectedValue={finalAnswer[type] || ''} onValueChange={(v) => onChangeValue(type, v)}>
<Picker selectedValue={finalAnswer[type] || ''} onValueChange={(v) => onChangeValue(type, v)} style={width < 800 ? { width: 102 } : {}}>
<Picker.Item label={this.capitalizeFirstLetter(type)} value={items.value} />
{items.map((item, index) => (
<Picker.Item label={item.label + ''} value={item.value} key={index} />
Expand All @@ -74,7 +75,7 @@ export class TimeDuration extends React.Component {

return (
<KeyboardAvoidingView>
<View style={{ alignItems: 'stretch', flexDirection: 'row', flex: 1 }}>
<View style={{ alignItems: 'stretch', flexDirection: 'row', flex: 1, marginLeft: width < 800 ? -10 : 0, marginRight: width < 800 ? -10 : 0 }}>
{valueTypes && Object.keys(valueTypes).map(type =>
<>
{valueTypes[type] !== "" &&
Expand Down