Adding error to datadog span (#2080)

Author: aweiland

src/infrastructure/dependency/structured_logs.py

@@ -187,9 +187,11 @@ async def dispatch(self, request: Request, call_next) -> Response:
 
         try:
             response = await call_next(request)
-        except Exception:
+        except Exception as exc:
             structlog.stdlib.get_logger("api.error").exception("Unhandled exception")
-
+            span = tracer.current_span()
+            if span:
+                span.set_exc_info(type(exc), exc, exc.__traceback__)
         finally:
             access_logger = structlog.stdlib.get_logger("api.access")
             process_time = time.perf_counter_ns() - start_time

src/infrastructure/http/exceptions.py

@@ -1,4 +1,5 @@
 from asyncpg import InvalidPasswordError
+from ddtrace import tracer
 from fastapi.encoders import jsonable_encoder
 from fastapi.exception_handlers import http_exception_handler
 from fastapi.exceptions import RequestValidationError
@@ -14,10 +15,17 @@
 from infrastructure.logger import logger
 
 
+def _set_trace_exception(exc: Exception) -> None:
+    span = tracer.current_span()
+    if span:
+        span.set_exc_info(type(exc), exc, exc.__traceback__)
+
+
 def custom_base_errors_handler(_: Request, error: BaseError) -> JSONResponse:
     """This function is called if the BaseError was raised."""
 
     logger.error(error.error, exc_info=error)
+    _set_trace_exception(error)
 
     response = ErrorResponseMulti(
         result=[
@@ -77,6 +85,7 @@ def python_base_error_handler(_: Request, error: Exception) -> JSONResponse:
     response = ErrorResponseMulti(result=[ErrorResponse(message=f"Unhandled error: {error_message}")])
 
     logger.error(error_message, exc_info=error)
+    _set_trace_exception(error)
 
     return JSONResponse(
         content=jsonable_encoder(response.model_dump(by_alias=True)),
@@ -90,6 +99,9 @@ def pydantic_validation_errors_handler(request: Request, error: RequestValidatio
     this_logger = logger.bind(
         error_location={"file": error.endpoint_file, "line": error.endpoint_line, "function": error.endpoint_function}
     )
+
+    _set_trace_exception(error)
+
     for err in error.errors():
         if isinstance(err, dict):
             message = err["msg"]
@@ -118,6 +130,8 @@ def sqlalchemy_database_error_handler(
 ) -> JSONResponse:
     """This function is called if the SQLAlchemy database error was raised."""
     logger.error(str(error), exc_info=error)
+    _set_trace_exception(error)
+
     response = ErrorResponseMulti(result=[ErrorResponse(message="Internal server error")])
 
     return JSONResponse(