fix: add user_target_email to shell account audit event

Author: adeiji

src/apps/invitations/router.py

@@ -27,7 +27,11 @@
     PrivateInvitationResponse,
     ShellAccountCreateRequest,
 )
-from apps.shared.domain.response import DEFAULT_OPENAPI_RESPONSE, Response, ResponseMulti
+from apps.shared.domain.response import (
+    DEFAULT_OPENAPI_RESPONSE,
+    Response,
+    ResponseMulti,
+)
 from apps.shared.exception import BaseError
 from apps.subjects.api import create_subject
 from apps.subjects.domain import SubjectCreateRequest, SubjectCreateResponse
@@ -151,14 +155,17 @@ async def create_shell_account(
         result = await create_subject(
             user=user,
             session=session,
-            schema=SubjectCreateRequest(applet_id=applet_id, **subject_schema.model_dump(by_alias=False)),
+            schema=SubjectCreateRequest(
+                applet_id=applet_id, **subject_schema.model_dump(by_alias=False)
+            ),
         )
     except BaseError as e:
         await log(
             AuditEvent(
                 event_action=EventAction.APPLET_INVITE_INITIATE,
                 user_id=user.id,
                 curious_applet_id=[applet_id],
+                user_target_email=subject_schema.email,
                 user_target_roles=["shell-account"],
                 **http_audit_fields(request, e),
             )
@@ -170,6 +177,7 @@ async def create_shell_account(
             event_action=EventAction.APPLET_INVITE_INITIATE,
             user_id=user.id,
             curious_applet_id=[applet_id],
+            user_target_email=subject_schema.email,
             user_target_roles=["shell-account"],
             **http_audit_fields(request),
         )

src/apps/invitations/test_invite.py

@@ -155,6 +155,7 @@ def shell_create_data():
         secretUserId="secretUserId",
         nickname="nickname",
         tag="tag",
+        email="shell@example.com",
     )
 
 
@@ -1660,4 +1661,5 @@ async def test_shell_create_account_audit_event(
         assert event.event_outcome == EventOutcome.SUCCESS
         assert event.user_id == bob.id
         assert event.curious_applet_id == [applet_four.id]
+        assert event.user_target_email == "shell@example.com"
         assert event.user_target_roles == ["shell-account"]