From 9b4d815febaf6f89c64229409e400187b3bcc833 Mon Sep 17 00:00:00 2001 From: Andrew Weiland Date: Fri, 30 Aug 2024 09:11:23 -0400 Subject: [PATCH] fixed notifications when a step is skipped --- .github/workflows/pr-open.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-open.yml b/.github/workflows/pr-open.yml index edcee4759de8..22417b1ff766 100644 --- a/.github/workflows/pr-open.yml +++ b/.github/workflows/pr-open.yml @@ -135,7 +135,7 @@ jobs: comment-e2e-tests: name: Comment on test outcome - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.run-e2e-tests.result != 'skipped' }} runs-on: ubuntu-latest permissions: issues: write @@ -143,7 +143,7 @@ jobs: needs: [run-e2e-tests] steps: - name: "Send Slack message on failure" - if: ${{ needs.run-e2e-tests.result != 'success' }} + if: ${{ needs.run-e2e-tests.result != 'success' }} uses: rtCamp/action-slack-notify@v2 env: SLACK_COLOR: failure