Skip to content

Commit 6e56737

Browse files
love4soulchili-ios
authored andcommitted
Bugfixes/0.1.1 (#19)
* This fixes #16, fixes #18
1 parent 4a7832e commit 6e56737

11 files changed

+19
-7
lines changed

CHIPageControl.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'CHIPageControl'
3-
s.version = '0.1'
3+
s.version = '0.1.1'
44
s.summary = 'CHIPageControl is a set of cool animated page controls written in Swift to replace boring UIPageControl.'
55

66
s.ios.deployment_target = '8.0'

CHIPageControl/CHIPageControlAji.swift

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ open class CHIPageControlAji: CHIBasePageControl {
4343
}
4444

4545
override func updateNumberOfPages(_ count: Int) {
46+
inactive.forEach { $0.removeFromSuperlayer() }
4647
inactive = [CHILayer]()
4748
inactive = (0..<count).map {_ in
4849
let layer = CHILayer()

CHIPageControl/CHIPageControlAleppo.swift

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ open class CHIPageControlAleppo: CHIBasePageControl {
4444
}
4545

4646
override func updateNumberOfPages(_ count: Int) {
47+
inactive.forEach { $0.removeFromSuperlayer() }
4748
inactive = [CHILayer]()
4849
inactive = (0..<count).map {_ in
4950
let layer = CHILayer()

CHIPageControl/CHIPageControlChimayo.swift

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ open class CHIPageControlChimayo: CHIBasePageControl {
4848
}
4949

5050
override func updateNumberOfPages(_ count: Int) {
51+
inactive.forEach { $0.removeFromSuperlayer() }
5152
inactive = [CHILayer]()
5253
inactive = (0..<count).map {_ in
5354
let layer = CHILayer()

CHIPageControl/CHIPageControlFresno.swift

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ open class CHIPageControlFresno: CHIBasePageControl {
4646
}
4747

4848
override func updateNumberOfPages(_ count: Int) {
49+
elements.forEach { $0.removeFromSuperlayer() }
4950
elements = [CHILayer]()
5051
elements = (0..<count).map {_ in
5152
let layer = CHILayer()

CHIPageControl/CHIPageControlJalapeno.swift

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ open class CHIPageControlJalapeno: CHIBasePageControl {
4646
}
4747

4848
override func updateNumberOfPages(_ count: Int) {
49+
inactive.forEach { $0.removeFromSuperlayer() }
4950
inactive = [CHILayer]()
5051
inactive = (0..<count).map {_ in
5152
let layer = CHILayer()

CHIPageControl/CHIPageControlJaloro.swift

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ open class CHIPageControlJaloro: CHIBasePageControl {
5151
}
5252

5353
override func updateNumberOfPages(_ count: Int) {
54+
inactive.forEach { $0.removeFromSuperlayer() }
5455
inactive = [CHILayer]()
5556
inactive = (0..<count).map {_ in
5657
let layer = CHILayer()

CHIPageControl/CHIPageControlPaprika.swift

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ open class CHIPageControlPaprika: CHIBasePageControl {
4747
}
4848

4949
override func updateNumberOfPages(_ count: Int) {
50+
elements.forEach { $0.removeFromSuperlayer() }
5051
elements.forEach() { $0.removeFromSuperlayer() }
5152
elements = [CHILayer]()
5253
elements = (0..<count).map {_ in

CHIPageControl/CHIPageControlPuya.swift

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ open class CHIPageControlPuya: CHIBasePageControl {
4646
}
4747

4848
override func updateNumberOfPages(_ count: Int) {
49+
elements.forEach { $0.removeFromSuperlayer() }
4950
elements = [CHILayer]()
5051
elements = (0..<count).map {_ in
5152
let layer = CHILayer()

CHIPageControl/Core/CHIBasePageControl.swift

+7-3
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,17 @@ import UIKit
9696

9797
required public init?(coder aDecoder: NSCoder) {
9898
super.init(coder: aDecoder)
99-
100-
self.displayLink = CADisplayLink(target: self, selector: #selector(updateFrame))
101-
self.displayLink?.add(to: .current, forMode: .defaultRunLoopMode)
99+
setupDisplayLink()
102100
}
103101

104102
public override init(frame: CGRect) {
105103
super.init(frame: frame)
104+
setupDisplayLink()
105+
}
106+
107+
internal func setupDisplayLink() {
108+
self.displayLink = CADisplayLink(target: self, selector: #selector(updateFrame))
109+
self.displayLink?.add(to: .current, forMode: .defaultRunLoopMode)
106110
}
107111

108112
internal func updateFrame() {

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Just add the `CHIPageControl` folder to your project.
2525

2626
use [CocoaPods](https://cocoapods.org) with Podfile:
2727
``` ruby
28-
pod 'CHIPageControl', '~> 0.1'
28+
pod 'CHIPageControl', '~> 0.1.1'
2929

3030
# individual page control
3131
pod 'CHIPageControl/Aji'
@@ -41,7 +41,7 @@ pod 'CHIPageControl/Puya'
4141

4242
use [Carthage](https://github.com/Carthage/Carthage) with Cartfile
4343
```ogdl
44-
github "ChiliLabs/CHIPageControl" ~> 0.1
44+
github "ChiliLabs/CHIPageControl" ~> 0.1.1
4545
```
4646

4747

@@ -51,7 +51,7 @@ Just drop UIView and set its class to be one of CHIPageControls.
5151
<img src="Images/ibdesignable.gif" width="800" height="564">
5252
### 💻 Code
5353
``` swift
54-
let pageControl = CHIPageControlAji(frame: CGRect(x: 0, y:0, with: 100, height: 20))
54+
let pageControl = CHIPageControlAji(frame: CGRect(x: 0, y:0, width: 100, height: 20))
5555
pageControl.numberOfPages = 4
5656
pageControl.radius = 4
5757
pageControl.tintColor = .red

0 commit comments

Comments
 (0)