Switch to using LSP #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json
ChrisChinchilla
force-pushed
the
chrischinch/ls
branch
from
defc4a6 to
8d0ea4b
Compare
|
Any progress information, you could share @ChrisChinchilla Thanks |
Owner
Author
|
@ccoVeille it's been available in the vscode marketplace as a prerelease for some time. Pushed a new version today and testing is very welcome |
Owner
Author
|
@ccoVeille contributions always welcome! |
Signed-off-by: Chris Chinchilla <[email protected]>
1 task
ChrisChinchilla
force-pushed
the
chrischinch/ls
branch
from
5b6538f to
9dcd585
Compare
dosubot
bot
added
the
size:XXL
# Conflicts: # README.md # package-lock.json # package.json
ChrisChinchilla
force-pushed
the
chrischinch/ls
branch
from
ea6f130 to
ec56042
Compare
|
Thanks a lot for your work on this! |
ChrisChinchilla
pushed a commit
that referenced
this pull request
Nov 15, 2025
This fixes the regression of the issue originally resolved in PR #18, where multiple Vale processes would spawn and consume excessive CPU. The LSP-based rewrite (PR #41) removed the old safeguards. This commit adds proper client lifecycle management: - Check for existing client in activate() and stop it before creating new one - Improve deactivate() with async/await and error handling - Add logging for better debugging of client lifecycle This ensures only one vale-ls process runs at a time, preventing the CPU spike issues users were experiencing. Fixes: Issue with multiple Vale processes spawning Related: PR #18 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely draft…