fix: improve error handling for console messages

Author: OrKoN

src/McpResponse.ts

@@ -337,7 +337,7 @@ export class McpResponse implements Response {
                 const devTools = context.getDevToolsUniverse();
                 return await ConsoleFormatter.from(consoleMessage, {
                   id: consoleMessageStableId,
-                  fetchDetailedData: true,
+                  fetchDetailedData: false,
                   devTools: devTools ?? undefined,
                 });
               }

src/formatters/ConsoleFormatter.ts

@@ -50,14 +50,24 @@ export class ConsoleFormatter {
     }
 
     this.#resolvedArgs = await Promise.all(
-      this.#msg.args().map(arg => arg.jsonValue()),
+      this.#msg.args().map(async (arg, i) => {
+        try {
+          return await arg.jsonValue();
+        } catch {
+          return `<error: Argument ${i} is no longer available>`;
+        }
+      }),
     );
 
     if (devTools) {
-      this.#resolvedStackTrace = await createStackTraceForConsoleMessage(
-        devTools,
-        this.#msg,
-      );
+      try {
+        this.#resolvedStackTrace = await createStackTraceForConsoleMessage(
+          devTools,
+          this.#msg,
+        );
+      } catch (err) {
+        // ignore
+      }
     }
   }
 

tests/formatters/ConsoleFormatter.test.js.snapshot

@@ -44,3 +44,10 @@ Message: log> Processing file:
 ### Arguments
 Arg #0: file.txt
 `;
+
+exports[`ConsoleFormatter > toStringDetailed > handles \"Execution context is not available\" error in args 1`] = `
+ID: 6
+Message: log> Processing file:
+### Arguments
+Arg #0: <error: Argument 0 is no longer available>
+`;

tests/formatters/ConsoleFormatter.test.ts

@@ -163,6 +163,27 @@ describe('ConsoleFormatter', () => {
       ).toStringDetailed();
       t.assert.snapshot?.(result);
     });
+
+    it('handles "Execution context is not available" error in args', async t => {
+      const message = createMockMessage({
+        type: () => 'log',
+        text: () => 'Processing file:',
+        args: () => [
+          {
+            jsonValue: async () => {
+              throw new Error('Execution context is not available');
+            },
+          },
+        ],
+      });
+      const formatter = await ConsoleFormatter.from(message, {
+        id: 6,
+        fetchDetailedData: true,
+      });
+      const result = formatter.toStringDetailed();
+      t.assert.snapshot?.(result);
+      assert.ok(result.includes('<error: Argument 0 is no longer available>'));
+    });
   });
   describe('toJSON', () => {
     it('formats a console.log message', async () => {