Disable storage inspection for service workers.

This is causing crashes in M143 and on. Unfortunately the original CL no
longer reverts cleanly, so this is the minimal delta to disable its
effects, which can also be back-merged appropriately.

Bug: 406991275
Change-Id: If6451729e483de6d06d370c1f966fb981500cd3a
Fixed: 466134219
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7319382
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>

Author: bmeurer

front_end/core/sdk/ChildTargetManager.test.ts

@@ -260,38 +260,43 @@ describeWithMockConnection('ChildTargetManager', () => {
   });
 
   describe('Storage initialization', () => {
-    it('should initialize storage for a top-level worker with STORAGE capability', async () => {
-      const parentTarget = createTarget({type: SDK.Target.Type.BROWSER});
-
-      const getStorageKeyStub = sinon.stub().resolves({
-        storageKey: 'https://example.com/' as Protocol.Storage.SerializedStorageKey,
-        getError: () => undefined,
-      });
-
-      sinon.stub(SDK.Target.Target.prototype, 'storageAgent').returns({
-        invoke_getStorageKey: getStorageKeyStub,
-      } as sinon.SinonStubbedInstance<ProtocolProxyApi.StorageApi>);
-
-      const setMainStorageKeySpy = sinon.spy(SDK.StorageKeyManager.StorageKeyManager.prototype, 'setMainStorageKey');
-      const updateStorageKeysSpy = sinon.spy(SDK.StorageKeyManager.StorageKeyManager.prototype, 'updateStorageKeys');
-      const setMainSecurityOriginSpy =
-          sinon.spy(SDK.SecurityOriginManager.SecurityOriginManager.prototype, 'setMainSecurityOrigin');
-      const updateSecurityOriginsSpy =
-          sinon.spy(SDK.SecurityOriginManager.SecurityOriginManager.prototype, 'updateSecurityOrigins');
-
-      const childTargetManager = new SDK.ChildTargetManager.ChildTargetManager(parentTarget);
-      await childTargetManager.attachedToTarget({
-        sessionId: createSessionId(),
-        targetInfo: createTargetInfo(undefined, 'service_worker'),
-        waitingForDebugger: false,
-      });
-
-      assert.isTrue(getStorageKeyStub.calledOnceWith({}));
-      assert.isTrue(setMainStorageKeySpy.calledOnceWith('https://example.com/'));
-      assert.isTrue(updateStorageKeysSpy.calledOnceWith(new Set(['https://example.com/'])));
-      assert.isTrue(setMainSecurityOriginSpy.calledOnceWith('https://example.com', ''));
-      assert.isTrue(updateSecurityOriginsSpy.calledOnceWith(new Set(['https://example.com'])));
-    });
+    // Temporarily disabled until the root cause for the crashers in https://crbug.com/466134219 is
+    // found and resolved.
+    it.skip(
+        '[crbug.com/406991275] should initialize storage for a top-level worker with STORAGE capability', async () => {
+          const parentTarget = createTarget({type: SDK.Target.Type.BROWSER});
+
+          const getStorageKeyStub = sinon.stub().resolves({
+            storageKey: 'https://example.com/' as Protocol.Storage.SerializedStorageKey,
+            getError: () => undefined,
+          });
+
+          sinon.stub(SDK.Target.Target.prototype, 'storageAgent').returns({
+            invoke_getStorageKey: getStorageKeyStub,
+          } as sinon.SinonStubbedInstance<ProtocolProxyApi.StorageApi>);
+
+          const setMainStorageKeySpy =
+              sinon.spy(SDK.StorageKeyManager.StorageKeyManager.prototype, 'setMainStorageKey');
+          const updateStorageKeysSpy =
+              sinon.spy(SDK.StorageKeyManager.StorageKeyManager.prototype, 'updateStorageKeys');
+          const setMainSecurityOriginSpy =
+              sinon.spy(SDK.SecurityOriginManager.SecurityOriginManager.prototype, 'setMainSecurityOrigin');
+          const updateSecurityOriginsSpy =
+              sinon.spy(SDK.SecurityOriginManager.SecurityOriginManager.prototype, 'updateSecurityOrigins');
+
+          const childTargetManager = new SDK.ChildTargetManager.ChildTargetManager(parentTarget);
+          await childTargetManager.attachedToTarget({
+            sessionId: createSessionId(),
+            targetInfo: createTargetInfo(undefined, 'service_worker'),
+            waitingForDebugger: false,
+          });
+
+          assert.isTrue(getStorageKeyStub.calledOnceWith({}));
+          assert.isTrue(setMainStorageKeySpy.calledOnceWith('https://example.com/'));
+          assert.isTrue(updateStorageKeysSpy.calledOnceWith(new Set(['https://example.com/'])));
+          assert.isTrue(setMainSecurityOriginSpy.calledOnceWith('https://example.com', ''));
+          assert.isTrue(updateSecurityOriginsSpy.calledOnceWith(new Set(['https://example.com'])));
+        });
 
     it('should NOT initialize storage for a frame target', async () => {
       const parentTarget = createTarget();

front_end/core/sdk/Target.test.ts

@@ -40,7 +40,9 @@ describe('Target', () => {
     assert.isFalse(subframeTarget.hasAllCapabilities(SDK.Target.Capability.DEVICE_EMULATION));
   });
 
-  it('should grant STORAGE capability to top-level workers', () => {
+  // Temporarily disabled until the root cause for the crashers in https://crbug.com/466134219 is
+  // found and resolved.
+  it.skip('[crbug.com/406991275] should grant STORAGE capability to top-level workers', () => {
     const serviceWorker = createTarget({type: SDK.Target.Type.ServiceWorker, parentTarget: browserTarget});
     const sharedWorker = createTarget({type: SDK.Target.Type.SHARED_WORKER, parentTarget: browserTarget});
     const dedicatedWorker = createTarget({type: SDK.Target.Type.Worker, parentTarget: browserTarget});

front_end/core/sdk/Target.ts

@@ -66,7 +66,9 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.NETWORK | Capability.TARGET |
             Capability.INSPECTOR | Capability.IO | Capability.EVENT_BREAKPOINTS;
         if (parentTarget?.type() !== Type.FRAME) {
-          this.#capabilitiesMask |= Capability.BROWSER | Capability.STORAGE;
+          // TODO(crbug.com/406991275): This should also grant the `STORAGE` capability, but first the
+          // crashers in https://crbug.com/466134219 have to be resolved.
+          this.#capabilitiesMask |= Capability.BROWSER;
         }
         break;
       case Type.SHARED_WORKER: