Explicitly set required to parameters

Bug: 467254906
Change-Id: Ib436f0ab62d454ac214e335535cfecd4c9c6ab57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7483011
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>

Author: OrKoN

front_end/core/host/AidaClient.ts

@@ -79,6 +79,7 @@ export interface FunctionObjectParam<T extends string|number|symbol = string> ex
   type: ParametersTypes.OBJECT;
   // TODO: this can be also be ObjectParams
   properties: Record<T, FunctionPrimitiveParams|FunctionArrayParam>;
+  required: string[];
 }
 
 /**

front_end/models/ai_assistance/agents/AiAgent.test.ts

@@ -430,7 +430,12 @@ describeWithEnvironment('AiAgent', () => {
         super(opts);
         this.declareFunction('testFn', {
           description: 'test fn description',
-          parameters: {type: Host.AidaClient.ParametersTypes.OBJECT, properties: {}, description: 'arg description'},
+          parameters: {
+            type: Host.AidaClient.ParametersTypes.OBJECT,
+            properties: {},
+            description: 'arg description',
+            required: []
+          },
           handler: this.#test.bind(this),
         });
       }
@@ -469,6 +474,7 @@ describeWithEnvironment('AiAgent', () => {
               description: 'arg description',
               properties: {},
               type: 6,
+              required: [],
             },
           }],
       );

front_end/models/ai_assistance/agents/PatchAgent.ts

@@ -97,6 +97,7 @@ export class PatchAgent extends AiAgent<Workspace.Workspace.Project> {
         description: '',
         nullable: true,
         properties: {},
+        required: [],
       },
       handler: async () => {
         const files = this.#project.getFiles();
@@ -143,9 +144,10 @@ export class PatchAgent extends AiAgent<Workspace.Workspace.Project> {
           isRegex: {
             type: Host.AidaClient.ParametersTypes.BOOLEAN,
             description: 'Whether the query is a regular expression or not',
-            nullable: true,
+            nullable: false,
           }
         },
+        required: ['query']
       },
       handler: async (args, options) => {
         return {
@@ -182,6 +184,7 @@ export class PatchAgent extends AiAgent<Workspace.Workspace.Project> {
             }
           }
         },
+        required: ['files']
       },
       handler: async (args, options) => {
         debugLog('updateFiles', args.files);

front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -782,6 +782,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           }
         },
+        required: ['insightSetId', 'insightName']
       },
       displayInfoFromArgs: params => {
         return {
@@ -829,6 +830,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           }
         },
+        required: ['eventKey']
       },
       displayInfoFromArgs: params => {
         return {title: lockedString('Looking at trace event…'), action: `getEventByKey('${params.eventKey}')`};
@@ -886,6 +888,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           },
         },
+        required: ['min', 'max']
       },
       displayInfoFromArgs: args => {
         return {
@@ -943,6 +946,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           },
         },
+        required: ['min', 'max']
       },
       displayInfoFromArgs: args => {
         return {
@@ -993,6 +997,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           },
         },
+        required: ['eventKey']
       },
       displayInfoFromArgs: args => {
         return {title: lockedString('Looking at call tree…'), action: `getDetailedCallTree('${args.eventKey}')`};
@@ -1046,7 +1051,9 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
               description: 'The message the annotation should show to the user.',
               nullable: false,
             },
+
           },
+          required: ['elementId', 'annotationMessage']
         },
         handler: async params => {
           return await this.addElementAnnotation(params.elementId, params.annotationMessage);
@@ -1077,6 +1084,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
               nullable: false,
             },
           },
+          required: ['eventKey', 'annotationMessage']
         },
         handler: async params => {
           return await this.addNetworkRequestAnnotation(params.eventKey, params.annotationMessage);
@@ -1108,6 +1116,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           },
         },
+        required: ['scriptUrl', 'line', 'column']
       },
       displayInfoFromArgs: args => {
         return {
@@ -1166,6 +1175,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
             nullable: false,
           },
         },
+        required: ['url']
       },
       displayInfoFromArgs: args => {
         return {title: lockedString('Looking at resource content…'), action: `getResourceContent('${args.url}')`};
@@ -1220,6 +1230,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
               nullable: false,
             }
           },
+          required: ['eventKey']
         },
         displayInfoFromArgs: params => {
           return {title: lockedString('Selecting event…'), action: `selectEventByKey('${params.eventKey}')`};
@@ -1281,6 +1292,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
               nullable: true,
             },
           },
+          required: ['type']
         },
         handler: async params => {
           switch (params.type) {

front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt

@@ -86,7 +86,12 @@ Content:
               "description": "A CSS style property name to retrieve. For example, 'background-color'."
             }
           }
-        }
+        },
+        "required": [
+          "explanation",
+          "elements",
+          "styleProperties"
+        ]
       }
     },
     {
@@ -109,7 +114,12 @@ Content:
             "type": 1,
             "description": "Provide a summary of what the code does. For example, \"Checking related element styles\"."
           }
-        }
+        },
+        "required": [
+          "code",
+          "thought",
+          "title"
+        ]
       }
     }
   ],

front_end/models/ai_assistance/agents/StylingAgent.ts

@@ -313,7 +313,8 @@ export class StylingAgent extends AiAgent<SDK.DOMModel.DOMNode> {
               description: 'A CSS style property name to retrieve. For example, \'background-color\'.'
             }
           },
-        }
+        },
+        required: ['explanation', 'elements', 'styleProperties']
       },
       displayInfoFromArgs: params => {
         return {
@@ -396,6 +397,7 @@ const data = {
             description: 'Provide a summary of what the code does. For example, "Checking related element styles".',
           },
         },
+        required: ['code', 'thought', 'title']
       },
       displayInfoFromArgs: params => {
         return {
@@ -436,6 +438,7 @@ const data = {
               nullable: false,
             },
           },
+          required: ['elementId', 'annotationMessage']
         },
         handler: async params => {
           return await this.addElementAnnotation(params.elementId, params.annotationMessage);