Merge pull request #63 from CircleCI-Public/DEVEX-623-replace-message-must-validate-one-and-only-one-schema-one-of-with-a-more-meaningful-one

feat: Replace messages "Must validate one and only one schema (oneOf)…

Author: rlegan

pkg/parser/jsonschema.go

@@ -155,12 +155,14 @@ func (validator *JSONSchemaValidator) ValidateWithJSONSchema(rootNode *sitter.No
 		return []protocol.Diagnostic{utils.CreateErrorDiagnosticFromNode(rootNode, err.Error())}
 	}
 
+	jsonSchemaDiags := []protocol.Diagnostic{}
+
 	if !result.Valid() {
 		for _, resErr := range result.Errors() {
 			fields := strings.Split(resErr.Field(), ".")
 			if len(fields) == 1 && fields[0] == "(root)" {
 				diagnostic := utils.CreateErrorDiagnosticFromNode(rootNode, resErr.Description())
-				diagnostics = append(diagnostics, diagnostic)
+				jsonSchemaDiags = append(jsonSchemaDiags, diagnostic)
 			} else {
 				node, err := FindDeepestNode(rootNode, content, fields)
 				if err != nil {
@@ -172,11 +174,14 @@ func (validator *JSONSchemaValidator) ValidateWithJSONSchema(rootNode *sitter.No
 				}
 
 				diagnostic := utils.CreateErrorDiagnosticFromNode(node, resErr.Description())
-				diagnostics = append(diagnostics, diagnostic)
+				jsonSchemaDiags = append(jsonSchemaDiags, diagnostic)
 			}
 		}
 	}
 
+	jsonSchemaDiags = removeUselessMustValidateError(jsonSchemaDiags)
+	diagnostics = append(diagnostics, jsonSchemaDiags...)
+
 	return diagnostics
 }
 
@@ -209,3 +214,33 @@ func (validator *JSONSchemaValidator) doesNodeUseParameter(node *sitter.Node) bo
 
 	return false
 }
+func removeUselessMustValidateError(diags []protocol.Diagnostic) []protocol.Diagnostic {
+	resDiags := []protocol.Diagnostic{}
+	for i, diag := range diags {
+		if diag.Message == "Must validate one and only one schema (oneOf)" {
+			if hasAnotherDiagInsideRange(diags, diag.Range) {
+				continue
+			}
+			resDiags = append(resDiags, utils.CreateDiagnosticFromRange(
+				diag.Range,
+				diag.Severity,
+				"Invalid structure",
+				[]protocol.CodeAction{},
+			))
+		} else {
+			resDiags = append(resDiags, diags[i])
+		}
+	}
+
+	return resDiags
+}
+
+func hasAnotherDiagInsideRange(diags []protocol.Diagnostic, rangeToCheck protocol.Range) bool {
+	for _, diag := range diags {
+		if utils.PosInRange(rangeToCheck, diag.Range.Start) {
+			return true
+		}
+	}
+
+	return false
+}