Fix: Make sidebar bullet markers clickable - #789
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR adds a hierarchical Jekyll include that renders first/second/third-level sidebar navigation, inserts a head script include for a new Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
assets/js/nav-bullets-clickable.js (1)
10-10: 💤 Low valueConsider moving cursor styling to CSS.
The
cursor: pointerstyle is currently set via inline JavaScript. This could be defined in the stylesheet instead for better separation of concerns and maintainability.♻️ Optional: move cursor style to CSS
In
_sass/custom/custom.scss, add:.nav-list-item { cursor: pointer; }Then remove line 10 from this script:
}); - item.style.cursor = "pointer"; });
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 069d66ca-1908-4d85-8b0e-925a3faf0ddc
📒 Files selected for processing (4)
_includes/components/nav.html_includes/head_custom.html_sass/custom/custom.scssassets/js/nav-bullets-clickable.js
✅ Files skipped from review due to trivial changes (1)
- _sass/custom/custom.scss
297e989 to
9998107
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
_includes/head_custom.html (1)
7-7: ⚡ Quick winAdd
deferattribute for non-blocking script loading.The new script doesn't have a
deferattribute, unlike the Font Awesome scripts on lines 1-2. This blocks HTML parsing and delays page rendering.⚡ Proposed fix to add defer
-<script src="/assets/js/nav-bullets-clickable.js"></script> +<script defer src="/assets/js/nav-bullets-clickable.js"></script>_sass/custom/custom.scss (2)
206-208: ⚡ Quick winRemove duplicate
list-style: nonedeclaration.Both selectors compile to the same CSS rule (
.nav-list .nav-list-item.active { list-style: none; }). The declaration on lines 216-218 is redundant.♻️ Proposed fix to remove duplication
.nav-list-item.active { - list-style: none; }Also applies to: 216-218
320-320: ⚡ Quick winAdd empty line before comment.
Stylelint rule
scss/double-slash-comment-empty-line-beforerequires an empty line before comments for consistency.📝 Proposed fix
} + // Fix: make sidebar bullet markers clickable (Issue `#667`) .nav-list-item {
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a2cdfae5-b45a-4451-9c6f-e1d20bfb9918
📒 Files selected for processing (4)
_includes/components/nav.html_includes/head_custom.html_sass/custom/custom.scssassets/js/nav-bullets-clickable.js
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/js/nav-bullets-clickable.js
cursor: pointer is already handled via .nav-list-item { cursor: pointer } in _sass/custom/custom.scss. No JS cursor styling is present in nav-bullets-clickable.js. |
|
@Nihal4777 LGTM |
9dbe982 to
fe4ea53
Compare
| top: 0; | ||
| z-index: 500; | ||
|
|
||
| // Fix: make sidebar bullet markers clickable (Issue #667) |
fe4ea53 to
0c86174
Compare
0c86174 to
e386a42
Compare

Fixes #667
Changes done:
components/nav.htmlfrom thejust-the-docsgem into_includes/components/nav.htmlto override the theme's default nav template.<span class="nav-bullet">inside eachnav-list-linkanchor tag at all three levels (first, second, third) so the bullet is part of the clickable<a>element._sass/custom/custom.scssto remove the CSSlist-styleSVG bullets (replaced withlist-style: none) and styled the new inline.nav-bulletspans instead.Screenshots
Before: Bullet markers were decorative CSS
list-styleelements — not part of the link, not clickable.Screen.Recording.2026-05-30.192123.mp4
After: Bullet markers are inside the
<a>tag and fully clickable, navigating to the respective page.Screen.Recording.2026-05-30.192158.mp4
✅️ By submitting this PR, I have verified the following
Summary by CodeRabbit
New Features
Style
Chores