Remove unnecessary null pointer checks

[elfring]

An extra null pointer check is not needed in functions like the following.

• clamav/clamav-milter/connpool.c

  Lines 55 to 56 in a937323

  	else if ((k).server) \
  	free((k).server); \

• clamav/libclamunrar/array.hpp

  Lines 68 to 72 in a937323

  	template <class T> Array<T>::~Array()
  	{
  	if (Buffer!=NULL)
  	free(Buffer);
  	}

• clamav/libclamunrar/unpack50frag.cpp

  Lines 17 to 21 in a937323

  	if (Mem[I]!=NULL)
  	{
  	free(Mem[I]);
  	Mem[I]=NULL;
  	}

• clamav/libfreshclam/libfreshclam.c

  Lines 318 to 353 in a937323

  	if (NULL != logg_file) {
  	free((void *)logg_file);
  	logg_file = NULL;
  	}
  	if (NULL != g_localIP) {
  	free(g_localIP);
  	g_localIP = NULL;
  	}
  	if (NULL != g_userAgent) {
  	free(g_userAgent);
  	g_userAgent = NULL;
  	}
  	if (NULL != g_proxyServer) {
  	free(g_proxyServer);
  	g_proxyServer = NULL;
  	}
  	if (NULL != g_proxyUsername) {
  	free(g_proxyUsername);
  	g_proxyUsername = NULL;
  	}
  	if (NULL != g_proxyPassword) {
  	free(g_proxyPassword);
  	g_proxyPassword = NULL;
  	}
  	if (NULL != g_databaseDirectory) {
  	free(g_databaseDirectory);
  	g_databaseDirectory = NULL;
  	}
  	if (NULL != g_tempDirectory) {
  	free(g_tempDirectory);
  	g_tempDirectory = NULL;
  	}
  	if (NULL != g_freshclamDat) {
  	free(g_freshclamDat);
  	g_freshclamDat = NULL;
  	}

[elfring]

💭 I am curious if another software developer (besides me) can get into the mood to apply a corresponding update suggestion which could be generated by the software “Coccinelle” (also with the help of a variant from the following script).

@Remove_unnecessary_pointer_checks@
expression x;
@@
-if (\(x != 0 \| x != NULL\))
    free(x);

[val-ms]

libclamunrar is a vendored copy of the RARLabs UnRAR project: https://www.rarlab.com/rar_add.htm
We won't change their code except where absolutely necessary.

libfreshclam is our own code. We actually have a lot of unecessary NULL checks in other parts of clamav as well wrapping free() function calls. It is unecessary but also harmless.