random backend updates (#7061)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
title

## Changelog

:cl:
fix: world_topic status host is correct now
code: updated progressbar
code: updated stack trace
code: updated callback
code: updated weakref
code: updated topic request, now supports returning json format
code: datum browser doesnt hold atom owner directly
code: updated stat tracking (debugging, not player stat)
admin: updated del-all verbs
admin: allow f12 browser inspect (516 only)
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Author: LetterN

citadel.dme

@@ -33,6 +33,7 @@
 #include "code\__DEFINES\ability.dm"
 #include "code\__DEFINES\access.dm"
 #include "code\__DEFINES\actionspeed_modification.dm"
+#include "code\__DEFINES\admin_verb.dm"
 #include "code\__DEFINES\appearance.dm"
 #include "code\__DEFINES\assert.dm"
 #include "code\__DEFINES\automata.dm"
@@ -56,6 +57,7 @@
 #include "code\__DEFINES\holidays.dm"
 #include "code\__DEFINES\holomap.dm"
 #include "code\__DEFINES\holospheres.dm"
+#include "code\__DEFINES\html_assistant.dm"
 #include "code\__DEFINES\icon_smoothing.dm"
 #include "code\__DEFINES\ingredients.dm"
 #include "code\__DEFINES\instruments.dm"
@@ -93,6 +95,7 @@
 #include "code\__DEFINES\spaceman_dmm.dm"
 #include "code\__DEFINES\spans.dm"
 #include "code\__DEFINES\spells.dm"
+#include "code\__DEFINES\stack_trace.dm"
 #include "code\__DEFINES\stat_tracking.dm"
 #include "code\__DEFINES\statpanel.dm"
 #include "code\__DEFINES\supply.dm"
@@ -411,6 +414,7 @@
 #include "code\__HELPERS\shell.dm"
 #include "code\__HELPERS\spatial_info.dm"
 #include "code\__HELPERS\stack_trace.dm"
+#include "code\__HELPERS\stat_tracking.dm"
 #include "code\__HELPERS\stoplag.dm"
 #include "code\__HELPERS\storage.dm"
 #include "code\__HELPERS\text.dm"

code/__DEFINES/_core.dm

@@ -6,12 +6,6 @@
 /proc/___rethrow_exception(exception/E)
 	throw E
 
-/// Gives us the stack trace from CRASH() without ending the current proc.
-/// Unlike STACK_TRACE, this will:
-/// * call a new proc so the originating trace isn't from the original file anymore
-/// * put the stack trace in stack trace storage
-#define stack_trace(message) _stack_trace(message, __FILE__, __LINE__)
-
 /// get variable if not null or
 #define VALUE_OR_DEFAULT(VAL, DEFAULT) (isnull(VAL)? (DEFAULT) : (VAL))
 

code/__DEFINES/_lists.dm

@@ -25,13 +25,28 @@
 #define LAZYLEN(L) length(L)
 ///Sets a list to null
 #define LAZYNULL(L) L = null
-/// Null-safe L.Cut()
+///Adds to the item K the value V, if the list is null it will initialize it
+#define LAZYADDASSOC(L, K, V) if(!L) { L = list(); } L[K] += V;
+///This is used to add onto lazy assoc list when the value you're adding is a /list/. This one has extra safety over lazyaddassoc because the value could be null (and thus cant be used to += objects)
+#define LAZYADDASSOCLIST(L, K, V) if(!L) { L = list(); } L[K] += list(V);
+///Removes the value V from the item K, if the item K is empty will remove it from the list, if the list is empty will set the list to null
+#define LAZYREMOVEASSOC(L, K, V) if(L) { if(L[K]) { L[K] -= V; if(!length(L[K])) L -= K; } if(!length(L)) L = null; }
+///Accesses an associative list, returns null if nothing is found
+#define LAZYACCESSASSOC(L, I, K) L ? L[I] ? L[I][K] ? L[I][K] : null : null : null
+//These methods don't null the list
+///Use LAZYLISTDUPLICATE instead if you want it to null with no entries
+#define LAZYCOPY(L) (L ? L.Copy() : list() )
+/// Consider LAZYNULL instead
 #define LAZYCLEARLIST(L) if(L) L.Cut()
-/// Null-safe L.Copy()
-#define LAZYCOPY(L) (L? L.Copy() : null)
-/// Reads L or an empty list if L is not a list.  Note: Does NOT assign, L may be an expression.
+///Returns the list if it's actually a valid list, otherwise will initialize it
 #define SANITIZE_LIST(L) ( islist(L) ? L : list() )
 #define SANITIZE_TO_LIST(L) ( islist(L) ? L : list(L) )
+/// Performs an insertion on the given lazy list with the given key and value. If the value already exists, a new one will not be made.
+#define LAZYORASSOCLIST(lazy_list, key, value) \
+	LAZYINITLIST(lazy_list); \
+	LAZYINITLIST(lazy_list[key]); \
+	lazy_list[key] |= value;
+
 #define reverseList(L) reverseRange(L.Copy())
 
 #define SAFEPICK(L) (length(L)? pick(L) : null)

code/__DEFINES/admin_verb.dm

@@ -0,0 +1,24 @@
+// This port is currently half-assed, we do not include the entire avd stuff
+
+/// Use this to mark your verb as not having a description. Should ONLY be used if you are also hiding the verb!
+#define ADMIN_VERB_NO_DESCRIPTION ""
+/// Used to verbs you do not want to show up in the master verb panel.
+#define ADMIN_CATEGORY_HIDDEN null
+
+// Admin verb categories
+#define ADMIN_CATEGORY_MAIN "Admin"
+#define ADMIN_CATEGORY_EVENTS "Admin.Events"
+#define ADMIN_CATEGORY_FUN "Admin.Fun"
+#define ADMIN_CATEGORY_GAME "Admin.Game"
+#define ADMIN_CATEGORY_SHUTTLE "Admin.Shuttle"
+
+// Special categories that are separated
+#define ADMIN_CATEGORY_DEBUG "Debug"
+#define ADMIN_CATEGORY_SERVER "Server"
+#define ADMIN_CATEGORY_OBJECT "Object"
+#define ADMIN_CATEGORY_MAPPING "Mapping"
+#define ADMIN_CATEGORY_PROFILE "Profile"
+#define ADMIN_CATEGORY_IPINTEL "Admin.IPIntel"
+
+// Visibility flags
+#define ADMIN_VERB_VISIBLITY_FLAG_MAPPING_DEBUG "Map-Debug"

code/__DEFINES/html_assistant.dm

@@ -0,0 +1,5 @@
+#define HTML_SKELETON_INTERNAL(head, body) \
+"<!DOCTYPE html><html><head><meta http-equiv='Content-Type' content='text/html; charset=UTF-8'><meta http-equiv='X-UA-Compatible' content='IE=edge'>[head]</head><body>[body]</body></html>"
+
+#define HTML_SKELETON_TITLE(title, body) HTML_SKELETON_INTERNAL("<title>[title]</title>", body)
+#define HTML_SKELETON(body) HTML_SKELETON_INTERNAL("", body)

code/__DEFINES/stack_trace.dm

@@ -0,0 +1,4 @@
+/// gives us the stack trace from CRASH() without ending the current proc.
+#define stack_trace(message) _stack_trace(message, __FILE__, __LINE__)
+
+#define WORKAROUND_IDENTIFIER "%//%"

code/__DEFINES/stat_tracking.dm

@@ -1,17 +1,67 @@
-//
-// Defines used for advanced performance profiling of subsystems.
-// Currently used only by SSoverlays (2018-02-24 ~Leshana)
-// 
 #define STAT_ENTRY_TIME 1
 #define STAT_ENTRY_COUNT 2
 #define STAT_ENTRY_LENGTH 2
 
+
 #define STAT_START_STOPWATCH var/STAT_STOP_WATCH = TICK_USAGE
 #define STAT_STOP_STOPWATCH var/STAT_TIME = TICK_USAGE_TO_MS(STAT_STOP_WATCH)
 #define STAT_LOG_ENTRY(entrylist, entryname) \
 	var/list/STAT_ENTRY = entrylist[entryname] || (entrylist[entryname] = new /list(STAT_ENTRY_LENGTH));\
 	STAT_ENTRY[STAT_ENTRY_TIME] += STAT_TIME;\
-	var/STAT_INCR_AMOUNT = min(1, 2**round((STAT_ENTRY[STAT_ENTRY_COUNT] || 0)/SHORT_REAL_LIMIT));\
-	if (STAT_INCR_AMOUNT == 1 || prob(100/STAT_INCR_AMOUNT)) {\
-		STAT_ENTRY[STAT_ENTRY_COUNT] += STAT_INCR_AMOUNT;\
-	};\
+	STAT_ENTRY[STAT_ENTRY_COUNT] += 1;
+
+// Cost tracking macros, to be used in one proc. If you're using this raw you'll want to use global lists
+// If you don't you'll need another way of reading it
+#define INIT_COST(costs, counting) \
+	var/list/_costs = costs; \
+	var/list/_counting = counting; \
+	var/_usage = TICK_USAGE;
+
+// STATIC cost tracking macro. Uses static lists instead of the normal global ones
+// Good for debug stuff, and for running before globals init
+#define INIT_COST_STATIC(...) \
+	var/static/list/hidden_static_list_for_fun1 = list(); \
+	var/static/list/hidden_static_list_for_fun2 = list(); \
+	INIT_COST(hidden_static_list_for_fun1, hidden_static_list_for_fun2)
+
+// Cost tracking macro for global lists, prevents erroring if GLOB has not yet been initialized
+#define INIT_COST_GLOBAL(costs, counting) \
+	INIT_COST_STATIC() \
+	if(GLOB){\
+		costs = hidden_static_list_for_fun1; \
+		counting = hidden_static_list_for_fun2 ; \
+	} \
+	_usage = TICK_USAGE;
+
+
+#define SET_COST(category) \
+	do { \
+		var/_cost = TICK_USAGE; \
+		_costs[category] += TICK_DELTA_TO_MS(_cost - _usage);\
+		_counting[category] += 1; \
+	} while(FALSE); \
+	_usage = TICK_USAGE;
+
+#define SET_COST_LINE(...) SET_COST("[__LINE__]")
+
+/// A quick helper for running the code as a statement and profiling its cost.
+/// For example, `SET_COST_STMT(var/x = do_work())`
+#define SET_COST_STMT(code...) ##code; SET_COST("[__LINE__] - [#code]")
+
+#define EXPORT_STATS_TO_JSON_LATER(filename, costs, counts) EXPORT_STATS_TO_FILE_LATER(filename, costs, counts, stat_tracking_export_to_json_later)
+#define EXPORT_STATS_TO_CSV_LATER(filename, costs, counts) EXPORT_STATS_TO_FILE_LATER(filename, costs, counts, stat_tracking_export_to_csv_later)
+
+#define EXPORT_STATS_TO_FILE_LATER(filename, costs, counts, proc) \
+	do { \
+		var/static/last_export = 0; \
+		/* Need to always run if we haven't yet, since this code can be placed ANYWHERE */ \
+		if (world.time - last_export > 1.1 SECONDS || (last_export == 0)) { \
+			last_export = world.time; \
+			/* spawn() is used here because this is often used to track init times, where timers act oddly. */ \
+			/* I was making timers and even after init times were complete, the timers didn't run :shrug: */ \
+			spawn (1 SECONDS) { \
+				##proc(filename, costs, counts); \
+			} \
+		} \
+	} while (FALSE); \
+	_usage = TICK_USAGE;

code/__DEFINES/vv.dm

@@ -153,3 +153,5 @@
 
 // /obj/item/card/id
 #define VV_HK_ID_MOD "id_mod"
+
+#define VV_HK_WEAKREF_RESOLVE "weakref_resolve"

code/__HELPERS/do_after.dm

@@ -19,7 +19,7 @@
 	. = TRUE
 	while (world.time < endtime)
 		stoplag(1)
-		if (progress)
+		if (progress && !QDELETED(progbar))
 			progbar.update(world.time - starttime)
 		if(!user || !target)
 			. = FALSE
@@ -52,7 +52,7 @@
 			break
 
 	if(!QDELETED(progbar))
-		qdel(progbar)
+		progbar.end_progress()
 
 	STOP_INTERACTING_WITH(user, target, INTERACTING_FOR_DO_AFTER)
 
@@ -71,7 +71,7 @@
  * * progress_instance - override progressbar instance
  */
 /proc/do_after(mob/user, delay, atom/target, flags, mobility_flags = MOBILITY_CAN_USE, max_distance, datum/callback/additional_checks, atom/progress_anchor, datum/progressbar/progress_instance)
-	if(isnull(user))
+	if(isnull(user) || QDELETED(user))
 		return FALSE
 	if(!delay)
 		return \
@@ -111,7 +111,8 @@
 	while(world.time < (start_time + delay))
 		stoplag(1)
 
-		progress?.update((world.time - start_time) * delay_factor)
+		if (progress && !QDELETED(progress))
+			progress.update((world.time - start_time) * delay_factor)
 
 		// check if deleted
 		if(QDELETED(user))
@@ -172,7 +173,7 @@
 
 	//* end
 	if(!QDELETED(progress))
-		qdel(progress)
+		progress.end_progress()
 
 	if(!isnull(target))
 		STOP_INTERACTING_WITH(user, target, INTERACTING_FOR_DO_AFTER)

code/__HELPERS/game.dm

@@ -567,3 +567,23 @@
 
 	return hear
 
+///Get active players who are playing in the round
+/proc/get_active_player_count(alive_check = FALSE, afk_check = FALSE, human_check = FALSE)
+	var/active_players = 0
+	for(var/mob/player_mob as anything in GLOB.player_list)
+		if(!player_mob?.client)
+			continue
+		if(alive_check && player_mob.stat == DEAD)
+			continue
+		if(afk_check && player_mob.client.is_afk())
+			continue
+		if(human_check && !ishuman(player_mob))
+			continue
+		if(isnewplayer(player_mob)) // exclude people in the lobby
+			continue
+		if(isobserver(player_mob)) // Ghosts are fine if they were playing once (didn't start as observers)
+			// var/mob/dead/observer/ghost_player = player_mob
+			// if(ghost_player.started_as_observer) // Exclude people who started as observers
+			continue
+		active_players++
+	return active_players