Skip to content

Commit 1a6ea1f

Browse files
committed
fix: remove makemigrations from docker-entrypoint
Remove makemigrations-command, since it must never run automatically in a container because it generates files that belong in version control and can produce unexpected/conflicting migrations if run concurrently or against an unintended database state. Refs: ATV-269
1 parent 39439cb commit 1a6ea1f

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

atv/tests/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def autouse_django_db(db, django_db_setup, django_db_blocker):
3737
def django_db_modify_db_settings():
3838
pass
3939

40+
4041
@pytest.fixture(autouse=True)
4142
def set_resilient_logger_environment(settings):
4243
settings.RESILIENT_LOGGER["environment"] = "unittest"

docker-entrypoint.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ fi
1515
# Apply database migrations
1616
if [[ "$APPLY_MIGRATIONS" = "1" ]]; then
1717
echo "Applying database migrations..."
18-
./manage.py makemigrations
1918
./manage.py migrate --noinput
2019
fi
2120

0 commit comments

Comments
 (0)