test: fix flaky tests

- disable parler cache
- clear notifications registry in teardown
- move autouse settings to settings
- add missing settings fixture
- mark django_db explicitly

Refs: KEH-282

Author: danipran

tests/conftest.py

@@ -10,14 +10,9 @@
 
 
 @pytest.fixture(autouse=True)
-def autouse_django_db(db):
-    pass
-
-
-@pytest.fixture(autouse=True)
-def force_settings(settings):
-    settings.LANGUAGES = (("fi", "Finnish"), ("en", "English"))
-    settings.LANGUAGE_CODE = "en"
+def clear_notification_registry():
+    yield
+    notifications.registry = {}
 
 
 @pytest.fixture

tests/settings.py

@@ -42,3 +42,8 @@
 USE_TZ = True
 SECRET_KEY = "sekret"
 LANGUAGES = (("fi", "Finnish"), ("en", "English"), ("sv", "Swedish"))
+LANGUAGE_CODE = "en"
+
+# This one is very important, otherwise you get flaky tests because the cache
+# leaks between tests.
+PARLER_ENABLE_CACHING = False

tests/test_notification_queries.py

@@ -6,6 +6,7 @@
 from django_ilmoitin.utils import render_preview
 
 
+@pytest.mark.django_db
 def test_query_notification_templates(graphql_client, notification_template):
     query = """
     {

tests/test_notifications.py

@@ -1,5 +1,4 @@
 import pytest
-from django.conf import settings
 from django.core import mail
 from mailer.engine import send_all
 from mailer.models import Message
@@ -8,6 +7,7 @@
 from django_ilmoitin.utils import render_notification_template, send_notification
 
 
+@pytest.mark.django_db
 def test_notification_template_rendering(notification_template):
     context = {
         "extra_var": "foo",
@@ -31,6 +31,7 @@ def test_notification_template_rendering(notification_template):
     assert rendered.body_text == "testitekstiruumis, muuttujan arvo: text_baz!"
 
 
+@pytest.mark.django_db
 def test_notification_template_rendering_no_body_text_provided(notification_template):
     context = {
         "extra_var": "foo",
@@ -60,6 +61,7 @@ def test_notification_template_rendering_no_body_text_provided(notification_temp
     assert rendered.body_text == "testihötömölöruumis, muuttujan arvo: html_baz!"
 
 
+@pytest.mark.django_db
 def test_undefined_rendering_context_variable(notification_template):
     context = {"extra_var": "foo", "subject_var": "bar", "body_text_var": "baz"}
 
@@ -70,7 +72,8 @@ def test_undefined_rendering_context_variable(notification_template):
     assert "'body_html_var' is undefined" in str(e.value)
 
 
-def test_notification_sending(notification_template):
+@pytest.mark.django_db
+def test_notification_sending(notification_template, settings):
     context = {
         "extra_var": "foo",
         "subject_var": "bar",
@@ -97,6 +100,7 @@ def test_notification_sending(notification_template):
 
 
 @pytest.mark.parametrize("language", ["fi", "en"])
+@pytest.mark.django_db
 def test_translated_from_email(notification_template, settings, language):
     context = {
         "extra_var": "foo",
@@ -115,7 +119,8 @@ def test_translated_from_email(notification_template, settings, language):
     )
 
 
-def test_notification_delayed_sending(notification_template):
+@pytest.mark.django_db
+def test_notification_delayed_sending(notification_template, settings):
     context = {
         "extra_var": "foo",
         "subject_var": "bar",