UHF-13035: Add paikkatieto street names to elasticsearch index (#1279)

* UHF-13035: Fix CVE-2026-40176, CVE-2026-40261, CVE-2026-6365, CVE-2026-6367, CVE-2026-6366

* UHF-13035: Remove distance based street name filtering

We were having trouble where the correct street name was cut
off at intersections. This change returns more street name
results, which is bettern that some streets sometimes missing.

* UHF-13035: Add paikkatieto street names to elasticsearch for autocomplete

This replaces service map autocomplete in the react app, since
paikkatieto api and service map data have slight differences.

Any difference in street names makes the street unsearchable, since we
match the names with keyword search.

* Update street-data.sh

Author: hyrsky

conf/cmi/search_api.index.paikkatieto_street_names.yml

@@ -0,0 +1,37 @@
+uuid: 3809159c-46bf-43d9-8496-823ce93efac4
+langcode: en
+status: true
+dependencies:
+  config:
+    - search_api.server.default
+  module:
+    - helfi_kymp_content
+    - helfi_react_search
+    - helfi_recommendations
+id: paikkatieto_street_names
+name: 'Paikkatieto street names'
+description: 'Street names from Paikkatieto API for vehicle removal search autocomplete.'
+read_only: false
+field_settings:
+  id:
+    label: ID
+    datasource_id: paikkatieto_street_name_source
+    property_path: id
+    type: string
+  street_name:
+    label: 'Street name'
+    datasource_id: paikkatieto_street_name_source
+    property_path: street_name
+    type: text
+datasource_settings:
+  paikkatieto_street_name_source: {  }
+processor_settings: { }
+tracker_settings:
+  default:
+    indexing_order: fifo
+options:
+  cron_limit: 500
+  delete_on_fail: true
+  index_directly: false
+  track_changes_in_references: true
+server: default

docker/openshift/crons/street-data.sh

@@ -5,5 +5,6 @@ echo "Start indexing street data from external datasource: $(date)"
 while true
 do
   drush sapi-r street_data && drush sapi-i street_data --batch-size=500
+  drush sapi-r paikkatieto_street_names
   sleep 86400
 done

phpstan-baseline.neon

@@ -170,30 +170,7 @@ parameters:
 			count: 1
 			path: public/modules/custom/helfi_kymp_content/src/MobileNoteDataService.php
 
-		-
-			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Paikkatieto\\\\PaikkatietoClient\\:\\:fetchStreetsByPoint\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: public/modules/custom/helfi_kymp_content/src/Paikkatieto/PaikkatietoClient.php
 
-		-
-			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Paikkatieto\\\\PaikkatietoClient\\:\\:fetchStreetsForLineString\\(\\) has parameter \\$coordinates with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: public/modules/custom/helfi_kymp_content/src/Paikkatieto/PaikkatietoClient.php
-
-		-
-			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Paikkatieto\\\\PaikkatietoClient\\:\\:fetchStreetsForLineString\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: public/modules/custom/helfi_kymp_content/src/Paikkatieto/PaikkatietoClient.php
-
-		-
-			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Paikkatieto\\\\PaikkatietoClient\\:\\:makeRequest\\(\\) has parameter \\$queryParams with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: public/modules/custom/helfi_kymp_content/src/Paikkatieto/PaikkatietoClient.php
-
-		-
-			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Paikkatieto\\\\PaikkatietoClient\\:\\:makeRequest\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: public/modules/custom/helfi_kymp_content/src/Paikkatieto/PaikkatietoClient.php
 
 		-
 			message: "#^Method Drupal\\\\helfi_kymp_content\\\\Plugin\\\\Block\\\\SubdistrictsNavigationBlock\\:\\:__construct\\(\\) has parameter \\$configuration with no value type specified in iterable type array\\.$#"

public/modules/custom/helfi_kymp_content/config/schema/helfi_kymp_content.schema.yml

@@ -21,3 +21,9 @@ helfi_kymp_content.settings:
       type: string
     sync_lookback_offset:
       type: string
+    address_search_distance:
+      type: integer
+      label: 'Address search distance in meters'
+    address_search_limit:
+      type: integer
+      label: 'Address search result limit'

public/modules/custom/helfi_kymp_content/helfi_kymp_content.services.yml

@@ -8,12 +8,6 @@ services:
     arguments:
       - 'helfi_kymp_content'
 
-  helfi_kymp_content.search_api_subscriber:
-    class: Drupal\helfi_kymp_content\EventSubscriber\SearchApiSubscriber
-    arguments: ['@logger.channel.helfi_kymp_content']
-    tags:
-      - { name: event_subscriber }
-
   Drupal\helfi_kymp_content\StreetDataService: ~
 
   Drupal\helfi_kymp_content\Paikkatieto\PaikkatietoClient: ~