Skip to content

Commit 169510b

Browse files
committed
refactor: removed unnecessary defaultProps ignoring from vitest setup
HCRC-178
1 parent 1f2f712 commit 169510b

4 files changed

Lines changed: 0 additions & 44 deletions

File tree

apps/events-helsinki/vitest-setup.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,6 @@ loadEnvConfig(process.cwd());
102102

103103
hideConsoleMessages({
104104
error: [
105-
// Hide error message caused by hds-react v3:
106-
// eslint-disable-next-line @stylistic/max-len
107-
// https://github.com/City-of-Helsinki/helsinki-design-system/blob/v3.11.0/packages/react/src/components/dropdown/select/Select.tsx#L669
108-
//
109-
// Example use case:
110-
// TargetAgeGroupSelector (apps/events-helsinki) → Select (hds-react)
111-
// Removing this hiding & running TargetAgeGroupSelector tests should show this error if HDS v3.11.0 is still used.
112-
//
113-
// Related issue:
114-
// https://github.com/facebook/react/issues/29233
115-
/Support for defaultProps will be removed.*Use JavaScript default parameters instead.*hds-react/s,
116105
// CSS stylesheets are not ever parsed by JSDOM, so the message is useless.
117106
/Could not parse CSS stylesheet/,
118107
],

apps/hobbies-helsinki/vitest-setup.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,6 @@ loadEnvConfig(process.cwd());
102102

103103
hideConsoleMessages({
104104
error: [
105-
// Hide error message caused by hds-react v3:
106-
// eslint-disable-next-line @stylistic/max-len
107-
// https://github.com/City-of-Helsinki/helsinki-design-system/blob/v3.11.0/packages/react/src/components/dropdown/select/Select.tsx#L669
108-
//
109-
// Example use case:
110-
// TargetAgeGroupSelector (apps/events-helsinki) → Select (hds-react)
111-
// Removing this hiding & running TargetAgeGroupSelector tests should show this error if HDS v3.11.0 is still used.
112-
//
113-
// Related issue:
114-
// https://github.com/facebook/react/issues/29233
115-
/Support for defaultProps will be removed.*Use JavaScript default parameters instead.*hds-react/s,
116105
// CSS stylesheets are not ever parsed by JSDOM, so the message is useless.
117106
/Could not parse CSS stylesheet/,
118107
],

apps/sports-helsinki/vitest-setup.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,6 @@ loadEnvConfig(process.cwd());
101101

102102
hideConsoleMessages({
103103
error: [
104-
// Hide error message caused by hds-react v3:
105-
// eslint-disable-next-line @stylistic/max-len
106-
// https://github.com/City-of-Helsinki/helsinki-design-system/blob/v3.11.0/packages/react/src/components/dropdown/select/Select.tsx#L669
107-
//
108-
// Example use case:
109-
// TargetAgeGroupSelector (apps/events-helsinki) → Select (hds-react)
110-
// Removing this hiding & running TargetAgeGroupSelector tests should show this error if HDS v3.11.0 is still used.
111-
//
112-
// Related issue:
113-
// https://github.com/facebook/react/issues/29233
114-
/Support for defaultProps will be removed.*Use JavaScript default parameters instead.*hds-react/s,
115104
// CSS stylesheets are not ever parsed by JSDOM, so the message is useless.
116105
/Could not parse CSS stylesheet/,
117106
],

packages/components/vitest-setup.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -103,17 +103,6 @@ loadEnvConfig(process.cwd());
103103

104104
hideConsoleMessages({
105105
error: [
106-
// Hide error message caused by hds-react v3:
107-
// eslint-disable-next-line @stylistic/max-len
108-
// https://github.com/City-of-Helsinki/helsinki-design-system/blob/v3.11.0/packages/react/src/components/dropdown/select/Select.tsx#L669
109-
//
110-
// Example use case:
111-
// TargetAgeGroupSelector (apps/events-helsinki) → Select (hds-react)
112-
// Removing this hiding & running TargetAgeGroupSelector tests should show this error if HDS v3.11.0 is still used.
113-
//
114-
// Related issue:
115-
// https://github.com/facebook/react/issues/29233
116-
/Support for defaultProps will be removed.*Use JavaScript default parameters instead.*hds-react/s,
117106
// CSS stylesheets are not ever parsed by JSDOM, so the message is useless.
118107
/Could not parse CSS stylesheet/,
119108
],

0 commit comments

Comments
 (0)