fix(search): filter event search with division

TH-1429.

NOTE: This affects in every apps searches:
- event / course search
- similar events
- upcoming events

The event search result list should not contain events outside the city
of Helsinki. This commit fixes the event list search variables to
contain a city of Helsinki division filter.

The `*Ongoing*` -queries in LinkedEvents are using a search index
(cache) that stores only the city of Helsinki events, but when the
*Ongoing* -filter is not in use, the result set will contain also events
outside the city of Helsinki. When the `allOngoingAnd` text query filter
was replaced with a newer `xFullText` filter, the result set was no
longer limited to city of Helsinki events (by the search index). To fix
that, a new division filter is taken in action.

NOTE: This should not be mixed with the `helsinkiOnly` -filter, that is
still active in code base (but might be hidden in UI). The
`helsinkiOnly` filter currently limits the result set by filtering it
with `publisherAnchestor` field value (ahjo:00001; Helsinki; @see
https://api.hel.fi/linkedevents/v1/organization/ahjo:00001/).

Author: nikomakela

apps/events-helsinki/config/vitest/mocks/eventListMocks.ts

@@ -12,6 +12,7 @@ import {
   EventTypeId,
   DEFAULT_EVENT_SORT_OPTION,
   EVENT_SEARCH_FILTERS,
+  HELSINKI_OCD_DIVISION_ID,
 } from '@events-helsinki/components';
 import AppConfig from '../../../src/domain/app/AppConfig';
 
@@ -27,6 +28,8 @@ export const baseVariables = {
   sort: DEFAULT_EVENT_SORT_OPTION,
   start: 'now',
   startsAfter: undefined,
+  // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+  [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
   // Removed to experiment LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512).
   // superEventType: ['umbrella', 'none'],
   [EVENT_SEARCH_FILTERS.ONGOING]: true,

apps/events-helsinki/src/domain/event/useSimilarEventsQueryVariables.tsx

@@ -1,7 +1,8 @@
 import {
   EVENT_SEARCH_FILTERS,
   EVENT_SORT_OPTIONS,
-} from '@events-helsinki/components/constants/event-constants';
+  HELSINKI_OCD_DIVISION_ID,
+} from '@events-helsinki/components';
 import type { EventFields } from '@events-helsinki/components/types/event-types';
 import React from 'react';
 
@@ -32,6 +33,10 @@ const useSimilarEventsQueryVariables = (event: EventFields) => {
       pageSize: 100,
       params: new URLSearchParams(searchParams),
       sortOrder: EVENT_SORT_OPTIONS.END_TIME,
+      // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+      // NOTE: This is not needed if using any `*Ongoing` -filter as
+      // they automatically limit the results to city of Helsinki events.
+      [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
       // Don't use superEventType when experimenting:
       // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512)
       // superEventType: ['umbrella', 'none']

apps/events-helsinki/src/domain/search/eventSearch/SearchPage.tsx

@@ -14,6 +14,8 @@ import {
   isEventSortOption,
   EventList,
   useClearClosedEventsFromApolloCache,
+  HELSINKI_OCD_DIVISION_ID,
+  EVENT_SEARCH_FILTERS,
 } from '@events-helsinki/components';
 import { useRouter } from 'next/router';
 import queryString from 'query-string';
@@ -45,6 +47,10 @@ const useSearchQuery = () => {
       sortOrder: isEventSortOption(sortParam)
         ? sortParam
         : DEFAULT_EVENT_SORT_OPTION,
+      // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+      // NOTE: This is not needed if using any `*Ongoing` -filter as
+      // they automatically limit the results to city of Helsinki events.
+      [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
       // Don't use superEventType when experimenting
       // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512)
       // superEventType: ['umbrella', 'none']

apps/events-helsinki/src/domain/search/eventSearch/utils.tsx

@@ -141,6 +141,7 @@ export const getEventSearchVariables = ({
   superEventType,
   superEvent,
   place,
+  division,
 }: {
   include: string[];
   language?: AppLanguage;
@@ -150,6 +151,7 @@ export const getEventSearchVariables = ({
   superEventType?: string[];
   superEvent?: string;
   place?: string;
+  division?: string[];
 }): QueryEventListArgs => {
   const {
     categories,
@@ -212,6 +214,7 @@ export const getEventSearchVariables = ({
   return {
     [EVENT_SEARCH_FILTERS.TEXT]: !isEmpty(text) ? text?.join(',') : undefined, // NOTE: only *OngoingAnd supports Array.
     [EVENT_SEARCH_FILTERS.ONGOING]: true,
+    [EVENT_SEARCH_FILTERS.DIVISIONS]: division,
     end,
     include,
     publisherAncestor,

apps/hobbies-helsinki/config/vitest/mocks/eventListMocks.ts

@@ -11,6 +11,7 @@ import {
   EVENT_SEARCH_FILTERS,
   EventListDocument,
   EventTypeId,
+  HELSINKI_OCD_DIVISION_ID,
 } from '@events-helsinki/components';
 import AppConfig from '../../../src/domain/app/AppConfig';
 
@@ -29,6 +30,8 @@ export const baseVariables = {
   sort: 'end_time',
   start: 'now',
   startsAfter: undefined,
+  // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+  [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
   // Removed to experiment:
   // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512).
   // superEventType: ['umbrella', 'none'],

apps/hobbies-helsinki/src/domain/event/useSimilarEventsQueryVariables.tsx

@@ -1,8 +1,9 @@
 import {
   EVENT_SEARCH_FILTERS,
   EVENT_SORT_OPTIONS,
-} from '@events-helsinki/components/constants/event-constants';
-import type { EventFields } from '@events-helsinki/components/types/event-types';
+  HELSINKI_OCD_DIVISION_ID,
+} from '@events-helsinki/components';
+import type { EventFields } from '@events-helsinki/components';
 import React from 'react';
 import {
   getEventCategories,
@@ -34,6 +35,8 @@ const useSimilarEventsQueryVariables = (event: EventFields) => {
         pageSize: 100,
         params: new URLSearchParams(searchParams),
         sortOrder: EVENT_SORT_OPTIONS.END_TIME,
+        // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+        [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
         // Don't use superEventType when experimenting:
         // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512)
         // superEventType: ['umbrella', 'none']

apps/hobbies-helsinki/src/domain/search/eventSearch/SearchPage.tsx

@@ -12,6 +12,8 @@ import {
   EVENT_SORT_OPTIONS,
   EventList,
   useClearClosedEventsFromApolloCache,
+  HELSINKI_OCD_DIVISION_ID,
+  EVENT_SEARCH_FILTERS,
 } from '@events-helsinki/components';
 import { useRouter } from 'next/router';
 import queryString from 'query-string';
@@ -41,6 +43,10 @@ const useSearchQuery = () => {
       params: searchParams,
       place: params.place,
       sortOrder: EVENT_SORT_OPTIONS.END_TIME,
+      // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+      // NOTE: This is not needed if using any `*Ongoing` -filter as
+      // they automatically limit the results to city of Helsinki events.
+      [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
       // Don't use superEventType when experimenting:
       // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512)
       // superEventType: ['umbrella', 'none']

apps/hobbies-helsinki/src/domain/search/eventSearch/utils.tsx

@@ -181,6 +181,7 @@ export const getEventSearchVariables = ({
   superEventType,
   superEvent,
   place,
+  division,
 }: {
   include: string[];
   language?: AppLanguage;
@@ -190,6 +191,7 @@ export const getEventSearchVariables = ({
   superEventType?: string[];
   superEvent?: string;
   place?: string;
+  division?: string[];
 }): QueryEventListArgs => {
   const {
     categories,
@@ -259,6 +261,7 @@ export const getEventSearchVariables = ({
   return {
     [EVENT_SEARCH_FILTERS.TEXT]: !isEmpty(text) ? text?.join(',') : undefined, // NOTE: only *OngoingAnd supports Array.
     [EVENT_SEARCH_FILTERS.ONGOING]: true,
+    [EVENT_SEARCH_FILTERS.DIVISIONS]: division,
     end,
     include,
     publisherAncestor,

apps/sports-helsinki/config/vitest/mocks/eventListMocks.ts

@@ -7,7 +7,12 @@ import type {
   EventType,
   QueryEventListArgs,
 } from '@events-helsinki/components';
-import { EventListDocument, EventTypeId } from '@events-helsinki/components';
+import {
+  EVENT_SEARCH_FILTERS,
+  EventListDocument,
+  EventTypeId,
+  HELSINKI_OCD_DIVISION_ID,
+} from '@events-helsinki/components';
 
 export const baseVariables = {
   end: '',
@@ -21,6 +26,8 @@ export const baseVariables = {
   publisherAncestor: null,
   sort: 'end_time',
   start: 'now',
+  // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+  [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
   // Removed to experiment LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512).
   // superEventType: ['umbrella', 'none'],
 };

apps/sports-helsinki/src/domain/event/useSimilarEventsQueryVariables.tsx

@@ -1,5 +1,8 @@
-import { EVENT_SORT_OPTIONS } from '@events-helsinki/components/constants/event-constants';
-import { EventTypeId } from '@events-helsinki/components/types';
+import {
+  EVENT_SORT_OPTIONS,
+  EventTypeId,
+  HELSINKI_OCD_DIVISION_ID,
+} from '@events-helsinki/components';
 import type { EventFields } from '@events-helsinki/components/types/event-types';
 import React from 'react';
 import { EVENT_SEARCH_FILTERS } from '../search/eventSearch/constants';
@@ -31,6 +34,8 @@ const useSimilarEventsQueryVariables = (event: EventFields) => {
         pageSize: 100,
         params: new URLSearchParams(searchParams),
         sortOrder: EVENT_SORT_OPTIONS.END_TIME,
+        // Always filter with HELSINKI_OCD_DIVISION_ID to limit the results to city of Helsinki events.
+        [EVENT_SEARCH_FILTERS.DIVISIONS]: [HELSINKI_OCD_DIVISION_ID],
         // Don't use superEventType when experimenting:
         // LIIKUNTA-512 (https://helsinkisolutionoffice.atlassian.net/browse/LIIKUNTA-512)
         // superEventType: ['umbrella', 'none']