Skip to content

Commit 1eff026

Browse files
mrTuomoKcursoragent
andcommitted
fix: address pre-merge review items for pnpm migration
Fix test:debug vitest flag typo, set HUSKY=0 in cache/proxy Docker installs, and skip build-storybook in CI when a package has no script. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent a247644 commit 1eff026

10 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/workflows/ci-packages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
run: pnpm --filter '[origin/main]' --filter '!{apps/**}' --filter '!{proxies/**}' --filter '!events-helsinki-monorepo' run build
8888

8989
- name: Run storybook build for changed packages
90-
run: pnpm --filter '[origin/main]' --filter '!{apps/**}' --filter '!{proxies/**}' --filter '!events-helsinki-monorepo' run build-storybook
90+
run: pnpm --filter '[origin/main]' --filter '!{apps/**}' --filter '!{proxies/**}' --filter '!events-helsinki-monorepo' --if-present run build-storybook
9191

9292
- name: Run tests
9393
working-directory: packages/components

DockerfileCache

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ COPY --from=deps --chown=default:root /workspace-install ./
129129

130130
USER default
131131

132+
ENV HUSKY=0
132133
RUN pnpm install --frozen-lockfile
133134

134135
FROM ${BUILDER_FROM_IMAGE} AS cache

apps/events-helsinki/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"test": "cross-env TZ=Europe/Helsinki vitest run",
3232
"test:changed": "pnpm run test --changed",
3333
"test:coverage": "pnpm run test --coverage",
34-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
34+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
3535
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
3636
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
3737
"test:browser": "testcafe \"chrome --disable-features=LocalNetworkAccessChecks --window-size='1249,720'\" browser-tests/ --live --dev",

apps/hobbies-helsinki/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"test": "cross-env TZ=Europe/Helsinki vitest run",
3232
"test:changed": "pnpm run test --changed",
3333
"test:coverage": "pnpm run test --coverage",
34-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
34+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
3535
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
3636
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
3737
"test:browser": "testcafe \"chrome --disable-features=LocalNetworkAccessChecks --window-size='1249,720'\" browser-tests/ --live --dev",

apps/sports-helsinki/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"test": "cross-env TZ=Europe/Helsinki vitest run",
3333
"test:changed": "pnpm run test --changed",
3434
"test:coverage": "pnpm run test --coverage",
35-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
35+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
3636
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
3737
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
3838
"test:browser": "testcafe \"chrome --disable-features=LocalNetworkAccessChecks --window-size='1249,720'\" browser-tests/ --live --dev",

packages/components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"test": "cross-env TZ=Europe/Helsinki vitest run",
3434
"test:changed": "pnpm run test --changed",
3535
"test:coverage": "pnpm run test --coverage",
36-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
36+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
3737
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
3838
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
3939
"test-watch": "vitest watch --ui",

packages/graphql-proxy-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"test": "cross-env TZ=Europe/Helsinki vitest run",
2020
"test:changed": "pnpm run test --changed",
2121
"test:coverage": "pnpm run test --coverage",
22-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
22+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
2323
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
2424
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
2525
"typecheck": "tsc --project ./tsconfig.json --noEmit"

proxies/events-graphql-proxy/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"test": "cross-env TZ=Europe/Helsinki vitest run",
2323
"test:changed": "pnpm run test --changed",
2424
"test:coverage": "pnpm run test --coverage",
25-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
25+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
2626
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
2727
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
2828
"typecheck": "tsc --project ./tsconfig.json --noEmit",

proxies/venue-graphql-proxy/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"test": "cross-env TZ=Europe/Helsinki vitest run",
2323
"test:changed": "pnpm run test --changed",
2424
"test:coverage": "pnpm run test --coverage",
25-
"test:debug": "pnpm run test --inspect-brk ----no-file-parallelism",
25+
"test:debug": "pnpm run test --inspect-brk --no-file-parallelism",
2626
"test:staged": "cross-env TZ=Europe/Helsinki vitest related --run",
2727
"test:watch": "cross-env TZ=Europe/Helsinki vitest watch",
2828
"typecheck": "tsc --project ./tsconfig.json --noEmit",

proxy.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ COPY --from=deps --chown=default:root /workspace-install ./
117117

118118
# Optional: if the app depends on global /static shared assets like images, locales...
119119

120+
ENV HUSKY=0
120121
RUN pnpm install --frozen-lockfile
121122

122123
# build

0 commit comments

Comments
 (0)