Skip to content

Commit 879b21a

Browse files
committed
fix(sports): move ontology words last in venue hero
LIIKUNTA-759. The venue hero still had CSS that used an order attribute to reformat the venue hero content section. Removing the order attributes and moving the keywords last in DOM makes the venue hero now consistent with events hero.
1 parent 1872b80 commit 879b21a

2 files changed

Lines changed: 6 additions & 30 deletions

File tree

apps/sports-helsinki/src/domain/venue/venueHero/VenueHero.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ const VenueHero: React.FC<Props> = ({ venue }) => {
123123
<div className={styles.leftPanelWrapper}>
124124
<div className={styles.leftPanelEmpty} />
125125
<div className={styles.textWrapper}>
126-
<div>
127-
<VenueKeywords whiteOnly venue={venue} />
128-
</div>
129126
<h1 className={styles.title}>
130127
{venue.name}
131128
{isHelsinkiCityOwned && <HelsinkiCityOwnedIcon />}
@@ -144,6 +141,9 @@ const VenueHero: React.FC<Props> = ({ venue }) => {
144141
</ul>
145142
</div>
146143
</div>
144+
<div className={styles.keywordsWrapper}>
145+
<VenueKeywords whiteOnly venue={venue} />
146+
</div>
147147
</div>
148148
</div>
149149
</div>

apps/sports-helsinki/src/domain/venue/venueHero/venueHero.module.scss

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ $logoWidth: 5.5rem;
6666
}
6767

6868
.additionalInfo {
69-
order: 6;
7069
margin-top: var(--spacing-s);
7170
}
7271

@@ -104,20 +103,14 @@ $logoWidth: 5.5rem;
104103
width: unset;
105104
}
106105

107-
.categoryWrapper {
108-
order: 1;
109-
}
110-
111106
.date {
112-
order: 2;
113107
margin-top: 0.5rem;
114108
font-size: var(--fontsize-body-l);
115109
line-height: 1.625rem;
116110
min-height: 1.625rem;
117111
}
118112

119113
.title {
120-
order: 3;
121114
font-size: var(--fontsize-heading-l);
122115
line-height: var(--lineheight-m);
123116
font-weight: 400;
@@ -128,30 +121,13 @@ $logoWidth: 5.5rem;
128121
}
129122

130123
.description {
131-
order: 4;
132124
font-size: var(--fontsize-body-xl);
133125
line-height: var(--spacing-l);
134126
}
127+
}
135128

136-
.location {
137-
order: 5;
138-
}
139-
140-
.start {
141-
order: 6;
142-
}
143-
144-
.price {
145-
order: 7;
146-
}
147-
148-
.buyButtonWrapper {
149-
order: 8;
150-
}
151-
152-
.registrationButtonWrapper {
153-
order: 9;
154-
}
129+
.keywordsWrapper {
130+
margin: var(--spacing-2-xs) 0;
155131
}
156132

157133
.buyButtonWrapper {

0 commit comments

Comments
 (0)