feat: filter secondary school courses HH-460 (#993)

* feat: filter secondary school courses

Refs: HH-460

Author: Riippi

apps/hobbies-helsinki/src/domain/event/__tests__/EventPageContainer.test.tsx

@@ -34,6 +34,7 @@ import {
 } from '../../../../config/vitest/test-utils';
 
 import AppConfig from '../../app/AppConfig';
+import { HOBBIES_EXCLUDED_KEYWORDS } from '../../search/eventSearch/constants';
 import type { EventPageContainerProps } from '../EventPageContainer';
 import EventPageContainer from '../EventPageContainer';
 
@@ -244,6 +245,7 @@ it('shows similar events when SIMILAR_EVENTS flag is on', async () => {
           audienceMinAgeLt: '5',
           audienceMaxAgeGt: '15',
           keywordOrSet2: ['yso:p916'],
+          keywordNot: HOBBIES_EXCLUDED_KEYWORDS,
           language: undefined,
           pageSize: 100,
           publisherAncestor: null,

apps/hobbies-helsinki/src/domain/search/eventSearch/__tests__/utils.test.ts

@@ -5,7 +5,10 @@ import {
 } from '@events-helsinki/components';
 import { advanceTo, clear } from 'jest-date-mock';
 
-import { COURSE_DEFAULT_SEARCH_FILTERS } from '../constants';
+import {
+  COURSE_DEFAULT_SEARCH_FILTERS,
+  HOBBIES_EXCLUDED_KEYWORDS,
+} from '../constants';
 import {
   clampAgeInput,
   getEventSearchVariables,
@@ -141,6 +144,29 @@ describe('getEventSearchVariables function', () => {
     expect(start7).toBe('now');
     expect(end7).toBe('2020-10-15');
   });
+
+  it('should always include HOBBIES_EXCLUDED_KEYWORDS in keywordNot', () => {
+    const { keywordNot } = getEventSearchVariables({
+      ...defaultParams,
+      params: new URLSearchParams(),
+    });
+    expect(keywordNot).toStrictEqual(
+      expect.arrayContaining(HOBBIES_EXCLUDED_KEYWORDS)
+    );
+  });
+
+  it('should merge user-provided keywordNot with HOBBIES_EXCLUDED_KEYWORDS', () => {
+    const userKeyword = 'yso:p1234';
+    const { keywordNot } = getEventSearchVariables({
+      ...defaultParams,
+      params: new URLSearchParams(
+        `?${EVENT_SEARCH_FILTERS.KEYWORD_NOT}=${userKeyword}`
+      ),
+    });
+    expect(keywordNot).toStrictEqual(
+      expect.arrayContaining([userKeyword, ...HOBBIES_EXCLUDED_KEYWORDS])
+    );
+  });
 });
 
 describe('getNextPage function', () => {

apps/hobbies-helsinki/src/domain/search/eventSearch/constants.tsx

@@ -94,6 +94,15 @@ export const CATEGORY_CATALOG = {
   },
 };
 
+/**
+ * Keywords that are always excluded from hobbies search results,
+ * regardless of user-provided filters.
+ */
+export const HOBBIES_EXCLUDED_KEYWORDS = [
+  // Secondary school cross-institutional studies are not hobbies
+  'helsinki:secondary_schools_cross_institutional_studies',
+];
+
 export const MOVIES_AND_MEDIA_COURSES_KEYWORDS = [
   'yso:p1235', // elokuva
   'kulke:29', // elokuvat

apps/hobbies-helsinki/src/domain/search/eventSearch/utils.tsx

@@ -36,6 +36,7 @@ import type { COURSE_CATEGORIES } from './constants';
 import {
   COURSE_DEFAULT_SEARCH_FILTERS,
   courseCategories,
+  HOBBIES_EXCLUDED_KEYWORDS,
   MAPPED_PLACES,
   CATEGORY_CATALOG,
   MAPPED_COURSE_CATEGORIES,
@@ -275,7 +276,7 @@ export const getEventSearchVariables = ({
     // internetBased: onlyRemoteEvents || undefined,
     keywordOrSet2: [...(keyword ?? []), ...mappedCategories],
     keywordAnd,
-    keywordNot,
+    keywordNot: [...(keywordNot ?? []), ...HOBBIES_EXCLUDED_KEYWORDS],
     language,
     location: places.sort((a, b) => a.localeCompare(b)),
     pageSize,