Skip to content

Commit 811f835

Browse files
committed
IO-832 Fixed tests for reordering rows
1 parent da9a288 commit 811f835

1 file changed

Lines changed: 28 additions & 27 deletions

File tree

infraohjelmointi_api/tests/test_CacheService.py

Lines changed: 28 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -650,27 +650,6 @@ def setUp(self):
650650
self.user.ad_groups.add(coord_group)
651651
self.client.force_login(self.user)
652652

653-
def test_reorder_with_permission_returns_200(self):
654-
"""User with correct permissions can reorder."""
655-
obj1 = ProjectType.objects.create(value='reorder_test')
656-
obj2 = ProjectType.objects.create(value='reorder_test')
657-
658-
payload = {
659-
"order": [
660-
{"id": obj1.id, "order": 2},
661-
{"id": obj2.id, "order": 1},
662-
]
663-
}
664-
665-
response = self.client.put(
666-
'/project-types/reorder/',
667-
payload,
668-
content_type='application/json'
669-
)
670-
671-
self.assertEqual(response.status_code, 200)
672-
673-
674653
def test_project_types_list_is_cached(self):
675654
"""Test that project types list response is cached."""
676655
ProjectType.objects.create(value='test_type')
@@ -758,6 +737,30 @@ def test_delete_invalidates_cache(self):
758737

759738
self.assertIsNone(CacheService.get_lookup('ProjectType'))
760739

740+
def test_reorder_with_permission_returns_200(self):
741+
"""User with correct permissions can reorder."""
742+
admin_group = ADGroup.objects.create(
743+
name='sg_kymp_sso_io_admin',
744+
display_name='Admins'
745+
)
746+
self.user.ad_groups.add(admin_group)
747+
748+
obj1 = ProjectType.objects.create(value='reorder_test')
749+
obj2 = ProjectType.objects.create(value='reorder_test')
750+
751+
payload = [
752+
{"id": obj1.id, "order": 2},
753+
{"id": obj2.id, "order": 1},
754+
]
755+
756+
response = self.client.put(
757+
'/project-types/reorder/',
758+
payload,
759+
content_type='application/json'
760+
)
761+
762+
self.assertEqual(response.status_code, 200)
763+
761764
def test_reorder_without_permission_returns_403(self):
762765
"""User without correct permissions cannot reorder."""
763766
# Remove permission group
@@ -766,12 +769,10 @@ def test_reorder_without_permission_returns_403(self):
766769
obj1 = ProjectType.objects.create(value='reorder_fail_test')
767770
obj2 = ProjectType.objects.create(value='reorder_fail_test')
768771

769-
payload = {
770-
"order": [
771-
{"id": obj1.id, "order": 2},
772-
{"id": obj2.id, "order": 1},
773-
]
774-
}
772+
payload = [
773+
{"id": obj1.id, "order": 2},
774+
{"id": obj2.id, "order": 1},
775+
]
775776

776777
response = self.client.put(
777778
'/project-types/reorder/',

0 commit comments

Comments
 (0)