Ticket validity checking

Duration and leeway are used when determining if a ticket is valid.

Refs KK-912

Author: charn

events/tests/snapshots/snap_test_api.py

@@ -1522,7 +1522,7 @@
     "data": {
         "verifyTicket": {
             "eventName": "Record card my. Sure sister return.",
-            "occurrenceTime": "2020-12-13T00:00:00+00:00",
+            "occurrenceTime": "2020-12-12T00:00:00+00:00",
             "validity": True,
             "venueName": "Remember stay public high concern glass person.",
         }

events/tests/test_api.py

@@ -2588,7 +2588,7 @@ def test_event_ticket_system_password_not_own_child(guardian_api_client):
 
 # NOTE: api_client is for anonymous users
 def test_verify_valid_ticket(api_client, snapshot):
-    upcoming_occurrence = OccurrenceFactory(time=timezone.now() + timedelta(days=1))
+    upcoming_occurrence = OccurrenceFactory(time=timezone.now())
     valid_enrolment = EnrolmentFactory(occurrence=upcoming_occurrence)
     executed = api_client.execute(
         VERIFY_TICKET_QUERY, variables={"referenceId": valid_enrolment.reference_id}

events/tests/test_ticket_service.py

@@ -1,4 +1,4 @@
-from datetime import datetime
+from datetime import timedelta
 
 import pytest
 from django.utils import timezone
@@ -16,17 +16,20 @@
 @pytest.mark.parametrize(
     "occurrence_time, expected",
     [
-        (datetime(2020, 11, 11, 12, tzinfo=timezone.now().tzinfo), True),  # Present
-        (datetime(2020, 11, 11, 13, tzinfo=timezone.now().tzinfo), True),  # +1h
-        (datetime(2020, 11, 11, 11, tzinfo=timezone.now().tzinfo), True),  # -1h
-        (datetime(2020, 11, 13, 12, tzinfo=timezone.now().tzinfo), True),  # +1d
-        (datetime(2020, 11, 10, 12, tzinfo=timezone.now().tzinfo), False),  # -1d
+        (timedelta(minutes=16), False),  # Starts in 16 minutes
+        (timedelta(minutes=15), True),  # Starts in 15 minutes
+        (timedelta(minutes=0), True),  # Starts now
+        (timedelta(minutes=-30), True),  # Ended 15 minutes ago
+        (timedelta(minutes=-31), False),  # Ended 16 minutes ago
     ],
 )
 @pytest.mark.django_db
-def test_check_ticket_validity(project, occurrence_time, expected):
+def test_check_ticket_validity(project, occurrence_time, expected, settings):
     """Tickets are show valid for the whole day on the occurrence day."""
-    occurrence = OccurrenceFactory(time=occurrence_time)
+    settings.KUKKUU_ENROLLED_OCCURRENCE_IN_PAST_LEEWAY = 15
+    occurrence = OccurrenceFactory(
+        time=timezone.now() + occurrence_time, event__duration=15
+    )
     expected_enrolment = EnrolmentFactory(occurrence=occurrence)
     enrolment, validity = check_ticket_validity(expected_enrolment.reference_id)
     assert enrolment == expected_enrolment

events/ticket_service.py

@@ -1,5 +1,7 @@
+from datetime import timedelta
 from typing import Tuple
 
+from django.conf import settings
 from django.utils import timezone
 
 from events.models import Enrolment
@@ -14,11 +16,16 @@ def check_ticket_validity(enrolment_reference_id: str) -> Tuple[Enrolment, bool]
 
     enrolment_id = Enrolment.decode_reference_id(enrolment_reference_id)
     try:
-        enrolment = Enrolment.objects.get(pk=enrolment_id)
+        enrolment = Enrolment.objects.with_end_time().get(pk=enrolment_id)
     except (Enrolment.DoesNotExist):
         raise EnrolmentReferenceIdDoesNotExist(
             "The decoded reference id does not match to any of the existing enrolments"
         )
-
-    valid = enrolment.occurrence.time.date() >= timezone.localdate()
+    start = enrolment.occurrence.time - timedelta(
+        minutes=settings.KUKKUU_ENROLLED_OCCURRENCE_IN_PAST_LEEWAY
+    )
+    end = enrolment.end_time + timedelta(
+        minutes=settings.KUKKUU_ENROLLED_OCCURRENCE_IN_PAST_LEEWAY
+    )
+    valid = start <= timezone.now() <= end
     return enrolment, valid