Merge pull request #43 from City-of-Helsinki/max-num-of-children

Limit number of children per guardian

Author: tuomas777

children/schema.py

@@ -1,4 +1,5 @@
 import graphene
+from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ValidationError
 from django.db import transaction
@@ -113,6 +114,9 @@ def mutate_and_get_payload(cls, root, info, **kwargs):
         if not children_data:
             raise KukkuuGraphQLError("At least one child is required.")
 
+        if len(children_data) > settings.KUKKUU_MAX_NUM_OF_CHILDREN_PER_GUARDIAN:
+            raise KukkuuGraphQLError("Too many children.")
+
         guardian_data = kwargs["guardian"]
         guardian = Guardian.objects.create(
             user=user,
@@ -164,6 +168,12 @@ def mutate_and_get_payload(cls, root, info, **kwargs):
                 'You need to use "SubmitChildrenAndGuardianMutation" first.'
             )
 
+        if (
+            user.guardian.children.count()
+            >= settings.KUKKUU_MAX_NUM_OF_CHILDREN_PER_GUARDIAN
+        ):
+            raise KukkuuGraphQLError("Too many children.")
+
         validate_child_data(kwargs)
         user = info.context.user
         relationship_data = kwargs.pop("relationship", {})

children/tests/test_api.py

@@ -199,6 +199,20 @@ def test_submit_children_and_guardian_can_be_done_only_once(guardian_api_client)
     assert "You have already used this mutation." in str(executed["errors"])
 
 
+def test_submit_children_and_guardian_children_limit(user_api_client, settings):
+    variables = deepcopy(SUBMIT_CHILDREN_AND_GUARDIAN_VARIABLES)
+    variables["input"]["children"] = [
+        variables["input"]["children"][0]
+        for _ in range(settings.KUKKUU_MAX_NUM_OF_CHILDREN_PER_GUARDIAN + 1)
+    ]
+
+    executed = user_api_client.execute(
+        SUBMIT_CHILDREN_AND_GUARDIAN_MUTATION, variables=variables,
+    )
+
+    assert "Too many children." in str(executed["errors"])
+
+
 CHILDREN_QUERY = """
 query Children {
   children {
@@ -399,6 +413,19 @@ def test_add_child_mutation_requires_guardian(user_api_client):
     assert Child.objects.count() == 0
 
 
+def test_add_child_mutation_children_limit(guardian_api_client, settings):
+    ChildWithGuardianFactory.create_batch(
+        settings.KUKKUU_MAX_NUM_OF_CHILDREN_PER_GUARDIAN,
+        relationship__guardian=guardian_api_client.user.guardian,
+    )
+
+    executed = guardian_api_client.execute(
+        ADD_CHILD_MUTATION, variables=ADD_CHILD_VARIABLES
+    )
+
+    assert "Too many children." in str(executed["errors"])
+
+
 UPDATE_CHILD_MUTATION = """
 mutation UpdateChild($input: UpdateChildMutationInput!) {
   updateChild(input: $input) {

kukkuu/settings.py

@@ -180,6 +180,8 @@
 
 GRAPHQL_JWT = {"JWT_AUTH_HEADER_PREFIX": "Bearer"}
 
+KUKKUU_MAX_NUM_OF_CHILDREN_PER_GUARDIAN = 100
+
 LOGGING = {
     "version": 1,
     "disable_existing_loggers": False,