CSV export view for NotificationTemplates and support for file imports#506
CSV export view for NotificationTemplates and support for file imports#506nikomakela wants to merge 4 commits into
Conversation
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr506.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr506.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1441-notification-template-csv-export
branch
from
da4bac4 to
2fc3747
Compare
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr506.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr506.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1441-notification-template-csv-export
branch
from
2fc3747 to
afc1f9a
Compare
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr506.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr506.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
force-pushed
the
KK-1441-notification-template-csv-export
branch
from
afc1f9a to
889a52c
Compare
In `settings.py` CSP configuration it was said that SpectacularRedocView needs `UNSAFE_EVAL`, but it does not need one. If it does, it could quite easily be set for redoc view only in the same `urls.py`.
KK-1441. Replace the importers app used to maintain and import django_ilmoitin notification templates from a Google Drive Spreadsheet with notification_importers app, that is copied with minimal changes from the [Kultus API](https://github.com/City-of-Helsinki/palvelutarjotin/tree/ 80e9f26097825fee03012e2a74e02e0398eeb705/notification_importers). The new app to import notification templates does not only support the Google Drive Spreadsheet importing, but also importing from files. The long goal is to get rid of external Google Drive Spreadsheet, because it's so hard to maintain and the notification templates are not in code repository.
KK-1441. Preview was prevented by CSP control.
KK-1441. Add an export to CSV button for notification templates in Django admin site.
nikomakela
force-pushed
the
KK-1441-notification-template-csv-export
branch
from
889a52c to
77ba0ef
Compare
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr506.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr506.api.dev.hel.ninja 😆🎉🎉🎉 |
|
|
Removed review request from myself to make my review request list more up to date. If this really needs code review still, and this is really going to be merged, then please ask for code review from me anew. Thank you! |
|
Converted to draft, since there is no plan for this yet and Solution office requested the change to draft. |
3 participants
KK-1441.
Replace the old Importers app with a clone from Kultus (https://github.com/City-of-Helsinki/palvelutarjotin/tree/80e9f26097825fee03012e2a74e02e0398eeb705/notification_importers). The improved version of notification importers is first copied with minimal changes in order to get it to work in Kukkuu. Then it's extended with an export to CSV feature. The long goal is to get rid of Google Drive Spreadsheet that stores the content for notification templates. This new Django app looks the same as the old one, but also supports importing the notification templates from the code repo itself. It's been in use in Kultus for a long now.
NOTE: This PR also contains small fixes to CSP rules.