fix: add cross-field validation for registration account fields

- prevent using internal order and profit center at the same time
- require project when both internal order and profit center are empty
- add localized validation messages for fi/en/sv
- add tests for new registration account validation rules

Refs: LINK-2475

Author: tjgofore

src/domain/app/i18n/constants.ts

@@ -39,3 +39,8 @@ export enum VALIDATION_MESSAGE_KEYS {
   URL = 'form.validation.string.url',
   ZIP = 'form.validation.string.zip',
 }
+
+export enum REGISTRATION_ACCOUNT_VALIDATION_MESSAGE_KEYS {
+  INTERNAL_ORDER_OR_PROFIT_CENTER = 'form.validation.registrationAccount.internalOrderOrProfitCenter',
+  PROJECT_REQUIRED = 'form.validation.registrationAccount.projectRequired',
+}

src/domain/app/i18n/en.json

@@ -1185,6 +1185,10 @@
       "offersRequired": "At least 1 price information must be added",
       "priceInvalid": "Maximum of two decimal places is allowed",
       "priceGroupsRequired": "At least 1 customer group must be added",
+      "registrationAccount": {
+        "internalOrderOrProfitCenter": "Provide either internal order or profit center, not both.",
+        "projectRequired": "Project is required when neither internal order nor profit center is provided."
+      },
       "soMeLinkDuplicate": "SoMe links cannot be the same",
       "string": {
         "charsLeft": "{{count}} character left",

src/domain/app/i18n/fi.json

@@ -1165,6 +1165,10 @@
       "offersRequired": "Vähintään 1 hintatieto vaaditaan",
       "priceInvalid": "Enintään kaksi desimaalia on sallittu",
       "priceGroupsRequired": "Vähintään 1 asiakasryhmä vaaditaan",
+      "registrationAccount": {
+        "internalOrderOrProfitCenter": "Anna joko sisäinen tilaus tai tulosyksikkö, ei molempia.",
+        "projectRequired": "Projekti on pakollinen, jos sisäistä tilausta tai tulosyksikköä ei ole annettu."
+      },
       "soMeLinkDuplicate": "SoMe-linkit eivät voi olla samoja",
       "string": {
         "charsLeft": "{{count}} merkki jäljellä",

src/domain/app/i18n/sv.json

@@ -1185,6 +1185,10 @@
       "offersRequired": "Minst 1 prisinformation måste läggas till",
       "priceInvalid": "Högst två decimaler är tillåtna",
       "priceGroupsRequired": "Minst 1 kundgrupp måste läggas till",
+      "registrationAccount": {
+        "internalOrderOrProfitCenter": "Ange antingen intern order eller resultatenhet, inte båda.",
+        "projectRequired": "Projekt krävs när varken intern order eller resultatenhet har angetts."
+      },
       "soMeLinkDuplicate": "SoMe-länkar kan inte vara desamma",
       "string": {
         "charsLeft": "{{count}} tecken kvar",

src/domain/registration/__tests__/validation.test.ts

@@ -36,7 +36,7 @@ describe('registrationSchema', () => {
     mainLedgerAccount: '3503',
     operationArea: '',
     profitCenter: '',
-    project: '',
+    project: 'project',
   };
   const validRegistrationValues: RegistrationFormFields = {
     ...REGISTRATION_INITIAL_VALUES,
@@ -219,11 +219,13 @@ describe('registrationSchema', () => {
     [{ balanceProfitCenter: mockString(11) }],
     [{ companyCode: '' }],
     [{ companyCode: mockString(5) }],
+    [{ internalOrder: 'internal order', profitCenter: 'profit center' }],
     [{ internalOrder: mockString(11) }],
     [{ mainLedgerAccount: '' }],
     [{ mainLedgerAccount: mockString(7) }],
     [{ operationArea: mockString(7) }],
     [{ profitCenter: mockString(8) }],
+    [{ internalOrder: '', profitCenter: '', project: '' }],
     [{ project: mockString(17) }],
   ])('should return false if account is invalid', async (accountFields) => {
     expect(

src/domain/registration/validation.ts

@@ -11,7 +11,10 @@ import {
   isValidTime,
   transformNumber,
 } from '../../utils/validationUtils';
-import { VALIDATION_MESSAGE_KEYS } from '../app/i18n/constants';
+import {
+  REGISTRATION_ACCOUNT_VALIDATION_MESSAGE_KEYS,
+  VALIDATION_MESSAGE_KEYS,
+} from '../app/i18n/constants';
 import { ACCOUNT_TEXT_FIELD_MAX_LENGTH } from '../organization/constants';
 import { PriceGroupOption } from '../priceGroup/types';
 import {
@@ -62,6 +65,37 @@ const priceGroupsSchema = (
     : schema;
 };
 
+const hasNonEmptyValue = (value?: string | null): boolean =>
+  Boolean(value?.trim());
+
+// Prevent submitting both internal order and profit center at the same time.
+const internalOrderOrProfitCenterTest = {
+  name: 'internalOrderOrProfitCenter',
+  message:
+    REGISTRATION_ACCOUNT_VALIDATION_MESSAGE_KEYS.INTERNAL_ORDER_OR_PROFIT_CENTER,
+  test(this: Yup.TestContext) {
+    const { internalOrder, profitCenter } = this.parent;
+    return !(hasNonEmptyValue(internalOrder) && hasNonEmptyValue(profitCenter));
+  },
+};
+
+// If neither internal order nor profit center is given, project must be provided.
+const projectRequiredWhenNoInternalOrderOrProfitCenterTest = {
+  name: 'projectRequiredWhenNoInternalOrderOrProfitCenter',
+  message: REGISTRATION_ACCOUNT_VALIDATION_MESSAGE_KEYS.PROJECT_REQUIRED,
+  test(this: Yup.TestContext) {
+    const { internalOrder, profitCenter, project } = this.parent;
+    return (
+      hasNonEmptyValue(internalOrder) ||
+      hasNonEmptyValue(profitCenter) ||
+      hasNonEmptyValue(project)
+    );
+  },
+};
+
+// Registration account business rules:
+// 1) internal order and profit center are mutually exclusive
+// 2) project is required when both internal order and profit center are empty
 const registrationAccountSchema = Yup.object().shape({
   [REGISTRATION_ACCOUNT_FIELDS.ACCOUNT]: Yup.string().required(
     VALIDATION_MESSAGE_KEYS.STRING_REQUIRED
@@ -88,18 +122,24 @@ const registrationAccountSchema = Yup.object().shape({
       ],
       createStringMaxErrorMessage
     ),
-  [REGISTRATION_ACCOUNT_FIELDS.INTERNAL_ORDER]: Yup.string().max(
-    ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.INTERNAL_ORDER],
-    createStringMaxErrorMessage
-  ),
-  [REGISTRATION_ACCOUNT_FIELDS.PROFIT_CENTER]: Yup.string().max(
-    ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.PROFIT_CENTER],
-    createStringMaxErrorMessage
-  ),
-  [REGISTRATION_ACCOUNT_FIELDS.PROJECT]: Yup.string().max(
-    ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.PROJECT],
-    createStringMaxErrorMessage
-  ),
+  [REGISTRATION_ACCOUNT_FIELDS.INTERNAL_ORDER]: Yup.string()
+    .max(
+      ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.INTERNAL_ORDER],
+      createStringMaxErrorMessage
+    )
+    .test(internalOrderOrProfitCenterTest),
+  [REGISTRATION_ACCOUNT_FIELDS.PROFIT_CENTER]: Yup.string()
+    .max(
+      ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.PROFIT_CENTER],
+      createStringMaxErrorMessage
+    )
+    .test(internalOrderOrProfitCenterTest),
+  [REGISTRATION_ACCOUNT_FIELDS.PROJECT]: Yup.string()
+    .max(
+      ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.PROJECT],
+      createStringMaxErrorMessage
+    )
+    .test(projectRequiredWhenNoInternalOrderOrProfitCenterTest),
   [REGISTRATION_ACCOUNT_FIELDS.OPERATION_AREA]: Yup.string().max(
     ACCOUNT_TEXT_FIELD_MAX_LENGTH[REGISTRATION_ACCOUNT_FIELDS.OPERATION_AREA],
     createStringMaxErrorMessage