fix: only admin can see add registration checkbox LINK-2257 (#500)

* fix: only admin can see add registreation checkbox

Author: Riippi

src/domain/event/eventForm/EventForm.tsx

@@ -541,6 +541,7 @@ const EventForm: React.FC<EventFormProps> = ({
                 <PriceSection
                   event={event}
                   isEditingAllowed={isEditingAllowed}
+                  isAdminUser={isAdminUser}
                 />
               </Section>
               <Section title={t(`event.form.sections.channels.${values.type}`)}>

src/domain/event/formSections/priceSection/PriceSection.tsx

@@ -28,9 +28,14 @@ import ValidationError from './validationError/ValidationError';
 interface Props {
   event?: EventFieldsFragment | null;
   isEditingAllowed: boolean;
+  isAdminUser: boolean;
 }
 
-const PriceSection: React.FC<Props> = ({ event, isEditingAllowed }) => {
+const PriceSection: React.FC<Props> = ({
+  event,
+  isEditingAllowed,
+  isAdminUser,
+}) => {
   const { t } = useTranslation();
   const { user } = useUser();
 
@@ -79,14 +84,15 @@ const PriceSection: React.FC<Props> = ({ event, isEditingAllowed }) => {
               name={EVENT_FIELDS.HAS_PRICE}
             />
           </FormGroup>
-          {featureFlagUtils.isFeatureEnabled('WEB_STORE_INTEGRATION') && (
-            <Field
-              component={CheckboxField}
-              disabled={!isEditingAllowed || !hasPrice}
-              label={t(`event.form.labelIsRegistrationPlanned.${type}`)}
-              name={EVENT_FIELDS.IS_REGISTRATION_PLANNED}
-            />
-          )}
+          {featureFlagUtils.isFeatureEnabled('WEB_STORE_INTEGRATION') &&
+            isAdminUser && (
+              <Field
+                component={CheckboxField}
+                disabled={!isEditingAllowed || !hasPrice}
+                label={t(`event.form.labelIsRegistrationPlanned.${type}`)}
+                name={EVENT_FIELDS.IS_REGISTRATION_PLANNED}
+              />
+            )}
 
           <ValidationError />
         </FieldColumn>

src/domain/event/formSections/priceSection/__tests__/PriceSection.test.tsx

@@ -37,6 +37,9 @@ beforeEach(() => {
   mockAuthenticatedLoginState();
 });
 
+const registrationCheckboxName =
+  'Tapahtumalle luodaan Linked Events -ilmoittautuminen';
+
 type InitialValues = {
   [EVENT_FIELDS.EVENT_INFO_LANGUAGES]: string[];
   [EVENT_FIELDS.HAS_PRICE]: boolean;
@@ -58,17 +61,19 @@ const defaultMocks = [mockedFreePriceGroupsResponse, mockedUserResponse];
 const renderPriceSection = ({
   initialValues,
   mocks = defaultMocks,
+  isAdminUser = true,
 }: {
   initialValues?: Partial<InitialValues>;
   mocks?: MockedResponse[];
+  isAdminUser?: boolean;
 } = {}) =>
   render(
     <Formik
       initialValues={{ ...defaultInitialValues, ...initialValues }}
       onSubmit={vi.fn()}
       validationSchema={publicEventSchema}
     >
-      <PriceSection isEditingAllowed={true} />
+      <PriceSection isEditingAllowed={true} isAdminUser={isAdminUser} />
     </Formik>,
     { mocks }
   );
@@ -120,7 +125,7 @@ const getElement = (
       });
     case 'isRegistrationPlannedCheckbox':
       return screen.getByRole('checkbox', {
-        name: 'Tapahtumalle luodaan Linked Events -ilmoittautuminen',
+        name: registrationCheckboxName,
       });
     case 'priceGroupSelectButton':
       return screen.getByRole('button', { name: /Asiakasryhmä/ });
@@ -255,3 +260,18 @@ test('should add and remove price group', async () => {
     1
   );
 });
+
+test('should not show registration checkbox to non admin user', async () => {
+  const user = userEvent.setup();
+  renderPriceSection({
+    isAdminUser: false,
+  });
+
+  await user.click(getElement('hasPriceCheckbox'));
+
+  expect(
+    screen.queryByRole('checkbox', {
+      name: registrationCheckboxName,
+    })
+  ).not.toBeInTheDocument();
+});