feat: add WEB_STORE_REFUND_DEADLINE_DAYS

refs: LINK-2401

Author: voneiden

src/domain/app/i18n/en.json

@@ -2210,6 +2210,7 @@
     "waitingListTableCount": "{{count}} in Waiting list",
     "warningHasPaymentCancellation": "The participant's payment will be cancelled and the participant cannot be removed.",
     "warningHasPaymentRefund": "The participant's payment will be refunded and the participant cannot be removed.",
+    "warningRefundDeadlinePassed": "The refund deadline has passed and the participant cannot be removed.",
     "warningNoRightsToCreate": "You have insufficient rights to create participants to this registration.",
     "warningNoRightsToEdit": "You have insufficient rights to edit this participant.",
     "warningNoRightsToView": "You have insufficient rights to view participants of this registration."

src/domain/app/i18n/fi.json

@@ -2209,6 +2209,7 @@
     "waitingListTableCount": "{{count}} jonopaikalla",
     "warningHasPaymentCancellation": "Osallistujan maksua perutaan eikä osallistujaa voi poistaa.",
     "warningHasPaymentRefund": "Osallistujan maksua hyvitetään eikä osallistujaa voi poistaa.",
+    "warningRefundDeadlinePassed": "Hyvityksen määräaika on umpeutunut eikä osallistujaa voi poistaa.",
     "warningNoRightsToCreate": "Sinulla ei ole oikeuksia lisätä osallistujia tähän ilmoittautumiseen.",
     "warningNoRightsToEdit": "Sinulla ei ole oikeuksia muokata tätä osallistujaa.",
     "warningNoRightsToView": "Sinulla ei ole oikeuksia nähdä tämän ilmoittautumisen osallistujia."

src/domain/signup/__tests__/permissions.test.ts

@@ -1,10 +1,14 @@
 /* eslint-disable import/no-named-as-default-member */
+import addDays from 'date-fns/addDays';
 import i18n from 'i18next';
 
 import {
+  fakeEvent,
   fakePaymentCancellation,
   fakePaymentRefund,
+  fakePriceGroup,
   fakeRegistration,
+  fakeRegistrationPriceGroup,
   fakeSignup,
   fakeSignupGroup,
   fakeUser,
@@ -29,6 +33,7 @@ describe('getSignupActionWarning function', () => {
     (action) => {
       const commonProps = {
         authenticated: false,
+        registration: fakeRegistration(),
         t: i18n.t.bind(i18n),
         userCanDoAction: false,
       };
@@ -72,6 +77,7 @@ describe('getSignupActionWarning function', () => {
       expect(
         getSignupActionWarning({
           authenticated: true,
+          registration: fakeRegistration(),
           t: i18n.t.bind(i18n),
           userCanDoAction: false,
           action,
@@ -84,6 +90,7 @@ describe('getSignupActionWarning function', () => {
     expect(
       getSignupActionWarning({
         authenticated: true,
+        registration: fakeRegistration(),
         signup: fakeSignup({
           paymentCancellation: fakePaymentCancellation(),
         }),
@@ -98,6 +105,7 @@ describe('getSignupActionWarning function', () => {
     expect(
       getSignupActionWarning({
         authenticated: true,
+        registration: fakeRegistration(),
         signup: fakeSignup(),
         signupGroup: fakeSignupGroup({
           paymentCancellation: fakePaymentCancellation(),
@@ -113,6 +121,7 @@ describe('getSignupActionWarning function', () => {
     expect(
       getSignupActionWarning({
         authenticated: true,
+        registration: fakeRegistration(),
         signup: fakeSignup({
           paymentRefund: fakePaymentRefund(),
         }),
@@ -127,6 +136,7 @@ describe('getSignupActionWarning function', () => {
     expect(
       getSignupActionWarning({
         authenticated: true,
+        registration: fakeRegistration(),
         signup: fakeSignup(),
         signupGroup: fakeSignupGroup({
           paymentRefund: fakePaymentRefund(),
@@ -137,6 +147,112 @@ describe('getSignupActionWarning function', () => {
       })
     ).toBe('Osallistujan maksua hyvitetään eikä osallistujaa voi poistaa.');
   });
+
+  it('should return correct warning when trying to delete paid signup past refund deadline', () => {
+    const eventInFiveDays = addDays(new Date(), 5);
+
+    expect(
+      getSignupActionWarning({
+        authenticated: true,
+        registration: fakeRegistration({
+          event: fakeEvent({ startTime: eventInFiveDays.toISOString() }),
+          registrationPriceGroups: [
+            fakeRegistrationPriceGroup({ price: '10.00' }),
+          ],
+        }),
+        signup: fakeSignup({
+          priceGroup: fakePriceGroup(),
+        }),
+        t: i18n.t.bind(i18n),
+        userCanDoAction: true,
+        action: SIGNUP_ACTIONS.DELETE,
+      })
+    ).toBe('Hyvityksen määräaika on umpeutunut eikä osallistujaa voi poistaa.');
+  });
+
+  it('should return correct warning when trying to delete signup group with paid signups past refund deadline', () => {
+    const eventInFiveDays = addDays(new Date(), 5);
+
+    expect(
+      getSignupActionWarning({
+        authenticated: true,
+        registration: fakeRegistration({
+          event: fakeEvent({ startTime: eventInFiveDays.toISOString() }),
+          registrationPriceGroups: [
+            fakeRegistrationPriceGroup({ price: '10.00' }),
+          ],
+        }),
+        signupGroup: fakeSignupGroup({
+          signups: [fakeSignup({ priceGroup: fakePriceGroup() })],
+        }),
+        t: i18n.t.bind(i18n),
+        userCanDoAction: true,
+        action: SIGNUP_ACTIONS.DELETE,
+      })
+    ).toBe('Hyvityksen määräaika on umpeutunut eikä osallistujaa voi poistaa.');
+  });
+
+  it('should not return refund deadline warning when trying to delete paid signup within refund deadline', () => {
+    const eventInTenDays = addDays(new Date(), 10);
+
+    expect(
+      getSignupActionWarning({
+        authenticated: true,
+        registration: fakeRegistration({
+          event: fakeEvent({ startTime: eventInTenDays.toISOString() }),
+          registrationPriceGroups: [
+            fakeRegistrationPriceGroup({ price: '10.00' }),
+          ],
+        }),
+        signup: fakeSignup({
+          priceGroup: fakePriceGroup(),
+        }),
+        t: i18n.t.bind(i18n),
+        userCanDoAction: true,
+        action: SIGNUP_ACTIONS.DELETE,
+      })
+    ).toBe('');
+  });
+
+  it('should not return refund deadline warning when trying to delete free signup past deadline', () => {
+    const eventInFiveDays = addDays(new Date(), 5);
+
+    expect(
+      getSignupActionWarning({
+        authenticated: true,
+        registration: fakeRegistration({
+          event: fakeEvent({ startTime: eventInFiveDays.toISOString() }),
+          registrationPriceGroups: [
+            fakeRegistrationPriceGroup({ price: '0.00' }),
+          ],
+        }),
+        signup: fakeSignup(),
+        t: i18n.t.bind(i18n),
+        userCanDoAction: true,
+        action: SIGNUP_ACTIONS.DELETE,
+      })
+    ).toBe('');
+  });
+
+  it('should not return refund deadline warning when registration has no pricing', () => {
+    const eventInFiveDays = addDays(new Date(), 5);
+
+    expect(
+      getSignupActionWarning({
+        authenticated: true,
+        registration: fakeRegistration({
+          event: fakeEvent({ startTime: eventInFiveDays.toISOString() }),
+          registrationPriceGroups: [],
+        }),
+        signup: fakeSignup({
+          priceGroup: fakePriceGroup(),
+        }),
+        t: i18n.t.bind(i18n),
+        userCanDoAction: true,
+        action: SIGNUP_ACTIONS.DELETE,
+      })
+    ).toBe('');
+  });
 });
 
 describe('checkCanUserDoSignupAction function', () => {

src/domain/signup/__tests__/refundDeadline.test.ts

@@ -0,0 +1,48 @@
+import addDays from 'date-fns/addDays';
+import subDays from 'date-fns/subDays';
+import { describe, expect, it } from 'vitest';
+
+import { isWithinRefundDeadline } from '../refundDeadline';
+
+describe('isWithinRefundDeadline', () => {
+  it('should return false if eventStartTime is null', () => {
+    expect(isWithinRefundDeadline(null)).toBe(false);
+  });
+
+  it('should return false if eventStartTime is undefined', () => {
+    expect(isWithinRefundDeadline(undefined)).toBe(false);
+  });
+
+  it('should return false if eventStartTime is invalid', () => {
+    expect(isWithinRefundDeadline('invalid-date')).toBe(false);
+  });
+
+  it('should return true if current time is within the refund deadline (7 days before event)', () => {
+    const futureEventDate = addDays(new Date(), 10);
+    expect(isWithinRefundDeadline(futureEventDate.toISOString())).toBe(true);
+  });
+
+  it('should return false if current time is past the refund deadline (7 days before event)', () => {
+    const nearEventDate = addDays(new Date(), 3);
+    expect(isWithinRefundDeadline(nearEventDate.toISOString())).toBe(false);
+  });
+
+  it('should return false if event has already started', () => {
+    const pastEventDate = subDays(new Date(), 1);
+    expect(isWithinRefundDeadline(pastEventDate.toISOString())).toBe(false);
+  });
+
+  it('should return true on the boundary (exactly at midnight after deadline)', () => {
+    // Event is 8 days from now, deadline is 7 days before event
+    // So we're at exactly 1 day after deadline starts, should still be within
+    const futureEventDate = addDays(new Date(), 8);
+    expect(isWithinRefundDeadline(futureEventDate.toISOString())).toBe(true);
+  });
+
+  it('should handle edge case at exactly the deadline boundary', () => {
+    // Event is exactly 7 days from now
+    const exactDeadlineDate = addDays(new Date(), 7);
+    // At this point, we're at the deadline, but not past it yet
+    expect(isWithinRefundDeadline(exactDeadlineDate.toISOString())).toBe(true);
+  });
+});

src/domain/signup/permissions.ts

@@ -15,6 +15,7 @@ import {
   isRegistrationAdminUserInOrganization,
 } from '../organization/utils';
 import { SIGNUP_ACTIONS, SIGNUP_ICONS, SIGNUP_LABEL_KEYS } from './constants';
+import { isWithinRefundDeadline } from './refundDeadline';
 
 export const checkCanUserDoSignupAction = ({
   action,
@@ -61,13 +62,15 @@ export const checkCanUserDoSignupAction = ({
 export const getSignupActionWarning = ({
   action,
   authenticated,
+  registration,
   signup,
   signupGroup,
   t,
   userCanDoAction,
 }: {
   action: SIGNUP_ACTIONS;
   authenticated: boolean;
+  registration: RegistrationFieldsFragment;
   signup?: SignupFieldsFragment;
   signupGroup?: SignupGroupFieldsFragment;
   t: TFunction;
@@ -93,6 +96,22 @@ export const getSignupActionWarning = ({
     if (signup?.paymentRefund || signupGroup?.paymentRefund) {
       return t('signupsPage.warningHasPaymentRefund');
     }
+
+    const hasPaidSignup = Boolean(
+      signup?.priceGroup || signupGroup?.signups?.some((s) => s?.priceGroup)
+    );
+    const registrationHasPricing = registration.registrationPriceGroups?.some(
+      (pg) => pg?.price && parseFloat(pg.price) > 0
+    );
+    const eventStartTime = registration.event?.startTime;
+
+    if (
+      hasPaidSignup &&
+      registrationHasPricing &&
+      !isWithinRefundDeadline(eventStartTime)
+    ) {
+      return t('signupsPage.warningRefundDeadlinePassed');
+    }
   }
 
   return '';
@@ -127,6 +146,7 @@ export const checkIsSignupActionAllowed = ({
   const warning = getSignupActionWarning({
     action,
     authenticated,
+    registration,
     signup,
     signupGroup,
     t,

src/domain/signup/refundDeadline.ts

@@ -0,0 +1,26 @@
+import addDays from 'date-fns/addDays';
+import isBefore from 'date-fns/isBefore';
+import startOfDay from 'date-fns/startOfDay';
+
+import { WEB_STORE_REFUND_DEADLINE_DAYS } from '../../envVariables';
+
+export const isWithinRefundDeadline = (
+  eventStartTime: string | null | undefined
+): boolean => {
+  if (!eventStartTime) {
+    return false;
+  }
+
+  try {
+    const eventStartDate = new Date(eventStartTime);
+    const deadlineDate = addDays(
+      eventStartDate,
+      -WEB_STORE_REFUND_DEADLINE_DAYS
+    );
+    const nextDayAfterDeadline = startOfDay(addDays(deadlineDate, 1));
+
+    return isBefore(new Date(), nextDayAfterDeadline);
+  } catch {
+    return false;
+  }
+};

src/envVariables.ts

@@ -12,3 +12,9 @@ export const ALLOWED_SUBSTITUTE_USER_DOMAINS =
   import.meta.env.REACT_APP_ALLOWED_SUBSTITUTE_USER_DOMAINS?.split(',') ?? [
     'hel.fi',
   ];
+
+/* istanbul ignore next */
+export const WEB_STORE_REFUND_DEADLINE_DAYS = parseInt(
+  import.meta.env?.REACT_APP_WEB_STORE_REFUND_DEADLINE_DAYS ?? '7',
+  10
+);