refactor: update CORS variable naming

Refs: NS-192

Author: mhieta

notification_service/settings.py

@@ -23,8 +23,8 @@
 env = environ.Env(
     ALLOWED_HOSTS=(list, []),
     CACHE_URL=(str, "locmemcache://"),
-    CORS_ORIGIN_ALLOW_ALL=(bool, False),
-    CORS_ORIGIN_WHITELIST=(list, []),
+    CORS_ALLOW_ALL_ORIGINS=(bool, False),
+    CORS_ALLOWED_ORIGINS=(list, []),
     DATABASE_URL=(str, ""),
     DEBUG=(bool, False),
     DEFAULT_FROM_EMAIL=(str, "no-reply@hel.ninja"),
@@ -157,8 +157,8 @@
     }
 ]
 
-CORS_ALLOWED_ORIGINS = env.list("CORS_ORIGIN_WHITELIST")
-CORS_ORIGIN_ALLOW_ALL = env.bool("CORS_ORIGIN_ALLOW_ALL")
+CORS_ALLOWED_ORIGINS = env.list("CORS_ALLOWED_ORIGINS")
+CORS_ALLOW_ALL_ORIGINS = env.bool("CORS_ALLOW_ALL_ORIGINS")
 CORS_ALLOW_CREDENTIALS = True
 
 # Configure the default CSP rule for different source types

notification_service/tests/test_cors.py

@@ -7,7 +7,7 @@ def test_cors_allowed_origin(settings, live_server, client: Client):
     settings.CORS_ALLOWED_ORIGINS = [
         live_server.url,
     ]
-    settings.CORS_ORIGIN_ALLOW_ALL = False
+    settings.CORS_ALLOW_ALL_ORIGINS = False
     response = client.get("/admin/login/", HTTP_ORIGIN=live_server.url)
     assert response.status_code == 200
     assert response["Access-Control-Allow-Origin"] == live_server.url
@@ -16,7 +16,7 @@ def test_cors_allowed_origin(settings, live_server, client: Client):
 @pytest.mark.django_db
 def test_cors_disallowed_origin(settings, live_server, client: Client):
     settings.CORS_ALLOWED_ORIGINS = [live_server.url]
-    settings.CORS_ORIGIN_ALLOW_ALL = False
+    settings.CORS_ALLOW_ALL_ORIGINS = False
     response = client.get("/admin/login/", HTTP_ORIGIN="http://malicious.com")
     assert response.status_code == 200  # The request still succeeds...
     assert (