style: apply updated ruff and pre-commit rules

Refs: NS-193

Author: mhieta

.env.example

@@ -23,4 +23,4 @@ SENTRY_TRACES_SAMPLE_RATE=0.1
 ALLOWED_HOSTS=*
 
 AUDIT_LOG_ENABLED=1
-AUDIT_LOG_STORE_OBJECT_STATE=old-and-new
+AUDIT_LOG_STORE_OBJECT_STATE=old-and-new

.github/dependabot.yml

@@ -9,4 +9,4 @@ updates:
     # Disable version updates and only allow security updates
     open-pull-requests-limit: 0
       - "City-of-Helsinki/kuva-backend"
-      - "City-of-Helsinki/kuva-developers"
+      - "City-of-Helsinki/kuva-developers"

.gitignore

@@ -80,4 +80,4 @@ venv/
 .ruff_cache/
 docker-compose.env
 docker-compose.env.yaml
-.vscode/
+.vscode/

api/tests/test_api.py

@@ -13,7 +13,6 @@
 @pytest.fixture(autouse=True)
 def autouse_db(db):
     """Rename the db fixture"""
-    pass
 
 
 SMS_PAYLOAD: SendMessagePayload = {

api/tests/test_audit_log.py

@@ -161,9 +161,9 @@ def test_bulk_deleting_delivery_logs_writes_delete_log(admin_user):
     client = Client()
     client.force_login(admin_user)
 
-    COUNT = 3
+    count = 3
 
-    delivery_logs = DeliveryLogFactory.create_batch(COUNT)
+    delivery_logs = DeliveryLogFactory.create_batch(count)
     object_ids = [str(log.pk) for log in delivery_logs]
 
     # Get the URL for the changelist view
@@ -187,7 +187,7 @@ def test_bulk_deleting_delivery_logs_writes_delete_log(admin_user):
     audit_log_entry = qs.first()
 
     # Verify the audit log entry details
-    assert len(audit_log_entry.message["audit_event"]["target"]["object_ids"]) == COUNT
+    assert len(audit_log_entry.message["audit_event"]["target"]["object_ids"]) == count
     assert sorted(
         audit_log_entry.message["audit_event"]["target"]["object_ids"]
     ) == sorted(object_ids)

audit_log/exceptions.py

@@ -1,4 +1,2 @@
 class AuditLoggingDisabledError(Exception):
     """Raised when audit logging is disabled and an attempt is made to log an event."""
-
-    pass

common/tests/test_prune_django_admin_log.py

@@ -72,7 +72,7 @@ def test_valid_months(
     dry_run_msg = "Running in dry-run mode i.e. not committing changes!\n"
     del_msg = (
         f"Deleted {expected_deletion_count} Django admin logs "
-        f"created at least {5*12 if months is None else months} months ago"
+        f"created at least {5 * 12 if months is None else months} months ago"
     )
     assert captured.err == ""
     assert del_msg in captured.out

keycloak/realm.json

@@ -50,4 +50,4 @@
             ]
         }
     ]
-}
+}

openapi.yaml

@@ -181,4 +181,3 @@ components:
       in: header
       name: Authorization
       description: DRF TokenAuthentication. You need to generate an API token for each client.
-

pipelines/notification-service-api-review.yml

@@ -8,14 +8,14 @@
 trigger: none
 
 # Pull request (PR) triggers cause a pipeline to run whenever a pull request is
-# opened with one of the specified target branches, or when updates are made to 
+# opened with one of the specified target branches, or when updates are made to
 # such a pull request.
 #
-# GitHub creates a new ref when a pull request is created. The ref points to a 
-# merge commit, which is the merged code between the source and target branches 
+# GitHub creates a new ref when a pull request is created. The ref points to a
+# merge commit, which is the merged code between the source and target branches
 # of the pull request.
 #
-# Opt out of pull request validation 
+# Opt out of pull request validation
 pr:
   # PR target branch
   branches: