fix: fix SonarQube errors

Author: jorilindell

src/actions/index.ts

@@ -21,7 +21,7 @@ export const fetchResource = createAction(
   ActionTypes.GET_RESOURCE,
   ApiClient.fetchResource,
   (resourceType: string, filters?: any, include?: string[], embed?: string[], meta?: any) => {
-    return Object.assign({}, meta, { resourceType });
+    return { ...meta, resourceType };
   }
 );
 

src/actions/queueHandler.js

@@ -32,7 +32,7 @@ export default function queueHandler(store) {
       markAndSendObservation(store, item);
     });
 
-    const shouldRetryImmediately = ((opts && opts.initial === true) || store.getState().updateFlush);
+    const shouldRetryImmediately = ((opts?.initial === true) || store.getState().updateFlush);
     if (shouldRetryImmediately) {
       _.each(timers, (_, key) => {
         clearTimeout(key);

src/components/LoginScreen.js

@@ -34,11 +34,10 @@ class LoginScreen extends React.Component {
   }
   handleChange(field) {
     return (event) => {
-      this.setState(
-        Object.assign(
-          this.state,
-          {[field]: event.target.value}
-        ));
+      this.setState(prevState => ({
+        ...prevState,
+        [field]: event.target.value
+      }));
     };
   }
   render() {

src/components/NotFound.tsx

@@ -7,7 +7,7 @@ const NotFound: React.FC = () => {
       <div className="list-group facility-return clearfix">
         <Link to="/" className="list-group-item">
           <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-          Takaisin
+          {' '}Takaisin
         </Link>
       </div>
       <h4>404 - Sivua ei löytynyt</h4>

src/components/UnitDetails.tsx

@@ -30,7 +30,7 @@ interface ObservablePropertyPanelProps {
   header: string;
 }
 
-export function ObservableProperty({ quality, property, identifier, name, unitId }: ObservablePropertyProps): React.ReactElement {
+export function ObservableProperty({ quality, property, identifier, name, unitId }: Readonly<ObservablePropertyProps>): React.ReactElement {
   const url = `/unit/${unitId}/update/${property}/${identifier}`;
   const color = COLORS[quality] || 'primary';
   const icon = ICONS[identifier];
@@ -40,7 +40,7 @@ export function ObservableProperty({ quality, property, identifier, name, unitId
   return <Link to={url} className={buttonClassName}><span className={iconClassName}></span><br />{name.fi}</Link>;
 }
 
-export function ObservablePropertyPanel({ allowedValues, header }: ObservablePropertyPanelProps): React.ReactElement {
+export function ObservablePropertyPanel({ allowedValues, header }: Readonly<ObservablePropertyPanelProps>): React.ReactElement {
   const amountOfValues = allowedValues.length;
   const cutPoint = (amountOfValues / 2) + (amountOfValues % 2);
   const left = allowedValues.slice(0, cutPoint);
@@ -65,7 +65,7 @@ export function ObservablePropertyPanel({ allowedValues, header }: ObservablePro
 
 const UnitDetails: React.FC = () => {
   const params = useParams<{ unitId: string }>();
-  const unitId = params.unitId!;
+  const unitId = params.unitId;
 
   const unit = useSelector((state: RootState) => state.data.unit[unitId]);
   const isLoading = useSelector((state: RootState) => state.data.loading.unit === true);

src/components/UnitHistory.js

@@ -37,7 +37,7 @@ class UnitHistory extends React.Component {
           <div className="list-group facility-return clearfix">
             <Link to={`/unit/${unit.id}`} className="list-group-item">
               <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-                    Takaisin
+              {' '}Takaisin
             </Link>
           </div>
           <div className="well">

src/components/UnitList.tsx

@@ -11,7 +11,7 @@ interface UnitListElementProps {
   unit: Unit;
 }
 
-export function UnitListElement(props: UnitListElementProps): React.ReactElement {
+export function UnitListElement(props: Readonly<UnitListElementProps>): React.ReactElement {
   const { unit } = props;
   const url = `/unit/${unit.id}`;
   let iconClassName: string;
@@ -72,7 +72,7 @@ const UnitList: React.FC = () => {
         <div className="list-group facility-return">
           <Link to="/group" className="list-group-item">
             <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-            Takaisin
+            {' '}Takaisin
           </Link>
         </div>
         <h5>{name}</h5>

src/components/UnitMassEdit.js

@@ -76,10 +76,10 @@ const UnitMassEdit = (props) => {
     const isServiced = formValues.observationType === 'serviced';
     const notice = formValues.notice;
 
-    unitIds.map((unitId) => {
-      enqueueObservation(propertyId, value, parseInt(unitId), isServiced);
+    unitIds.forEach((unitId) => {
+      enqueueObservation(propertyId, value, Number.parseInt(unitId), isServiced);
       if (notice) {
-        enqueueObservation('notice', notice, parseInt(unitId));
+        enqueueObservation('notice', notice, Number.parseInt(unitId));
       }
     });
 
@@ -229,7 +229,7 @@ const UnitMassEdit = (props) => {
       <div className="list-group facility-return clearfix">
         <Link to={`/group/${groupId}/mass-edit`} className="list-group-item">
           <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-          Takaisin
+          {' '}Takaisin
         </Link>
       </div>
       <h4>Massapäivitys ({qualityHeader})</h4>
@@ -278,7 +278,7 @@ function mapStateToProps(state, ownProps) {
   let unitsIncludingSelectedProperty = [];
   let observableProperty;
 
-  units.map((u) => {
+  units.forEach((u) => {
     const allObservableProperties = unitObservableProperties(u, service, onlyQualityProperties);
     const selectedObservableProperty = _.filter(allObservableProperties, (op) => op.id === propertyId);
     const selectedObservablePropertyId = selectedObservableProperty[0]?.id;

src/components/UnitMassEditPropertySelect.js

@@ -24,7 +24,7 @@ class UnitMassEditPropertySelect extends React.Component {
         <div className="list-group facility-return clearfix">
           <Link to={`/group/${groupId}`} className="list-group-item">
             <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-            Takaisin
+            {' '}Takaisin
           </Link>
         </div>
         <div className="well">
@@ -52,12 +52,12 @@ function mapStateToProps(state, ownProps) {
   // Get all available properties
   const properties = units.reduce((result, currentUnit) => {
     const observableProperties = unitObservableProperties(currentUnit, service, onlyQualityProperties);
-    observableProperties.map((op) => {
+    observableProperties.forEach((op) => {
       // Remove duplicate observable properties
-      if (result.findIndex(res => res.id === op.id) === -1) {
+      if (!result.some(res => res.id === op.id)) {
         result.push(op);
       }
-    })
+    });
     return result;
   }, []);
 

src/components/UnitStatusSummary.tsx

@@ -10,7 +10,7 @@ interface UnitStatusSummaryProps {
   unit: Unit;
 }
 
-export default function UnitStatusSummary({ unit }: UnitStatusSummaryProps): React.ReactElement {
+export default function UnitStatusSummary({ unit }: Readonly<UnitStatusSummaryProps>): React.ReactElement {
   const observations = _.map(
     unit.observations,
     (obs) => <ObservationItem key={obs.id} observation={obs} />
@@ -24,7 +24,7 @@ export default function UnitStatusSummary({ unit }: UnitStatusSummaryProps): Rea
         <div className="list-group facility-return clearfix">
           <Link to="/" className="list-group-item">
             <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-                    Takaisin
+            {' '}Takaisin
           </Link>
         </div>
         <div className="well">