fix: fix SonarQube errors

Author: jorilindell

src/actions/index.ts

@@ -21,7 +21,7 @@ export const fetchResource = createAction(
   ActionTypes.GET_RESOURCE,
   ApiClient.fetchResource,
   (resourceType: string, filters?: any, include?: string[], embed?: string[], meta?: any) => {
-    return Object.assign({}, meta, { resourceType });
+    return { ...meta, resourceType };
   }
 );
 

src/actions/queueHandler.js

@@ -32,7 +32,7 @@ export default function queueHandler(store) {
       markAndSendObservation(store, item);
     });
 
-    const shouldRetryImmediately = ((opts && opts.initial === true) || store.getState().updateFlush);
+    const shouldRetryImmediately = ((opts?.initial === true) || store.getState().updateFlush);
     if (shouldRetryImmediately) {
       _.each(timers, (_, key) => {
         clearTimeout(key);

src/components/LoginScreen.js

@@ -34,11 +34,10 @@ class LoginScreen extends React.Component {
   }
   handleChange(field) {
     return (event) => {
-      this.setState(
-        Object.assign(
-          this.state,
-          {[field]: event.target.value}
-        ));
+      this.setState(prevState => ({
+        ...prevState,
+        [field]: event.target.value
+      }));
     };
   }
   render() {

src/components/NotFound.tsx

@@ -7,7 +7,7 @@ const NotFound: React.FC = () => {
       <div className="list-group facility-return clearfix">
         <Link to="/" className="list-group-item">
           <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-          Takaisin
+          {' '}Takaisin
         </Link>
       </div>
       <h4>404 - Sivua ei löytynyt</h4>

src/components/UnitDetails.tsx

@@ -30,7 +30,7 @@ interface ObservablePropertyPanelProps {
   header: string;
 }
 
-export function ObservableProperty({ quality, property, identifier, name, unitId }: ObservablePropertyProps): React.ReactElement {
+export function ObservableProperty({ quality, property, identifier, name, unitId }: Readonly<ObservablePropertyProps>): React.ReactElement {
   const url = `/unit/${unitId}/update/${property}/${identifier}`;
   const color = COLORS[quality] || 'primary';
   const icon = ICONS[identifier];
@@ -40,7 +40,7 @@ export function ObservableProperty({ quality, property, identifier, name, unitId
   return <Link to={url} className={buttonClassName}><span className={iconClassName}></span><br />{name.fi}</Link>;
 }
 
-export function ObservablePropertyPanel({ allowedValues, header }: ObservablePropertyPanelProps): React.ReactElement {
+export function ObservablePropertyPanel({ allowedValues, header }: Readonly<ObservablePropertyPanelProps>): React.ReactElement {
   const amountOfValues = allowedValues.length;
   const cutPoint = (amountOfValues / 2) + (amountOfValues % 2);
   const left = allowedValues.slice(0, cutPoint);
@@ -65,7 +65,7 @@ export function ObservablePropertyPanel({ allowedValues, header }: ObservablePro
 
 const UnitDetails: React.FC = () => {
   const params = useParams<{ unitId: string }>();
-  const unitId = params.unitId!;
+  const unitId = params.unitId;
 
   const unit = useSelector((state: RootState) => state.data.unit[unitId]);
   const isLoading = useSelector((state: RootState) => state.data.loading.unit === true);

src/components/UnitHistory.js

@@ -37,7 +37,7 @@ class UnitHistory extends React.Component {
           <div className="list-group facility-return clearfix">
             <Link to={`/unit/${unit.id}`} className="list-group-item">
               <span className="action-icon glyphicon glyphicon-chevron-left"></span>
-                    Takaisin
+              {' '}Takaisin
             </Link>
           </div>
           <div className="well">

src/components/UnitList.tsx

@@ -11,7 +11,7 @@ interface UnitListElementProps {
   unit: Unit;
 }
 
-export function UnitListElement(props: UnitListElementProps): React.ReactElement {
+export function UnitListElement(props: Readonly<UnitListElementProps>): React.ReactElement {
   const { unit } = props;
   const url = `/unit/${unit.id}`;
   let iconClassName: string;

src/util/error.js

@@ -2,7 +2,7 @@
 export function CredentialError(message) {
   this.name = 'CredentialError';
   this.message = message;
-  this.stack = (new Error()).stack;
+  this.stack = (new Error(message)).stack;
 }
 
-CredentialError.prototype = new Error;
+CredentialError.prototype = new Error('CredentialError');

src/util/time.js

@@ -26,7 +26,7 @@ export function minutesToHours (minutes) {
 
 export function hoursToMinutes (hours) {
   if (typeof hours !== 'number') {
-    hours = parseFloat(hours);
+    hours = Number.parseFloat(hours);
   }
   return Math.floor(hours * 60);
 }
@@ -36,19 +36,18 @@ export function formatHours (hours) {
   const fract = hours % 1;
   let fractString;
   switch (fract) {
-    case 0.75: fractString = String.fromCharCode(190); break;
-    case 0.5: fractString = String.fromCharCode(189); break;
-    case 0.25: fractString = String.fromCharCode(188); break;
+    case 0.75: fractString = String.fromCodePoint(190); break;
+    case 0.5: fractString = String.fromCodePoint(189); break;
+    case 0.25: fractString = String.fromCodePoint(188); break;
     case 0: fractString = ''; break;
     default: return hours;
   }
   return `${full}${fractString}`;
 }
 
 
-export function round (floatVal, stepOption) {
-  const step = (stepOption || 0.25);
-  if (1 % step != 0) {
+export function round (floatVal, stepOption = 0.25) {
+  if (1 % stepOption != 0) {
     return floatVal;
   }
 
@@ -57,10 +56,10 @@ export function round (floatVal, stepOption) {
   const fract = num - whole;
 
   let returnValue = null;
-  const steps = _.range(step/2, 1, step);
+  const steps = _.range(stepOption/2, 1, stepOption);
   for (let i = 0; i < steps.length; i++) {
     if (fract < steps[i]) {
-      returnValue = whole + step * i;
+      returnValue = whole + stepOption * i;
       break;
     }
   }