Remove ApplicationSectionStatusChoice FAILED and RESERVED statuses

Author: ranta

applications/admin/forms/application_section.py

@@ -29,15 +29,11 @@ class ApplicationSectionAdminForm(forms.ModelForm):
             "%(in_allocation)s: Application round has closed, but the section is not fully allocated. <br>"
             "%(handled)s: Application round is no longer in allocation, section's applied reservations "
             "per week has been fulfilled, or all reservation unit options rejected or locked. <br>"
-            "%(failed)s: At least one reservation was not possible for some allocation. <br>"
-            "%(reserved)s: All allocations have successful reservations. <br>"
         )
         % {
             "unallocated": ApplicationSectionStatusChoice.UNALLOCATED.label,
             "in_allocation": ApplicationSectionStatusChoice.IN_ALLOCATION.label,
             "handled": ApplicationSectionStatusChoice.HANDLED.label,
-            "failed": ApplicationSectionStatusChoice.FAILED.label,
-            "reserved": ApplicationSectionStatusChoice.RESERVED.label,
         },
     )
 

applications/choices.py

@@ -252,12 +252,6 @@ class ApplicationSectionStatusChoice(models.TextChoices):
     HANDLED = "HANDLED", _("Handled")
     """Application section has been handled fully in the allocation process"""
 
-    RESERVED = "RESERVED", _("Reserved")
-    """All reservations for the application section have been created successfully"""
-
-    FAILED = "FAILED", _("Failed")
-    """Some or all reservations for the application section could not be created successfully"""
-
     @DynamicClassAttribute
     def can_allocate(self) -> bool:
         return self in [

applications/models/application_section.py

@@ -251,14 +251,6 @@ def status_sort_order() -> int:
                 models.Q(L(status=ApplicationSectionStatusChoice.HANDLED.value)),
                 then=models.Value(3),
             ),
-            models.When(
-                models.Q(L(status=ApplicationSectionStatusChoice.FAILED.value)),
-                then=models.Value(4),
-            ),
-            models.When(
-                models.Q(L(status=ApplicationSectionStatusChoice.RESERVED.value)),
-                then=models.Value(5),
-            ),
             default=models.Value(6),
             output_field=models.IntegerField(),
         )

tests/test_factories/test_application_section.py

@@ -15,8 +15,6 @@
         ApplicationSectionStatusChoice.UNALLOCATED,
         ApplicationSectionStatusChoice.IN_ALLOCATION,
         ApplicationSectionStatusChoice.HANDLED,
-        # TODO: ApplicationSectionStatusChoice.RESERVED,
-        # TODO: ApplicationSectionStatusChoice.FAILED,
     ],
 )
 def test_application_section_factory_create_in_status(status):

tests/test_graphql_api/test_application_section/test_delete.py

@@ -16,9 +16,6 @@
     [
         ApplicationSectionStatusChoice.IN_ALLOCATION,
         ApplicationSectionStatusChoice.HANDLED,
-        # TODO: Later when the feature is implemented:
-        #  ApplicationSectionStatusChoice.RESERVED,
-        #  ApplicationSectionStatusChoice.FAILED,
     ],
 )
 def test_cannot_delete_application_event_not_unallocated(graphql, status):