Update fields explicitly in verkkokauppa webhooks and background tasks

This is to avoid race conditions between the two so that states
for example end up in the correct state.

Author: matti-lamppu

api/webhooks/views.py

@@ -65,12 +65,12 @@ def create(self, request: Request, *args: Any, **kwargs: Any) -> Response:
         payment_order.status = OrderStatus.PAID
         payment_order.payment_id = payment_id
         payment_order.processed_at = local_datetime()
-        payment_order.save()
+        payment_order.save(update_fields=["status", "payment_id", "processed_at"])
 
         reservation: Reservation | None = payment_order.reservation
         if reservation is not None and reservation.state == ReservationStateChoice.WAITING_FOR_PAYMENT:
             reservation.state = ReservationStateChoice.CONFIRMED
-            reservation.save()
+            reservation.save(update_fields=["state"])
             ReservationEmailNotificationSender.send_confirmation_email(reservation=reservation)
 
         return Response(data={"message": "Order payment completed successfully"}, status=200)
@@ -116,7 +116,7 @@ def create(self, request: Request, *args: Any, **kwargs: Any) -> Response:
 
         payment_order.status = OrderStatus.CANCELLED
         payment_order.processed_at = local_datetime()
-        payment_order.save()
+        payment_order.save(update_fields=["status", "processed_at"])
 
         return Response(data={"message": "Order cancellation completed successfully"}, status=200)
 
@@ -168,6 +168,6 @@ def create(self, request: Request, *args: Any, **kwargs: Any) -> Response:
         payment_order.refund_id = refund_id
         payment_order.status = OrderStatus.REFUNDED
         payment_order.processed_at = local_datetime()
-        payment_order.save()
+        payment_order.save(update_fields=["refund_id", "status", "processed_at"])
 
         return Response(data={"message": "Order refund completed successfully"}, status=200)

merchants/pruning.py

@@ -46,13 +46,13 @@ def update_expired_orders() -> None:
                 VerkkokauppaAPIClient.cancel_order(order_uuid=order.remote_id, user_uuid=order.reservation_user_uuid)
 
             order.processed_at = local_datetime()
-            order.save()
+            order.save(update_fields=["status", "processed_at"])
 
             # Confirm the reservation and send confirmation email
             reservation: Reservation = order.reservation
             if order.status == OrderStatus.PAID and reservation.state == ReservationStateChoice.WAITING_FOR_PAYMENT:
                 reservation.state = ReservationStateChoice.CONFIRMED
-                reservation.save()
+                reservation.save(update_fields=["state"])
                 ReservationEmailNotificationSender.send_confirmation_email(reservation=reservation)
 
         except GetPaymentError as err:

reservations/tasks.py

@@ -54,7 +54,7 @@ def refund_paid_reservation_task(reservation_pk: int) -> None:
     if not settings.MOCK_VERKKOKAUPPA_API_ENABLED:
         refund = VerkkokauppaAPIClient.refund_order(order_uuid=payment_order.remote_id)
         payment_order.refund_id = refund.refund_id
-        payment_order.save()
+        payment_order.save(update_fields=["refund_id"])
     else:
         payment_order.refund_id = uuid.uuid4()
-        payment_order.save()
+        payment_order.save(update_fields=["refund_id"])