Fix ReservationUnits in common hierarchy by Resource but unrelated Space

- This bug was discovered in manual testing.

Author: ranta

reservations/querysets.py

@@ -121,6 +121,10 @@ def get_affecting_reservations_as_closed_time_spans(
                 # Get the full family of the space.
                 family: set[SpacePK] = space_to_family.get(space_id)
 
+                # Space is not related in common hierarchy with any of the reservation units, skip it.
+                if family is None:
+                    continue
+
                 for reservation_unit_info in reservation_unit_infos:
                     # If any space from the family is a direct space on the reservation unit,
                     # add a timespan from the reservation to the reservation unit, but only once.

tests/test_graphql_api/test_reservation_unit/test_query_reservable_fields.py

@@ -1069,6 +1069,58 @@ def test__query_reservation_unit_reservable__reservations__in_common_hierarchy__
     }
 
 
+@freezegun.freeze_time(NOW)
+def test__query_reservation_unit_reservable__reservations__in_common_hierarchy__by_resource__additional_filters(
+    graphql, reservation_unit
+):
+    """
+    This is a regression test for a bug that was found during manual testing.
+    Simply recreate the exact scenario instead of using the above test cases.
+
+    The error occurred when the ReservationUnit GQL query had additional filters that filtered out ReservationUnits
+    which were related in common hierarchy by Resource and had a Space which was not related in common hierarcy.
+    """
+    common_resource = ResourceFactory()
+    reservation_unit_2: ReservationUnit = ReservationUnitFactory.create(
+        resources=[common_resource],
+        spaces=[SpaceFactory()],
+        origin_hauki_resource=reservation_unit.origin_hauki_resource,
+    )
+    reservation_unit.resources.set([common_resource])
+    reservation_unit.spaces.set([SpaceFactory()])
+    reservation_unit.save()
+
+    # 2023-05-20 10:00 - 12:00 (2h)
+    ReservationFactory.create(
+        begin=_datetime(day=20, hour=10),
+        end=_datetime(day=20, hour=12),
+        reservation_unit=[reservation_unit_2],
+        state=ReservationStateChoice.CREATED,
+    )
+
+    # 2023-05-20 10:00 - 12:00 (2h)
+    ReservableTimeSpanFactory.create(
+        resource=reservation_unit.origin_hauki_resource,
+        start_datetime=_datetime(day=20, hour=10),
+        end_datetime=_datetime(day=20, hour=12),
+    )
+
+    response = graphql(
+        reservation_units_reservable_query(
+            pk=reservation_unit.pk,
+            fields="pk isClosed firstReservableDatetime",
+        )
+    )
+
+    assert response.has_errors is False, response
+    assert len(response.edges) == 1, response
+    assert response.node(0) == {
+        "pk": reservation_unit.pk,
+        "isClosed": False,
+        "firstReservableDatetime": None,
+    }
+
+
 ########################################################################################################################