ruff: Automatic fixes from flake8-annotations ruleset

- Do not enable the ruleset yet, just have fix everything that it can fix automatically.

Author: ranta

actions/recurring_reservation.py

@@ -107,7 +107,7 @@ class ReservationDetails(TypedDict, total=False):
 
 
 class RecurringReservationActions:
-    def __init__(self, recurring_reservation: RecurringReservation):
+    def __init__(self, recurring_reservation: RecurringReservation) -> None:
         self.recurring_reservation = recurring_reservation
 
     def pre_calculate_slots(

actions/reservation.py

@@ -9,7 +9,7 @@
 
 
 class ReservationActions:
-    def __init__(self, reservation: Reservation):
+    def __init__(self, reservation: Reservation) -> None:
         self.reservation = reservation
 
     def get_actual_before_buffer(self) -> datetime.timedelta:

actions/reservation_unit.py

@@ -106,7 +106,7 @@ def _get_parent_resource_id(self) -> int | None:
         except (ExternalServiceError, KeyError, IndexError, TypeError):
             return None
 
-    def _create_hauki_resource(self, hauki_resource_data):
+    def _create_hauki_resource(self, hauki_resource_data) -> None:
         """Create a new HaukiResource in Hauki API for the ReservationUnit."""
         # New Hauki Resource, create it in Hauki API and update the reservation unit
         response_data: HaukiAPIResource = HaukiAPIClient.create_resource(data=hauki_resource_data)
@@ -117,7 +117,7 @@ def _create_hauki_resource(self, hauki_resource_data):
         self.reservation_unit.origin_hauki_resource = origin_hauki_resource
         self.reservation_unit.save()
 
-    def _update_hauki_resource(self, hauki_resource_data):
+    def _update_hauki_resource(self, hauki_resource_data) -> None:
         """Update the Hauki Resource in Hauki API with ReservationUnits data."""
         hauki_resource_data["id"] = self.reservation_unit.origin_hauki_resource.id
 
@@ -126,7 +126,7 @@ def _update_hauki_resource(self, hauki_resource_data):
 
 
 class ReservationUnitActions(ReservationUnitHaukiExporter):
-    def __init__(self, reservation_unit: ReservationUnit):
+    def __init__(self, reservation_unit: ReservationUnit) -> None:
         self.reservation_unit = reservation_unit
 
     def get_actual_before_buffer(

api/graphql/extensions/fields.py

@@ -63,7 +63,7 @@ class ValidatingListField(serializers.ListField):
     before default implementation and provides better error messages
     """
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
 
     def run_child_validation(self, data):
@@ -84,7 +84,7 @@ class OldChoiceValidator:
     message = _('Choice "%(choice)s" is not allowed. Allowed choices are: %(allowed_choices)s.')
     code = "invalid_choice"
 
-    def __init__(self, allowed_choices):
+    def __init__(self, allowed_choices) -> None:
         if len(allowed_choices) > 0 and isinstance(allowed_choices[0][0], int):
             self.allowed_choices = [choice[0] for choice in allowed_choices]
         else:
@@ -107,7 +107,7 @@ def __call__(self, value):
 
 
 class OldChoiceCharField(serializers.CharField):
-    def __init__(self, choices, **kwargs):
+    def __init__(self, choices, **kwargs) -> None:
         super().__init__(**kwargs)
         choice_validator = OldChoiceValidator(choices)
         self.validators.append(choice_validator)
@@ -127,7 +127,7 @@ def get_attribute(self, instance):
 class OldChoiceIntegerField(serializers.IntegerField):
     choices = None
 
-    def __init__(self, choices, **kwargs):
+    def __init__(self, choices, **kwargs) -> None:
         super().__init__(**kwargs)
         choice_validator = OldChoiceValidator(choices)
         self.validators.append(choice_validator)

api/graphql/extensions/serializers.py

@@ -5,7 +5,7 @@
 
 
 class OldPrimaryKeySerializerBase(serializers.ModelSerializer):
-    def _check_id_list(self, id_list, field_name):
+    def _check_id_list(self, id_list, field_name) -> None:
         for identifier in id_list:
             try:
                 int(identifier)

api/graphql/types/reservation/mutations.py

@@ -139,7 +139,7 @@ class Meta:
         permission_classes = [ReservationPermission]
 
     @classmethod
-    def validate_deletion(cls, instance: Reservation, user: AnyUser):
+    def validate_deletion(cls, instance: Reservation, user: AnyUser) -> None:
         if instance.state not in (
             ReservationStateChoice.CREATED.value,
             ReservationStateChoice.WAITING_FOR_PAYMENT.value,

api/graphql/types/reservation/serializers/adjust_time_serializers.py

@@ -26,7 +26,7 @@ class Meta:
             "state",
         ]
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         self.fields["state"].readonly = True
 
@@ -84,7 +84,7 @@ def validate(self, data):
 
         return data
 
-    def check_begin(self, begin, end):
+    def check_begin(self, begin, end) -> None:
         if begin > end:
             raise ValidationErrorWithCode(
                 "End cannot be before begin",
@@ -126,7 +126,7 @@ def check_cancellation_rules(self, reservation_unit: ReservationUnit) -> None:
                 ValidationErrorCodes.CANCELLATION_NOT_ALLOWED,
             )
 
-    def check_and_handle_pricing(self, data):
+    def check_and_handle_pricing(self, data) -> None:
         if self.instance.price_net > 0:
             raise ValidationErrorWithCode(
                 "Reservation time cannot be changed due to its price",

api/graphql/types/reservation/serializers/confirm_serializers.py

@@ -34,7 +34,7 @@ class ReservationConfirmSerializer(ReservationUpdateSerializer):
         ),
     )
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         # All fields should be read-only, except for the lookup
         # field (PK) which should be included in the input

api/graphql/types/reservation/serializers/create_serializers.py

@@ -97,7 +97,7 @@ class Meta:
             "type",
         ]
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         self.fields["state"].read_only = True
         self.fields["reservation_unit_pks"].write_only = True
@@ -237,7 +237,7 @@ def _prefill_reservation_from_profile(self, data: dict[str, Any]) -> None:
                 if value is not None:
                     data[key] = value
 
-    def check_sku(self, current_sku, new_sku):
+    def check_sku(self, current_sku, new_sku) -> None:
         if current_sku is not None and current_sku != new_sku:
             raise ValidationErrorWithCode(
                 "An ambiguous SKU cannot be assigned for this reservation.",
@@ -261,14 +261,14 @@ def check_max_reservations_per_user(self, user: AnyUser, reservation_unit: Reser
                 ValidationErrorCodes.MAX_NUMBER_OF_ACTIVE_RESERVATIONS_EXCEEDED,
             )
 
-    def check_reservation_kind(self, reservation_unit):
+    def check_reservation_kind(self, reservation_unit) -> None:
         if reservation_unit.reservation_kind == ReservationKind.SEASON:
             raise ValidationErrorWithCode(
                 "Reservation unit is only available or seasonal booking.",
                 ValidationErrorCodes.RESERVATION_UNIT_TYPE_IS_SEASON,
             )
 
-    def check_reservation_type(self, user, reservation_unit_ids: list[int], reservation_type: str | None):
+    def check_reservation_type(self, user, reservation_unit_ids: list[int], reservation_type: str | None) -> None:
         if reservation_type is None or can_handle_reservation_with_units(user, reservation_unit_ids):
             return
 

api/graphql/types/reservation/serializers/memo_serializers.py

@@ -7,6 +7,6 @@ class Meta:
         model = Reservation
         fields = ["pk", "working_memo"]
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         self.fields["pk"].help_text = "Primary key of the reservation"