Skip to content

Commit cf7e31d

Browse files
committed
Simplify application section queryset methods
1 parent e1baca6 commit cf7e31d

1 file changed

Lines changed: 9 additions & 17 deletions

File tree

applications/querysets/application_section.py

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,29 @@
1-
from datetime import timedelta
2-
from typing import Literal, Self, TypedDict
1+
from typing import Literal, Self
32

43
from django.db import models
54
from django.db.models import Subquery
65
from lookup_property import L
76

8-
9-
class AggregateSectionData(TypedDict):
10-
event_duration: timedelta
11-
min_duration: timedelta
7+
__all__ = [
8+
"ApplicationSectionQuerySet",
9+
]
1210

1311

1412
class ApplicationSectionQuerySet(models.QuerySet):
1513
def has_status_in(self, statuses: list[str]) -> Self:
16-
return self.alias(status=L("status")).filter(status__in=statuses)
14+
return self.filter(L(status__in=statuses))
1715

1816
def has_application_status_in(self, statuses: list[str]) -> Self:
19-
return self.alias(application_status=L("application__status")).filter(application_status__in=statuses)
17+
return self.filter(L(application__status__in=statuses))
2018

2119
def order_by_status(self, *, desc: bool = False) -> Self:
22-
return self.alias(status_sort_order=L("status_sort_order")).order_by(
23-
models.OrderBy(models.F("status_sort_order"), descending=desc),
24-
)
20+
return self.order_by(L("status_sort_order").order_by(descending=desc))
2521

2622
def order_by_application_status(self, *, desc: bool = False) -> Self:
27-
return self.alias(application_status_sort_order=L("application__status_sort_order")).order_by(
28-
models.OrderBy(models.F("application_status_sort_order"), descending=desc),
29-
)
23+
return self.order_by(L("application__status_sort_order").order_by(descending=desc))
3024

3125
def order_by_applicant(self, *, desc: bool = False) -> Self:
32-
return self.alias(applicant=L("application__applicant")).order_by(
33-
models.OrderBy(models.F("applicant"), descending=desc),
34-
)
26+
return self.order_by(L("application__applicant").order_by(descending=desc))
3527

3628
def preferred_unit_name_alias(self, *, lang: Literal["fi", "en", "sv"]) -> Self:
3729
from applications.models import ReservationUnitOption

0 commit comments

Comments
 (0)