update: gql types after unused model removal

Author: joonatank

apps/admin-ui/gql/gql-types.ts

@@ -35,7 +35,6 @@ function createMockReservationUnit({
   reservationsMinDaysBefore,
   reservationEnds,
   canBeCancelledTimeBefore,
-  needsHandling,
 }: {
   reservationsMinDaysBefore?: number;
   reservationEnds?: Date;
@@ -46,7 +45,6 @@ function createMockReservationUnit({
     canBeCancelledTimeBefore: canBeCancelledTimeBefore ?? 0,
     id: "fr8ejifod",
     name: "Cancellation rule",
-    needsHandling: needsHandling ?? false,
   };
   return {
     authentication: Authentication.Weak,
@@ -85,7 +83,6 @@ function createMockReservationUnit({
     qualifiers: [],
     equipments: [],
     resources: [],
-    services: [],
     spaces: [],
     cancellationRule,
     reservations: [],
@@ -256,20 +253,17 @@ describe("isReservationCancellable", () => {
   function constructInput({
     begin,
     state,
-    needsHandling,
     canBeCancelledTimeBefore,
   }: {
     begin: Date; // reservation begin time
     state?: ReservationStateChoice; // reservation state
-    needsHandling?: boolean; // if the reservation unit needs handling
     canBeCancelledTimeBefore?: number; // in seconds
   }) {
     return {
       ...createMockReservation({
         begin,
         state: state ?? ReservationStateChoice.Confirmed,
         reservationUnit: createMockReservationUnit({
-          needsHandling: needsHandling ?? false,
           canBeCancelledTimeBefore: canBeCancelledTimeBefore ?? 0,
         }),
       }),
@@ -308,14 +302,6 @@ describe("isReservationCancellable", () => {
     expect(isReservationCancellable(input)).toBe(false);
   });
 
-  test("NO for reservation unit that needs handling", () => {
-    const input = constructInput({
-      begin: addDays(new Date(), 1),
-      needsHandling: true,
-    });
-    expect(isReservationCancellable(input)).toBe(false);
-  });
-
   test("YES for reservation that does not need handling", () => {
     const input = constructInput({
       begin: addDays(new Date(), 1),

apps/ui/gql/gql-types.ts

@@ -1035,7 +1035,6 @@ describe("isReservationUnitReservable", () => {
       reservationPendingInstructions: "",
       reservationStartInterval: ReservationStartInterval.Interval_15Mins,
       resources: [],
-      services: [],
       spaces: [],
       maxPersons: 10,
       uuid: "be4fa7a2-05b7-11ee-be56-0242ac120004",

apps/ui/modules/__tests__/reservation.test.ts

@@ -62,7 +62,6 @@ const CANCELLATION_RULE_FRAGMENT = gql`
     cancellationRule {
       id
       canBeCancelledTimeBefore
-      needsHandling
     }
   }
 `;

apps/ui/modules/__tests__/reservationUnit.test.ts

@@ -158,8 +158,6 @@ export function isReservationCancellable(
   // TODO why can't user cancel if the reservation is waiting for handling?
   if (reservation.state !== ReservationStateChoice.Confirmed) return false;
   if (reservationUnit.cancellationRule == null) return false;
-  // TODO why isn't the user allowed to cancel if the reservation has been handled?
-  if (reservationUnit.cancellationRule.needsHandling) return false;
   if (isTooCloseToCancel(reservation)) {
     return false;
   }
@@ -276,10 +274,7 @@ export function getWhyReservationCantBeChanged(
   }
 
   const reservationUnit = reservation.reservationUnits?.[0];
-  if (
-    reservationUnit?.cancellationRule == null ||
-    reservationUnit.cancellationRule.needsHandling
-  ) {
+  if (reservationUnit?.cancellationRule == null) {
     return "CANCELLATION_NOT_ALLOWED";
   }