Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Commit b18a7af

Browse files
TILA-1848 and TILA-2148 Translations missing (#566)
* TILA-2184/1848 Translations missing Added inclTax swedish translation * Update common.json Added inclTax traslation * Update home.json Added translations * Update home.json Added translations * Update dateSelector.json Added translations * Update dateSelector.json Updated translations * Update errors.json Modified error messages * Update errors.json Added swedish translations * Update errors.json Added english translations * Update reservationApplication.json Modified content in labels * Update reservationApplication.json Added swedish translations * Update reservationApplication.json Added missing comma * Update reservationApplication.json Added english translations * Update reservationCalendar.json Modified content on some labels. * Update reservationCalendar.json Added swedish translations * Update reservationCalendar.json Added english translations * Update reservations.json Modified some label contents * Update reservations.json Added swedish translations * Update reservations.json Added english translations * Update reservationUnit.json Modified label's contents * Update reservationUnit.json Added swedish translations * Update reservationUnit.json Added tag "reservationInfo2" * Update reservationUnit.json Added tag "reservationInfo2" * Update reservationUnit.json Added english translations * TILA-1848 cleanup t10n * TILA-1840 reflect copy changes to tests * TILA-1848 cleanup --------- Co-authored-by: Mikko Sartanen <sartanen@gmail.com>
1 parent 7e29745 commit b18a7af

24 files changed

Lines changed: 705 additions & 660 deletions

ui/components/reservation/__tests__/ReservationOrderStatus.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const renderComponent = (props?: Partial<Props>) =>
3535
{ status: "PAID_MANUALLY", label: "Paikan päällä" },
3636
{ status: "CANCELLED", label: "Peruttu" },
3737
{ status: "EXPIRED", label: "Maksamatta" },
38-
{ status: "REFUNDED", label: "Palautettu" },
38+
{ status: "REFUNDED", label: "Hyvitetty" },
3939
].forEach((state) => {
4040
test(`should render ${state.status}`, () => {
4141
renderComponent({ orderStatus: state.status });

ui/cypress/e2e/reservation-unit.cy.ts

Lines changed: 30 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,10 @@ const matchEvent = (): void => {
7979
});
8080
};
8181

82-
const reservationEnds = (date: Date) =>
83-
format(addDays(date, 10), "d.M.yyyy 'klo' H.mm");
82+
const reservationEnds = (date: Date, justDate = false) => {
83+
const fmt = justDate ? "d.M.yyyy" : "d.M.yyyy 'klo' H.mm";
84+
return format(addDays(date, 10), fmt);
85+
};
8486

8587
const drawReservation = (): void => {
8688
hzNavigationFwd().click();
@@ -353,18 +355,18 @@ describe("renders with basic data", () => {
353355
"Voit tehdä varauksen aikaisintaan 12 kuukautta ja viimeistään 2 päivää etukäteen."
354356
);
355357
reservationInfo().contains(
356-
`Varauskalenteri on auki ${reservationEnds(new Date())} asti.`
358+
`Tämä kohde on varattavissa ${reservationEnds(new Date(), true)}`
357359
);
358360
reservationInfo().contains(
359-
"Varauksen keston tulee olla välillä 1 tunti ja 1 tunti 30 minuuttia."
361+
"Varauksen keston tulee olla välillä 1 tunti - 1 tunti 30 minuuttia."
360362
);
361363
reservationInfo().contains(
362364
"Sinulla voi olla samanaikaisesti enintään yksi varaus."
363365
);
364366

365367
reservationNotice().click();
366368
reservationNotice().contains(
367-
`Huomioi hinnoittelumuutos ${toUIDate(addDays(new Date(), 2))} alkaen.`
369+
`Tämän kohteen hinta muuttuu ${toUIDate(addDays(new Date(), 2))} alkaen.`
368370
);
369371
reservationNotice().contains(
370372
"Uusi hinta on 10,00 - 30,00 € / 15 min (sis. alv. 20%)"
@@ -394,7 +396,7 @@ describe("has pricing terms modal", () => {
394396

395397
pricingTermsLink("reservation-unit-head").click();
396398

397-
pricingTermsDialog().should("contain.text", "Hinnoitteluperiaatteet");
399+
pricingTermsDialog().should("contain.text", "Alennusryhmät");
398400
pricingTermsDialog().should("contain.text", "Hinnoitteluehdot body Fi");
399401

400402
pricingTermsDialog().find("button").click();
@@ -450,7 +452,7 @@ describe("quick reservation", () => {
450452

451453
pricingTermsLink("quick-reservation").click();
452454

453-
pricingTermsDialog().should("contain.text", "Hinnoitteluperiaatteet");
455+
pricingTermsDialog().should("contain.text", "Alennusryhmät");
454456
pricingTermsDialog().should("contain.text", "Hinnoitteluehdot body Fi");
455457

456458
pricingTermsDialog().find("button").click();
@@ -500,7 +502,7 @@ describe("with payment terms", () => {
500502
paymentAndCancellationTerms().contains("Maksuehdot Fi");
501503
paymentAndCancellationTerms().contains("Peruutusehdot Fi");
502504

503-
pricingTerms().find("> button").contains("Hinnoitteluperiaatteet");
505+
pricingTerms().find("> button").contains("Alennusryhmät");
504506
pricingTerms().contains("Hinnoitteluehdot Fi");
505507
});
506508
});
@@ -516,7 +518,10 @@ describe("with reservation times", () => {
516518
calendarWrapper().should("not.exist");
517519
reservationControls().should("not.exist");
518520

519-
reservationStartNotification().should("contain", "Varauskalenteri avautuu");
521+
reservationStartNotification().should(
522+
"contain",
523+
"Voit tehdä varauksen tähän kohteeseen"
524+
);
520525
});
521526
});
522527

@@ -535,12 +540,10 @@ describe("with reservation quota notification", () => {
535540

536541
reservationSubmitButton().should("not.exist");
537542

538-
reservationQuotaNotification()
539-
.invoke("text")
540-
.should(
541-
"match",
542-
/^Sinulla on jo \d+ varausta tähän tilaan. Et voi tehdä uusia varauksia.$/
543-
);
543+
reservationQuotaNotification().should(
544+
"contain.text",
545+
"Et voi tehdä uusia varauksia."
546+
);
544547

545548
reservationInfo().contains(
546549
"Sinulla voi olla samanaikaisesti enintään 10 varausta."
@@ -565,7 +568,7 @@ describe("with reservation quota notification", () => {
565568

566569
reservationQuotaNotification()
567570
.invoke("text")
568-
.should("match", /^Sinulla on jo \d+\/\d+ varausta tähän tilaan.$/);
571+
.should("match", /^Sinulla on \d+\/\d+ varausta tähän kohteeseen.$/);
569572

570573
reservationInfo().contains(
571574
"Sinulla voi olla samanaikaisesti enintään 30 varausta."
@@ -687,7 +690,7 @@ describe("with metadataset", () => {
687690
);
688691
cy.get("main#main").should(
689692
"contain.text",
690-
"Haen maksuttomuutta tai hinnan alennusta ja olen tutustunut alennusperusteisiin"
693+
"Haen maksutonta käyttöä tai hinnan alennusta ja olen tutustunut alennusryhmiin."
691694
);
692695

693696
cy.get('button[type="submit"]').click();
@@ -696,7 +699,10 @@ describe("with metadataset", () => {
696699
"contain.text",
697700
"Varauksen päivitys epäonnistui"
698701
);
699-
errorNotificationBody().should("contain.text", "Hyväksy ehdot jatkaaksesi");
702+
errorNotificationBody().should(
703+
"contain.text",
704+
"Hyväksy sopimusehdot jatkaaksesi varausta."
705+
);
700706
errorNotificationCloseButton().click();
701707

702708
cy.get("#generic-and-service-specific-terms-terms-accepted").click();
@@ -707,7 +713,10 @@ describe("with metadataset", () => {
707713
"contain.text",
708714
"Varauksen päivitys epäonnistui"
709715
);
710-
errorNotificationBody().should("contain.text", "Hyväksy ehdot jatkaaksesi");
716+
errorNotificationBody().should(
717+
"contain.text",
718+
"Hyväksy sopimusehdot jatkaaksesi varausta."
719+
);
711720
errorNotificationCloseButton().click();
712721

713722
cy.get("#cancellation-and-payment-terms-terms-accepted").click();
@@ -754,7 +763,7 @@ describe("with application", () => {
754763

755764
cy.get("main#main").should(
756765
"contain.text",
757-
"Saat sähköpostiisi (USER@NA.ME) varausvahvistuksen, kun varaus on käsitelty."
766+
"Saat sähköpostiisi (USER@NA.ME) varausvahvistuksen, kun olemme käsitelleet varauksesi."
758767
);
759768
});
760769

@@ -788,7 +797,7 @@ describe("with application", () => {
788797

789798
cy.get("main#main").should(
790799
"contain.text",
791-
"Saat sähköpostiisi (USER@NA.ME) varausvahvistuksen, kun varaus on käsitelty."
800+
"Saat sähköpostiisi (USER@NA.ME) varausvahvistuksen, kun olemme käsitelleet varauksesi."
792801
);
793802
});
794803
});

ui/cypress/e2e/reservations.cy.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ describe("Tilavaraus user reservations", () => {
267267
cancelCancelButton().should("not.be.disabled");
268268

269269
cancelCancelButton().click();
270-
cancelTitle().should("have.text", "Varaus peruttu!");
270+
cancelTitle().should("have.text", "Varauksesi on peruttu!");
271271

272272
reservationInfoCard()
273273
.should("contain.text", ", 2 t")
@@ -325,7 +325,10 @@ describe("Tilavaraus user reservations", () => {
325325
"have.text",
326326
"Varauksen muokkaaminen epäonnistui"
327327
);
328-
errorNotificationBody().should("have.text", "Hyväksy ehdot jatkaaksesi.");
328+
errorNotificationBody().should(
329+
"have.text",
330+
"Hyväksy sopimusehdot jatkaaksesi varausta."
331+
);
329332
errorNotificationCloseButton().click();
330333

331334
cy.get("#cancellation-and-payment-terms-terms-accepted").click();

ui/public/locales/en/common.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,6 @@
105105
"fyiLabel": "For information",
106106
"add": "Add",
107107
"subtract": "Subtract",
108-
"inclTax": "",
108+
"inclTax": "incl. VAT {{taxPercentage}} %",
109109
"headAlt": "Tilan ikoni"
110-
}
110+
}

ui/public/locales/en/dateSelector.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@
33
"dateTypeThisWeek": "This week",
44
"dateTypeToday": "Today",
55
"dateTypeTomorrow": "Tomorrow",
6-
"dateTypeWeekend": "Weekend",
7-
"infoDate": "pp.kk.vvvv",
6+
"dateTypeWeekend": "On the weekend",
7+
"infoDate": "dd.mm.yyyy",
88
"labelEndDate": "End date",
99
"labelStartDate": "Start date",
10-
"errorEndDateBeforeStartDate": "Start date must be before end date",
11-
"errorDateFormat": "Date must be in format: dd.mm.yyyy",
10+
"errorEndDateBeforeStartDate": "The start date must be before the end date",
11+
"errorDateFormat": "The date must be in the format dd.mm.yyyy",
1212
"menu": {
1313
"buttonBack": "Back",
1414
"buttonClose": "Close",
1515
"buttonCustom": "Select dates"
1616
},
17-
"title": "Select dates",
17+
"title": "Select time",
1818
"accessibility": {
19-
"chooseDayPrefix": "Choose",
19+
"chooseDayPrefix": "Select",
2020
"nextMonth": "Next month",
21-
"previousMonth": "Prev month"
21+
"previousMonth": "Previous month"
2222
}
2323
}

ui/public/locales/en/errors.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
"body": "Something unexpected happened"
77
},
88
"general_error": "Undefined error.",
9-
"RESERVATION_UNIT_NOT_RESERVABLE": "",
10-
"OVERLAPPING_RESERVATIONS": "",
11-
"RESERVATION_UNIT_IS_NOT_OPEN": "",
12-
"RESERVATION_UNIT_IN_OPEN_ROUND": "",
13-
"RESERVATION_UNITS_MAX_DURATION_EXCEEDED": "",
14-
"RESERVATION_UNIT_MIN_DURATION_NOT_EXCEEDED": "",
15-
"MAX_NUMBER_OF_ACTIVE_RESERVATIONS_EXCEEDED": "",
16-
"RESERVATION_OVERLAP": "",
17-
"RESERVATION_TIME_DOES_NOT_MATCH_ALLOWED_INTERVAL": "",
18-
"RESERVATION_NOT_WITHIN_ALLOWED_TIME_RANGE": "",
19-
"RESERVATION_UNIT_TYPE_IS_SEASON": ""
9+
"RESERVATION_UNIT_NOT_RESERVABLE": "The item cannot be reserved.",
10+
"OVERLAPPING_RESERVATIONS": "There are duplicate reservations.",
11+
"RESERVATION_UNIT_IS_NOT_OPEN": "The space is closed at the moment.",
12+
"RESERVATION_UNIT_IN_OPEN_ROUND": "You can make a seasonal booking application for this space.",
13+
"RESERVATION_UNITS_MAX_DURATION_EXCEEDED": "Please shorten the reservation time.",
14+
"RESERVATION_UNIT_MIN_DURATION_NOT_EXCEEDED": "Please extend the reservation time.",
15+
"MAX_NUMBER_OF_ACTIVE_RESERVATIONS_EXCEEDED": "You have exceeded the maximum number of reservations.",
16+
"RESERVATION_OVERLAP": "There are duplicate reservations.",
17+
"RESERVATION_TIME_DOES_NOT_MATCH_ALLOWED_INTERVAL": "Please check the reservation time.",
18+
"RESERVATION_NOT_WITHIN_ALLOWED_TIME_RANGE": "Please check the reservation time.",
19+
"RESERVATION_UNIT_TYPE_IS_SEASON": "You can only make a seasonal booking application for this space."
2020
}

ui/public/locales/en/home.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"sauna": "",
2424
"workshop": ""
2525
},
26-
"purposesHeading": "",
27-
"unitsHeading": "",
26+
"purposesHeading": "What would you like to do?",
27+
"unitsHeading": "Where do you want to book the space or equipment?",
2828
"recommendations": "Recommendations"
2929
}

0 commit comments

Comments
 (0)