Merge pull request #135 from CityOfPhiladelphia/fix/refactors-round-3

Fix/refactors round 3

Author: theronhalsey

.github/workflows/ci.yml

@@ -24,8 +24,6 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
-        env:
-          NPM_FONTAWESOME_SECRET: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
 
       - name: Lint
         run: pnpm turbo lint
@@ -98,8 +96,6 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
-        env:
-          NPM_FONTAWESOME_SECRET: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
 
       - name: Install city CLI
         run: npm install -g @phila/cli
@@ -144,8 +140,6 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
-        env:
-          NPM_FONTAWESOME_SECRET: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
 
       - name: Install city CLI
         run: npm install -g @phila/cli
@@ -224,8 +218,6 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
-        env:
-          NPM_FONTAWESOME_SECRET: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
 
       - name: Install city CLI
         run: npm install -g @phila/cli
@@ -270,8 +262,6 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
-        env:
-          NPM_FONTAWESOME_SECRET: ${{ secrets.FONTAWESOME_NPM_AUTH_TOKEN }}
 
       - name: Install city CLI
         run: npm install -g @phila/cli

.npmrc

@@ -1,2 +0,0 @@
-@fortawesome:registry=https://npm.fontawesome.com/
-//npm.fontawesome.com/:_authToken=${NPM_FONTAWESOME_SECRET}

README.md

@@ -50,15 +50,6 @@ You also need to rebuild `packages/ui` whenever you change its source code:
 cd packages/ui && pnpm build
 ```
 
-### FontAwesome Pro
-
-Some dependencies require FontAwesome Pro icons. You need a `.npmrc` file (at the repo root or in your home directory) with your FA Pro auth token:
-
-```
-@fortawesome:registry=https://npm.fontawesome.com/
-//npm.fontawesome.com/:_authToken=YOUR_TOKEN_HERE
-```
-
 Do not commit this file — it is gitignored.
 
 ## Branch strategy

apps/oem-flood-finder/frontend/src/components/LocationDetail.vue

@@ -137,7 +137,6 @@ const lastUpdatedDate = computed(() => {
   flex-shrink: 0;
 }
 
-.detail-header h2,
 .detail-header h4 {
   margin: 0;
   flex: 1;
@@ -159,30 +158,4 @@ const lastUpdatedDate = computed(() => {
   flex-direction: column;
   gap: 0.5rem;
 }
-
-table {
-  width: 100%;
-  border-collapse: collapse;
-  margin: 1rem 0;
-}
-
-th,
-td {
-  border: 1px solid #ddd;
-  padding: 0.75rem;
-  text-align: left;
-}
-
-th {
-  background-color: #f5f5f5;
-  font-weight: 600;
-}
-
-tr:nth-child(even) {
-  background-color: #f9f9f9;
-}
-
-tr:hover {
-  background-color: #f0f0f0;
-}
 </style>

apps/oem-flood-finder/frontend/src/views/FinderView.vue

@@ -66,7 +66,7 @@ const {
 const locationSortMode = ref<PinboardTypes.SortMode>(
   ['located', 'watching'].includes(userLocationState.value) ? 'DistAsc' : '',
 )
-const isMobile = inject(IS_MOBILE_KEY, ref(false))
+const isMobile = inject(IS_MOBILE_KEY, ref(true))
 
 // computed refs
 const currentLocations = computed(() => {

apps/oem-flood-finder/frontend/src/views/ResourcesView.vue

@@ -6,7 +6,7 @@ import { IconChevronLeft } from '@phila/phila-ui-core/icons'
 import { IS_MOBILE_KEY } from '@pinboard/ui'
 import { inject, ref } from 'vue'
 
-const isMobile = inject(IS_MOBILE_KEY, ref(false))
+const isMobile = inject(IS_MOBILE_KEY, ref(true))
 const router = useRouter()
 </script>
 
@@ -144,7 +144,7 @@ const router = useRouter()
   </div>
 </template>
 
-<style>
+<style scoped>
 .layout {
   display: flex;
   justify-content: center;
@@ -167,10 +167,6 @@ const router = useRouter()
   align-items: center;
 }
 
-.content-area.mobile {
-  padding: 1.5rem 1rem 0 1rem;
-}
-
 .section {
   display: flex;
   width: 100%;
@@ -181,11 +177,6 @@ const router = useRouter()
   gap: var(--spacing-4xl, 4rem);
 }
 
-.section.mobile {
-  gap: var(--spacing-2xl, 2rem);
-  padding-bottom: var(--spacing-2xl, 2rem);
-}
-
 .intro-text-container {
   display: flex;
   flex-direction: column;

apps/primary-care-finder/frontend/src/App.vue

@@ -10,7 +10,7 @@ const feedbackHref =
 <template>
   <PinboardShell
     :title="t('app.name')"
-    info-title="About this tool"
+    :info-title="t('app.aboutTitle')"
     :info-label="t('app.aboutTitle')"
     :info-message="t('callout.message')"
     :info-link-text="t('callout.linkText')"

apps/primary-care-finder/frontend/src/views/FinderView.vue

@@ -73,7 +73,7 @@ const defaultFilterState: PrimaryCareFilters = {
   },
 }
 
-const isMobile = inject(IS_MOBILE_KEY, ref(false))
+const isMobile = inject(IS_MOBILE_KEY, ref(true))
 const { t } = useI18n()
 const { locations, languages, isLoading, errorMessage, geojson } = useLocations()
 const { filterChipDefinitions } = useFilterChipDefinitions(languages)
@@ -316,6 +316,7 @@ function getMapCardProps(location: PrimaryCareLocation): MapCardProps {
 }
 
 .locations-callout :deep(.callout-title) {
+  font-family: var(--Body-Default-font-body-default-family);
   font-size: var(--scale-200);
   text-align: left;
 }

apps/primary-care-finder/frontend/src/views/InfoView.vue

@@ -4,7 +4,7 @@ import { useI18n } from 'vue-i18n'
 import { IS_MOBILE_KEY, PinboardInfoPage } from '@pinboard/ui'
 
 const { t } = useI18n()
-const isMobile = inject(IS_MOBILE_KEY, ref(false))
+const isMobile = inject(IS_MOBILE_KEY, ref(true))
 
 const sections = computed(() => [
   { id: 'insurance', title: t('introPage.section2Title') },

package.json

@@ -27,43 +27,13 @@
     "eslint-plugin-vue": "catalog:",
     "globals": "catalog:",
     "prettier": "catalog:",
-    "turbo": "^2.10.6",
+    "turbo": "^2.10.7",
     "typescript": "catalog:",
     "vue-tsc": "catalog:"
   },
   "pnpm": {
     "overrides": {
-      "minimatch@<3.1.3": ">=3.1.3",
-      "minimatch@>=9.0.0 <9.0.6": ">=9.0.6",
-      "minimatch@>=10.0.0 <10.2.1": ">=10.2.1",
-      "rollup@>=4.0.0 <4.59.0": ">=4.59.0",
-      "minimatch@>=9.0.0 <9.0.7": ">=9.0.7",
-      "minimatch@>=10.0.0 <10.2.3": ">=10.2.3",
-      "minimatch@<3.1.4": ">=3.1.4",
-      "ajv@>=7.0.0-alpha.0 <8.18.0": ">=8.18.0",
-      "flatted@<3.4.0": ">=3.4.0",
-      "flatted@<=3.4.1": ">=3.4.2",
-      "brace-expansion@<1.1.13": ">=1.1.13",
-      "brace-expansion@>=2.0.0 <2.0.3": ">=2.0.3",
-      "picomatch@<2.3.2": ">=2.3.2",
-      "picomatch@>=4.0.0 <4.0.4": ">=4.0.4",
-      "yaml@>=2.0.0 <2.8.3": ">=2.8.3",
-      "lodash@>=4.0.0 <=4.17.23": ">=4.18.0",
-      "lodash@<=4.17.23": ">=4.18.0",
-      "vite@<=6.4.1": ">=6.4.2 <8",
-      "vite@>=7.0.0 <=7.3.1": ">=7.3.2",
-      "vite@>=7.1.0 <=7.3.1": ">=7.3.2",
-      "vite@>=6.0.0 <=6.4.1": ">=6.4.2",
-      "vue-router": "5.0.6",
-      "protocol-buffers-schema@<3.6.1": ">=3.6.1",
-      "postcss@<8.5.10": ">=8.5.10",
-      "fast-uri@<=3.1.0": ">=3.1.1",
-      "fast-uri@<=3.1.1": ">=3.1.2",
-      "brace-expansion@>=5.0.0 <5.0.6": ">=5.0.6",
-      "turbo@<=2.9.13": ">=2.9.14",
-      "turbo@>=1.1.0 <2.9.14": ">=2.9.14",
-      "shell-quote@>=1.1.0 <=1.8.3": ">=1.8.4",
-      "@babel/core@<=7.29.0": ">=7.29.6"
+      "vue-router": "5.0.6"
     }
   }
 }