revised quantum counting qmods

Author: roie-d-classiq

algorithms/amplitude_amplification_and_estimation/quantum_counting/quantum_counting_iqae.qmod

@@ -7,19 +7,16 @@
 // this qubit implements the marking oracle used inside amplitude amplification iterations.
 
 
-// Defining the QStruct, containing the quantum variables a and b
+// Defining the qstruct, containing the quantum variables a and b, each with two qubits
 qstruct OracleVars {
   a: qnum<2>;
   b: qnum<2>;
 }
 
 
-// Configuration constants
-A_BITS: int = 2;
-B_BITS: int = 2;
 
-PROBLEM_QUBITS: int = A_BITS + B_BITS;   // 4 qubits: a[2] || b[2]
-THRESHOLD: int = 2;                      // predicate: (a + b) <= THRESHOLD
+PROBLEM_QUBITS: int = 4;   // 4 qubits
+THRESHOLD: int = 2;        // predicate: (a + b) <= THRESHOLD
 
 
 

algorithms/amplitude_amplification_and_estimation/quantum_counting/quantum_counting_qpe.qmod

@@ -11,9 +11,7 @@
 // the solution ratio; QPE extracts an estimate of that phase.
 
 
-// Problem sizes (in qubits)
-A_BITS: int = 2;
-B_BITS: int = 2;
+
 
 // Mark states for which (a + b) <= THRESHOLD
 THRESHOLD: int = 2;
@@ -22,13 +20,13 @@ THRESHOLD: int = 2;
 // Larger values provide finer phase resolution.
 PHASE_QUBITS: int = 5;
 
-// Defining the QStruct, containing the quantum variables a and b
+// Defining the qstruct, containing the quantum variables a and b
 qstruct OracleVars {
   a: qnum<2>;
   b: qnum<2>;
 }
 
-// Predicate: flips `res` iff the input (a, b) is a "good" solution.
+// Predicate: flips `res` iff the input (a, b) is a marked solution.
 qperm arith_equation(const state: OracleVars, res: qbit) {
   res ^= (state.a + state.b) <= 2;
 }
@@ -43,7 +41,7 @@ qfunc arith_oracle(state: OracleVars) {
 qfunc main(output phase_var: qnum<PHASE_QUBITS, UNSIGNED, PHASE_QUBITS>) {
   state_var: OracleVars;
 
-  allocate(state_var);  // Initiates the ancilla QStruct
+  allocate(state_var);  // Initiates the ancilla qstruct
   allocate(phase_var);  // Initiates the phase quantum variable
 
   // Prepare a uniform superposition over all (a, b) inputs.