ci: deploy docs to github pages

Author: ClaudiuCeia

.github/workflows/pages.yml

@@ -0,0 +1,52 @@
+name: Deploy Docs (GitHub Pages)
+
+on:
+  push:
+    branches: ["main"]
+  workflow_dispatch: {}
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+concurrency:
+  group: "pages"
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Deno
+        uses: denoland/setup-deno@v2
+        with:
+          deno-version: v2.x
+
+      - name: Test
+        run: deno task test
+
+      - name: Build docs bundle
+        run: deno task docs:bundle
+
+      - name: Configure Pages
+        uses: actions/configure-pages@v5
+
+      - name: Upload artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: docs
+
+  deploy:
+    needs: build
+    runs-on: ubuntu-latest
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+    steps:
+      - name: Deploy to GitHub Pages
+        id: deployment
+        uses: actions/deploy-pages@v4

docs/app.js

@@ -301,10 +301,23 @@ const groupByStart = (entities) => {
   const display = [];
   for (const s of starts) {
     const arr = map.get(s) ?? [];
-    arr.sort((a, b) => (b.end - a.end) || String(a.kind).localeCompare(b.kind));
+    // For the hovercard, keep "most informative" (longest) first.
+    arr.sort((a, b) =>
+      (b.end - b.start) - (a.end - a.start) ||
+      (b.end - a.end) ||
+      String(a.kind).localeCompare(b.kind)
+    );
     if (!arr.length) continue;
     groups.push(arr);
-    display.push(arr[0]); // representative for annotation
+
+    // For annotation, prefer the smallest (shortest) match so we don't hide
+    // inner groups (e.g. CC + 4x quantity chunks).
+    const smallest = [...arr].sort((a, b) =>
+      (a.end - a.start) - (b.end - b.start) ||
+      (a.end - b.end) ||
+      String(a.kind).localeCompare(b.kind)
+    )[0];
+    display.push(smallest);
   }
   return { map, groups, display };
 };

tests/CreditCard.test.ts

@@ -34,3 +34,29 @@ Deno.test("Credit card invalid does not parse", () => {
     assertEquals(res.value, []);
   }
 });
+
+Deno.test("Duckling extracts CC + 4-digit groups (step shortest)", () => {
+  const text = "CC 4242 4242 4242 4242";
+  const res = Duckling().extract({ text, index: 0 });
+
+  assertEquals(res.success, true);
+  if (!res.success) return;
+
+  assertEquals(
+    res.value.some((e) =>
+      e.kind === "credit_card" && e.text === "4242 4242 4242 4242"
+    ),
+    true,
+  );
+
+  const groups = res.value.filter((e) =>
+    e.kind === "quantity" && e.text === "4242"
+  );
+  assertEquals(groups.length, 4);
+  assertEquals(groups.map((e) => [e.start, e.end]), [
+    [3, 7],
+    [8, 12],
+    [13, 17],
+    [18, 22],
+  ]);
+});