Don't allocate when calculating the digest of code (#692)

AnsisMalins · web-flow · commit 2f337ec2ed1c · 2025-11-04T11:53:17.000-05:00
diff --git a/ClearScript/Util/MiscHelpers.cs b/ClearScript/Util/MiscHelpers.cs
@@ -246,7 +246,7 @@ public static uint GetDigestAsUInt32(this string code)
 
             unchecked
             {
-                var bytes = Encoding.Unicode.GetBytes(code);
+                var bytes = MemoryMarshal.AsBytes(code.AsSpan());
                 for (var index = 0; index < bytes.Length; index++)
                 {
                     digest ^= bytes[index];
@@ -262,7 +262,7 @@ public static ulong GetDigestAsUInt64(this string code)
             var digest = 14695981039346656037UL;
             const ulong prime = 1099511628211UL;
 
-            var bytes = Encoding.Unicode.GetBytes(code);
+            var bytes = MemoryMarshal.AsBytes(code.AsSpan());
             for (var index = 0; index < bytes.Length; index++)
             {
                 digest ^= bytes[index];

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ public static uint GetDigestAsUInt32(this string code)`
`246`	`246`
`247`	`247`	`unchecked`
`248`	`248`	`{`
`249`		`- var bytes = Encoding.Unicode.GetBytes(code);`
	`249`	`+ var bytes = MemoryMarshal.AsBytes(code.AsSpan());`
`250`	`250`	`for (var index = 0; index < bytes.Length; index++)`
`251`	`251`	`{`
`252`	`252`	`digest ^= bytes[index];`
`@@ -262,7 +262,7 @@ public static ulong GetDigestAsUInt64(this string code)`
`262`	`262`	`var digest = 14695981039346656037UL;`
`263`	`263`	`const ulong prime = 1099511628211UL;`
`264`	`264`
`265`		`- var bytes = Encoding.Unicode.GetBytes(code);`
	`265`	`+ var bytes = MemoryMarshal.AsBytes(code.AsSpan());`
`266`	`266`	`for (var index = 0; index < bytes.Length; index++)`
`267`	`267`	`{`
`268`	`268`	`digest ^= bytes[index];`