Login to dockerhub early for private image pulls (#28)

mohit · web-flow · commit ccdc6a6e0595 · 2017-06-09T16:58:57.000-07:00
diff --git a/circleci/docker-publish b/circleci/docker-publish
@@ -20,7 +20,6 @@ check_hub_vars() {
 }
 
 push_hub_image() {
-  docker login -u $DOCKER_USER -p $DOCKER_PASS --email="$DOCKER_EMAIL"
   docker push $ORG/$REPO:$SHORT_SHA
 }
 
@@ -54,6 +53,10 @@ if [ "$ECR_PUSH_ID" != "" ]; then
   check_ecr_vars
 fi
 
+# dockerhub login. 
+# `FROM image` in Dockerfile is going to pull from DockerHub
+docker login -u $DOCKER_USER -p $DOCKER_PASS --email="$DOCKER_EMAIL"
+
 echo "Building docker image..."
 docker build -t $ORG/$REPO:$SHORT_SHA .
 

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ check_hub_vars() {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`push_hub_image() {`
`23`		`- docker login -u $DOCKER_USER -p $DOCKER_PASS --email="$DOCKER_EMAIL"`
`24`	`23`	`docker push $ORG/$REPO:$SHORT_SHA`
`25`	`24`	`}`
`26`	`25`
`@@ -54,6 +53,10 @@ if [ "$ECR_PUSH_ID" != "" ]; then`
`54`	`53`	`check_ecr_vars`
`55`	`54`	`fi`
`56`	`55`
	`56`	`+# dockerhub login.`
	`57`	+# `FROM image` in Dockerfile is going to pull from DockerHub
	`58`	`+docker login -u $DOCKER_USER -p $DOCKER_PASS --email="$DOCKER_EMAIL"`
	`59`	`+`
`57`	`60`	`echo "Building docker image..."`
`58`	`61`	`docker build -t $ORG/$REPO:$SHORT_SHA .`
`59`	`62`